We have insert_final_newline = true to ensure files will contain a new line at the end. However we have seen commits with "No new line" added in the git log. We should have a xt test to prevent more occurrences. We should also have a test at the QA script level: https://gitlab.com/koha-community/qa-test-tools/-/issues/96 Test plan: prove xt/find-missing-new-lines-at-the-end-of-file.t should return green. Remove the new line at the end of a file, eg. vim -b mainpage.pl :set noeol :wq Now prove xt/find-missing-new-lines-at-the-end-of-file.t is failing on mainpage.pl. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> |
||
|---|---|---|
| .. | ||
| auth_val.yml | ||
| csv_profiles.yml | ||
| marc21_holdings_coded_values.yml | ||
| marc21_relatorterms.yml | ||
| parameters.yml | ||
| patron_atributes.yml | ||
| patron_categories.yml | ||
| sample_creator_data.yml | ||
| sample_itemtypes.yml | ||
| sample_libraries.yml | ||
| sample_libraries_holidays.yml | ||
| sample_news.yml | ||
| sample_patrons.yml | ||
| sample_quotes.yml | ||
| sample_z3950_servers.yml | ||