Koha-clms/Koha/REST
Tomas Cohen Arazi ec322648b6
Bug 38926: Make POST /biblios return 400 if AddBiblio fails
We don't have proper exceptions in the `C4::Biblio::AddBiblio` method,
but we at least know `$biblio_id` will be `undef` in the even of an
error processing the call.

This patch makes the controller handle this situation so (at least) it
is obvious that something bad happened.

To test:
1. Apply the regression tests patch
2. Run:
   $ ktd --shell
  k$ prove t/db_dependent/api/v1/biblios.t
=> FAIL: Tests fail! The endpoint returns 200 even on error!
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass! The endpoint returns a 400 with a reasonable
message!
5. Sign off :-D

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit a98760a994)
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
2025-04-22 23:02:13 +02:00
..
Plugin Bug 28907: Add Koha::REST::Plugin::Auth::PublicRoutes 2025-02-18 19:17:17 +01:00
V1 Bug 38926: Make POST /biblios return 400 if AddBiblio fails 2025-04-22 23:02:13 +02:00
V1.pm Bug 38454: Flush memory cache before every API request 2025-02-18 19:17:19 +01:00