Go to file
Nick Clemens eb956eb4cf Bug 22753: Fix hold priority adjustment, move to top
Since the holds table can be split we need to calculate the
first priority for each table. However, currently we use the
first in the loop, not taking into account the waiting status.
This patchset sets the first_priority to the first non-found hold

Additionally, some clean-up is done to not display the alter
priority arrows for waiting holds.

To test:
1 - Place several holds on a title
2 - Confirm one of the holds to be waiting
3 - Attempt to move the last hold to the top
4 - Nothing happens
5 - Apply patch
6 - Note that the waiting hold has no options to move in the list
7 - Attempt to move the last hold to the top
8 - It moves as expected!
9 - Split the holds queue by pickup library
10 - PLace some holds for pickup at another branch
11 - Confirm moving these holds works within their own table
12 - Unsplit the queue
13 - Ensure the holds end where you expect (moving in a split
     table didn't move above holds form another table)

Signed-off-by: Liz Rea <wizzyrea@gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2019-04-25 09:59:09 +00:00
C4 Bug 22759: Fix wrong check of branch rule in C4::Circulation::TooMany 2019-04-24 10:35:02 +00:00
Koha Bug 22701: Make items prefetchable from Koha::Biblio 2019-04-24 10:56:33 +00:00
OpenILS
…
acqui Bug 22762: Fix items.collection display on receiving 2019-04-25 09:52:31 +00:00
admin Bug 22679: Delete related CirculationRules when Removing IssuingRule 2019-04-24 10:35:38 +00:00
api/v1 Bug 21336: Fix the API 2019-04-18 09:49:57 +00:00
authorities Bug 19994: Used Modern::Perl in Authorities perl scripts 2019-01-28 14:58:23 +00:00
basket Bug 21993: Display a user-friendly message when the CSRF token is wrong 2019-01-25 20:38:32 +00:00
catalogue Bug 22762: Fix items.collection display on receiving 2019-04-25 09:52:31 +00:00
cataloguing Bug 22748: Pass userid to haspermission 2019-04-24 10:45:12 +00:00
circ Bug 22521: Update fines handling to use accountline.status 2019-04-17 16:49:36 +00:00
clubs Bug 18632: Remove 'CGI::param called in list context' warnings 2017-05-28 22:25:22 -04:00
course_reserves Bug 21003: Removed warning and changed wording on add_items-step2.tt 2019-03-23 09:51:36 +00:00
debian Bug 17746: (QA follow-up) Make set_password.pl generate a password if required 2019-03-28 11:58:20 +00:00
docs Bug 8701: Remove links to OpacHiddenItems.txt in favor of wiki page 2019-04-18 09:58:36 +00:00
errors Bug 19998: use Modern::Perl in error perl scripts 2018-02-05 09:45:48 -03:00
etc Revert "Bug 15253: Add Koha::Logger based logging for SIP2" 2019-04-18 17:57:51 +00:00
ill Bug 18589: Show ILLs as part of patron profile 2019-03-22 20:21:46 +00:00
installer Bug 22564: DBRev 18.12.00.060 2019-04-19 14:51:08 +00:00
koha-tmpl Bug 22753: Fix hold priority adjustment, move to top 2019-04-25 09:59:09 +00:00
labels Bug 21206: Replace C4::Items::GetItem 2019-02-26 13:24:07 +00:00
members Bug 22139: Fields of ACCTDETAILS email not populating 2019-04-18 09:56:43 +00:00
misc Bug 22755: Fix pod in patron_emailer.pl 2019-04-24 10:43:55 +00:00
offline_circ Bug 22600: Add 'interface' to accountlines 2019-04-10 19:43:11 +00:00
opac Bug 22696: Prefetch items too 2019-04-24 10:56:34 +00:00
patron_lists Bug 19524: Use existing logged_in_user variable 2018-07-18 16:49:30 +00:00
patroncards Bug 21719: Fix typos 2018-11-08 02:18:46 +00:00
plugins Bug 20011: use Modern::Perl in plugins perl scripts 2018-02-05 09:46:44 -03:00
reports Bug 22090: Add missing information to cash register CSV file 2019-04-16 13:17:32 +00:00
reserve Bug 17978: Check if hold can be placed before placing on placerequest.pl 2019-04-10 19:59:28 +00:00
reviews Bug 18789: Send Koha::Patron object to the templates 2018-02-16 13:03:58 -03:00
rotating_collections Bug 21500: Remove warnings in rotating collections 2018-10-09 15:02:45 +00:00
serials Bug 15774: (follow-up) fix rebase issues 2019-03-07 20:37:06 +00:00
services Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
skel
…
suggestion Bug 21048: (QA follow-up) Fix authorized value statuses in filter 2018-08-08 20:58:23 +00:00
svc Bug 22250: Clean up Mana KB integration with serials and reports 2019-04-11 11:34:14 +00:00
t Bug 22701: Unit tests for Koha::Biblio->items 2019-04-24 10:56:33 +00:00
tags Bug 22036: Indented code where '^I' was written rather than an indent. 2019-01-17 02:23:28 +00:00
test Bug 9819 - 'stopwords'-related code removed 2015-12-30 15:49:35 +00:00
tmp/modified_authorities
…
tools Bug 22365: Removing warn when accessing Log Viewer 2019-04-19 14:24:26 +00:00
virtualshelves Bug 21206: Replace C4::Items::GetItem 2019-02-26 13:24:07 +00:00
xt Bug 21576: Keep compatibility with QA script 2018-10-26 17:09:52 +00:00
.editorconfig
…
.gitignore Bug 20427: Convert OPAC LESS to SCSS 2018-08-09 15:17:07 +00:00
.htaccess
…
.mailmap Update mailmap - Jonathan Druart 2017-06-21 12:42:19 -03:00
.scss-lint.yml Bug 21237: Clean up staff client SCSS 2018-08-24 16:23:25 +00:00
INSTALL Bug 17626: Remove existing install instructions and link to the wiki pages instead 2016-11-22 11:29:07 +00:00
Koha.pm Bug 22564: DBRev 18.12.00.060 2019-04-19 14:51:08 +00:00
LICENSE
…
MANIFEST.SKIP
…
Makefile.PL Bug 20174: Remove xml_sax.pl target from Makefile.pl 2019-02-15 18:42:48 +00:00
README
…
README.md Bug 15465: Fix typo in bugs.k-c.org 2017-05-26 11:45:31 -03:00
README.robots
…
about.pl Bug 20996: Remove prefix use of borrower category 2018-11-02 10:33:02 +00:00
changelanguage.pl Bug 21299: (QA follow-up) Rename module and subroutine 2018-11-07 21:52:17 +00:00
fix-perl-path.PL Bug 9978: (followup) Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:43 -03:00
gulpfile.js Bug 21751: Replace fixFloat with HC-sticky to fix Chrome display 2019-02-04 14:13:35 +00:00
help.pl Bug 19817: Use the language from the interface if valid 2018-09-06 17:32:28 +00:00
koha_perl_deps.pl Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
kohaversion.pl Bug 13758: Move the Koha version from kohaversion.pl 2015-05-07 11:39:04 -03:00
mainpage.pl Bug 21907: Fix article requests count for non-superlibrarians 2019-02-04 14:50:40 +00:00
package.json Bug 19474: Convert staff client CSS to SCSS 2018-08-09 15:12:20 +00:00
rewrite-config.PL Bug 14302: Remove GRS1 specific code 2018-08-31 11:24:20 +00:00
yarn.lock Bug 19474: Convert staff client CSS to SCSS 2018-08-09 15:12:20 +00:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo