Koha-clms/opac
Marcel de Rooy 7b224a7d35 Bug 14683: [QA Follow-up] Mixup between mobile and smsalertnumber
This is an issue discussed on older reports already in the past.
Column mobile in borrowers is actually 'Other phone', not necessary a
mobile number. The name of the field is confusing. (Renaming it is
outside the scope of this report.)
The field that we are editing here is smsalertnumber. It should not be
compared with mobile at all.

What could be the side-effect of this correction?
===
First, the change is only relevant for libraries with pref SMSSendDriver
enabled.
In the past patrons editing their message preferences saw mobile (read:
other phone) in their smsalertnumber field (if the latter was still empty).
If they saved it, it was copied to smsalertnumber.
This change does not affect these patrons. They just have the same number
in two columns. No big deal.
What if a patron does not yet have a smsalertnumber? In that case no sms
is sent in Letters.pm. So no change in behavior. If he submits
opac-messaging now, he will no longer copy his other phone to smsalert [we
cannot assume that it was mobile anyway!]. If he enters a mobile number,
it will be saved correctly in the right field.

Conclusion: this change will not break things or hurt anyone. It only
prevents unwanted copying other phone to smsalertnumber.

Also modified the compare to prevent uninitialized warnings.
And removed a commented warn.

Test plan:
[1] Add, edit or delete the SMS number on opac-messaging regardless of
    the value of Other Phone (in the badly named mobile field).

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 9b8d7168be)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
(cherry picked from commit bc72046421)
Signed-off-by: Liz Rea <wizzyrea@gmail.com>
2015-09-23 11:08:15 +12:00
..
errors Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-22 11:28:36 +12:00
rss adding file just for creating the rss directory 2007-08-02 08:50:43 +00:00
sco Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-22 11:28:36 +12:00
svc Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-22 11:28:36 +12:00
ilsdi.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-22 11:28:36 +12:00
maintenance.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-22 11:28:36 +12:00
oai.pl Bug 14721: OAI-PMH must return error when no results 2015-09-22 16:42:41 +12:00
opac-ISBDdetail.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-22 11:28:36 +12:00
opac-MARCdetail.pl Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
opac-account.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-22 11:28:36 +12:00
opac-addbybiblionumber.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-22 11:28:36 +12:00
opac-alert-subscribe.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-22 11:28:36 +12:00
opac-authorities-home.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-22 11:28:36 +12:00
opac-authoritiesdetail.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-22 11:28:36 +12:00
opac-basket.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-22 11:28:36 +12:00
opac-blocked.pl Bug 10195: (follow-up) update license; use Modern::Perl 2014-05-05 15:37:20 +00:00
opac-browser.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-22 11:28:36 +12:00
opac-changelanguage.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-22 11:28:36 +12:00
opac-course-details.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-22 11:28:36 +12:00
opac-course-reserves.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-22 11:28:36 +12:00
opac-detail.pl Bug 14496: Improving opac-detail.pl performances 2015-07-16 10:27:01 +00:00
opac-downloadcart.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-22 11:28:36 +12:00
opac-downloadshelf.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-22 11:28:36 +12:00
opac-export.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-22 11:28:36 +12:00
opac-ics.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-22 11:28:36 +12:00
opac-image.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-22 11:28:36 +12:00
opac-imageviewer.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-22 11:28:36 +12:00
opac-main.pl BUG8446, Follow up: Improve local login fallback 2014-10-16 12:27:51 -03:00
opac-memberentry.pl Bug 11693: Default emailing preferences not loaded for self registering patron 2015-08-11 09:20:44 +12:00
opac-messaging.pl Bug 14683: [QA Follow-up] Mixup between mobile and smsalertnumber 2015-09-23 11:08:15 +12:00
opac-modrequest-suspend.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-22 11:28:36 +12:00
opac-modrequest.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-22 11:28:36 +12:00
opac-mymessages.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-22 11:28:36 +12:00
opac-overdrive-search.pl Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
opac-passwd.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-22 11:28:36 +12:00
opac-patron-image.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-22 11:28:36 +12:00
opac-privacy.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-22 11:28:36 +12:00
opac-ratings-ajax.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-22 11:28:36 +12:00
opac-ratings.pl Bug 14440: get_template_and_user can not have an empty template_name (opac-ratings.pl) 2015-07-05 03:31:53 +00:00
opac-readingrecord.pl Bug 14185: Undefined $limit causes warn in opac/opac-readingrecord.pl 2015-06-08 10:24:43 +12:00
opac-registration-verify.pl Bug 11693: Default emailing preferences not loaded for self registering patron 2015-08-11 09:20:44 +12:00
opac-renew.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-22 11:28:36 +12:00
opac-reserve.pl Bug 14186 [QA Followup]: Undefined $reservedfor causes warn in opac-reserve.pl 2015-06-08 10:24:27 +12:00
opac-review.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-22 11:28:36 +12:00
opac-search-history.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-22 11:28:36 +12:00
opac-search.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-22 11:28:36 +12:00
opac-sendbasket.pl Bug 14330: Remove unused email_sender from sendbasket/sendshelf 2015-06-16 10:18:41 +12:00
opac-sendshelf.pl Bug 14330: Remove unused email_sender from sendbasket/sendshelf 2015-06-16 10:18:41 +12:00
opac-serial-issues.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-22 11:28:36 +12:00
opac-shareshelf.pl Bug 14266: Trim the email address in the pl script 2015-06-08 12:01:07 +12:00
opac-shelves.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-22 11:28:36 +12:00
opac-showmarc.pl Bug 13170 Remove of prog theme broke the OPAC's "view plain" option for MARC details 2014-11-04 18:52:53 -03:00
opac-showreviews.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-22 11:28:36 +12:00
opac-suggestions.pl Bug 4137: Fix the OPACViewOthersSuggestions behavior 2015-07-05 02:24:26 +00:00
opac-tags.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-22 11:28:36 +12:00
opac-tags_subject.pl Bug 14412 : SQL injection possible 2015-06-20 12:44:42 +12:00
opac-topissues.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-22 11:28:36 +12:00
opac-user.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-22 11:28:36 +12:00
tracklinks.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-22 11:28:36 +12:00
unapi Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-22 11:28:36 +12:00