Go to file
Jonathan Druart e7f5161bc7 Bug 17323: Column search_history.time cannot be null
When doing a search, with SearchHistory pref switched on:

DBD::mysql::st execute failed: Column 'time' cannot be null [for Statement "
        INSERT INTO search_history(
            userid, sessionid, query_desc, query_cgi, type, total, time
        ) VALUES(
            ?, ?, ?, ?, ?, ?, ?
        )
    " with ParamValues: 0="7874", 1='12338a0bd8da63e32c79ee84f8493a07', 2="kw,wrdl: d", 3='q=d', 4='biblio', 5=6104, 6=undef] at C4/Search/History.pm line 34.

Since MySLQ 5.7, undef does not mean "the default value".
To let the DBMS set the default value (CURRENT_TIMESTAMP), the parameter should not be passed

Test plan:
OPAC+Intranet, swith the 2 SearchHistory syspref on
Do a search
=> Without this patch, you will get an error in the log and the row will not be inserted in the table.
=> With this patch, everything must go fine

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Not verified with MySQL 5.7. But this looks good to me.
Works under Jessie.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit 6d5b056a14)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
2016-11-30 14:06:47 +01:00
C4 Bug 17323: Column search_history.time cannot be null 2016-11-30 14:06:47 +01:00
Koha Bug 14598: Fix warning from effective_itemtype 2016-11-30 13:48:07 +01:00
OpenILS
…
acqui Bug 16493: [QA Followup] Restore title and author match as an option, make it the default 2016-11-30 13:01:19 +01:00
admin Bug 17389: (bug 16035 follow-up) Fix export non-default frameworks 2016-10-24 12:02:11 +02:00
api/v1 Bug 13799: Add types for patron's fields in Swagger spec 2015-11-04 13:47:33 -03:00
authorities Bug 16154: CGI->multi_param - Force scalar context 2016-05-16 14:42:43 +02:00
basket Bug 16447: Remove occurrence of the borrow permission which does no longer exist 2016-05-16 11:37:09 +02:00
catalogue Bug 17484: Search with date range limit (lower and upper) does not work 2016-11-30 14:03:57 +01:00
cataloguing Bug 16358: Do not redirect to the editor when deleting records 2016-10-24 12:32:00 +02:00
circ Bug 17352 - Patron search type is hard coded to 'contain' in circ/circulation.pl 2016-10-24 11:35:49 +02:00
course_reserves Bug 16154: CGI->multi_param - Force scalar context 2016-05-16 14:42:43 +02:00
debian Bug 4880: Make koha-remove stop all instance's services 2016-11-08 11:00:54 +01:00
docs Bug 7143: Updates for the 3.22 release 2015-11-10 11:01:07 -03:00
errors
…
etc Bug 17035 - Koha allows system-wide 'read' access to all Koha zebra databases, by default 2016-10-24 11:43:16 +02:00
install_misc Bug 16770: Remove 2 other occurrences of libmemoize-memcached-perl 2016-08-16 15:33:27 +02:00
installer Bug 14598: Update DB rev (3.22.12.002) 2016-11-30 14:01:04 +01:00
koha-tmpl Bug 15690: Hardcoded 16 is uncool 2016-11-30 13:26:34 +01:00
labels Bug 16154: CGI->multi_param - Assign a list 2016-05-16 14:42:51 +02:00
members Bug 17375: Search by dateofbirth - handle invalid dates 2016-11-08 10:17:35 +01:00
misc Bug 17420 - record export fails when itemtype on biblio - followup 2016-11-30 13:20:17 +01:00
offline_circ Bug 15764: Fix timestamp sent by KOCT 2016-02-26 15:47:37 +01:00
opac Bug 17484: Search with date range limit (lower and upper) does not work 2016-11-30 14:03:57 +01:00
patron_lists Bug 16154: CGI->multi_param - Force scalar context 2016-05-16 14:42:43 +02:00
patroncards Bug 14138: Followup for 3.22 2016-08-25 10:30:29 +02:00
plugins Bug 14951: Remove C4::Dates from plugins/*.pl files 2015-10-06 10:29:42 -03:00
reports Bug 16816: Do not copy parameters used when duplicating a report 2016-10-14 13:57:24 +02:00
reserve Bug 17028: Fix XSS in reserve/request.pl 2016-08-17 14:14:48 +02:00
reviews Bug 14779: Cannot paginate reviews 2015-09-07 11:38:26 -03:00
rotating_collections Bug 15066: Make transfer rotating collection works under Plack 2015-11-05 09:50:09 -03:00
selenium
…
serials Bug 12178: Update serial status to "claimed" when exporting to CSV 2016-08-17 11:33:26 +02:00
services
…
skel
…
sms Bug 15258: Fix Perl scripts declaring unused variables 2015-12-31 14:32:53 +01:00
suggestion Bug 16154: CGI->multi_param - Declare a list 2016-05-16 14:38:51 +02:00
svc Bug 17375: Search by dateofbirth - handle invalid dates 2016-11-08 10:17:35 +01:00
t Bug 17323: Column search_history.time cannot be null 2016-11-30 14:06:47 +01:00
tags Bug 16154: CGI->multi_param - Assign a list 2016-05-16 14:42:51 +02:00
test Bug 14321: Final cleanup, removing obsolete files 2015-09-25 12:02:52 -03:00
tmp/modified_authorities
…
tools Bug 17420 - record export fails when itemtype on biblio 2016-11-30 13:20:17 +01:00
virtualshelves Bug 17316: Do not display the list's name if the user does not have permission - Staff 2016-10-14 12:27:38 +02:00
xt Bug 13632: (QA followup) remove xt/permissions.t 2015-10-19 12:42:59 -03:00
.editorconfig
…
.htaccess
…
.mailmap (RM followup) .mailmap updates 2015-05-22 17:02:21 -03:00
INSTALL
…
INSTALL.debian
…
INSTALL.fedora7 Bug 9809: Remove one more occurrence of reserveconstraints 2015-08-26 10:27:01 -03:00
INSTALL.opensuse
…
INSTALL.ubuntu
…
Koha.pm Bug 14598: Update DB rev (3.22.12.002) 2016-11-30 14:01:04 +01:00
LICENSE
…
MANIFEST.SKIP
…
Makefile.PL Bug 17044: Fix wrong destination for 'api' directory 2016-08-17 15:47:12 +02:00
README
…
README.robots
…
about.pl Bug 12721 - Syspref StatisticsFields: Warning on About page and text change in System preferences 2016-05-09 10:40:44 +02:00
changelanguage.pl Bug 16776: Do not forget external language choice in language switcher 2016-08-23 17:39:21 +02:00
edithelp.pl Bug 16447: Remove occurrence of the borrow permission which does no longer exist 2016-05-16 11:37:09 +02:00
fix-perl-path.PL
…
help.pl Bug 14812: Display the help in the correct language 2015-10-02 15:06:08 -03:00
install-CPAN.pl
…
koha_perl_deps.pl
…
kohaversion.pl Bug 13758: Move the Koha version from kohaversion.pl 2015-05-07 11:39:04 -03:00
mainpage.pl Bug 10904: (QA followup) Use branch limit if either IndependentBranches or IndependentBranchesPatronModifications is enabled 2015-11-02 12:34:46 -03:00
rewrite-config.PL Bug 16222: (QA followup) Add /api dir for the API 2016-04-21 09:33:01 +02:00

README

Koha is a free software integrated library system.

Koha is distributed under the GNU GPL version 3 or later.
Please read the file LICENSE for more details.

To install or upgrade Koha, please see the INSTALL file appropriate
to your platform.

Report bugs at http://bugs.koha-community.org/

Visit the Koha Project website at http://www.koha-community.org/