gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Koha-clms/serials
History
Kyle M Hall d003bfa37c Bug 10277 - Add C4::Context->IsSuperLibrarian() 
The method of checking the logged in user for superlibrarian privileges
is obtuse ( $userenv && $userenv->{flags} % 2 != 1 ) to say the least.
The codebase is littered with these lines, with no explanation given. It
would be much better if we had one subroutine that returned a boolean
value to tell us if the logged in user is a superlibrarian or not.

Test Plan:
1) Apply this patch
2) Verify superlibrarian behavior remains unchanged

Signed-off-by: Joel Sasse <jsasse@plumcreeklibrary.net>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Comments on second patch.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit fb4025b67b)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
 		2014-08-07 09:36:50 +02:00
..
acqui-search-result.pl Bug 10723: Merge GetPendingOrders and SearchOrders routines 2013-10-21 18:24:32 +00:00
acqui-search.pl Cherry-picked onto master, fixing conflicts: MT 1816: Granular permissions for the serials module 2010-06-19 07:23:46 -04:00
checkexpiration.pl Bug 9108: Followup: send the dateformat value from C4::Auth 2013-01-17 21:59:30 -05:00
claims.pl Bug 10429: improve display of library and library filter on serials claim page 2014-02-18 09:10:57 +01:00
create-numberpattern.pl Bug 7688: (follow-up) update license statements 2013-10-30 02:56:32 +00:00
lateissues-export.pl Bug 7298: (follow-up) various QA fixes 2013-10-31 15:51:25 +00:00
member-search.pl Bug 10277 - Add C4::Context->IsSuperLibrarian() 2014-08-07 09:36:50 +02:00
reorder_members.pl Bug 6296: allow users to be authenticated by SSL client certs 2012-03-19 17:02:44 +01:00
routing-preview.pl Bug 9823: Refactor return from GetReservesFromBiblionumber 2014-05-27 12:17:44 +02:00
routing.pl bug 10365: change routing slips to use date published rather than planned date 2013-10-10 23:38:11 +00:00
serial-issues.pl Bug 11715: require authentication for various staff scripts 2014-06-26 14:08:24 +02:00
serials-collection.pl Bug 11214: improve create/edit routing list links in serial collection page 2013-12-13 15:39:19 +01:00
serials-edit.pl Bug 8435: add permission to enable editing other library's serials if IndependantBranches is on 2013-10-31 15:27:19 +00:00
serials-home.pl Bug 5357: Adds a new page for searching subscriptions 2012-09-18 22:37:11 +02:00
serials-recieve.pl Bug 7688: Change subscription numbering pattern and frequencies 2013-10-30 00:29:38 +00:00
serials-search.pl Bug 10852: serials search improvements 2013-12-30 10:31:33 +01:00
showpredictionpattern.pl Bug 12003: Do not calculate next pubdate for irregular subscriptions 2014-08-06 12:20:30 +02:00
subscription-add.pl Bug 10277 - Add C4::Context->IsSuperLibrarian() 2014-08-07 09:36:50 +02:00
subscription-bib-search.pl Bug 11091: (follow-up) perltidy on serials/subscription-bib-search.pl 2013-12-17 17:07:34 +01:00
subscription-detail.pl Bug 8435: add permission to enable editing other library's serials if IndependantBranches is on 2013-10-31 15:27:19 +00:00
subscription-frequencies.pl Bug 11226: subscription frequencies and numbering patterns should be editable with serials permissions 2014-07-25 14:10:45 +02:00
subscription-frequency.pl Bug 7688: (follow-up) update license statements 2013-10-30 02:56:32 +00:00
subscription-history.pl Bug 7688: (follow-up) update license statements 2013-10-30 02:56:32 +00:00
subscription-numberpattern.pl Bug 7688: (follow-up) update license statements 2013-10-30 02:56:32 +00:00
subscription-numberpatterns.pl Bug 11226: subscription frequencies and numbering patterns should be editable with serials permissions 2014-07-25 14:10:45 +02:00
subscription-renew.pl bug 10728: fix additional log noise generated by subscription-renew.pl 2013-08-19 14:10:38 +00:00
viewalerts.pl Bug 5337: EAN management : Adds ean for various searches 2012-06-09 18:26:34 +02:00