Koha-clms/cataloguing
Fridolin Somers 642355033e Bug 18833: Plugin unimarc_field_210c pagination error
In plugin unimarc_field_210c, the editors search results have pagination.
First page works but not other pages.

The main problem whas mainly because $startfrom var was missused. It is defined in C4::Output::pagination_bar as page number.
This patch corrects by using a $offset var.
Also removes dead code, obsoleted by using C4::Output::pagination_bar.
Also changes hardcoded results per page from 19 to 20.

Test plan :
- Use UNIMARC catalogue
- Define in framework value builder unimarc_field_210c on 210$c
- Create autority type EDITORS with heading 200$b
- Create 22 authorities of that type
- Index those new authorities
- Create a new biblio record
- Click on 210$c plugin
- Click on "Search"
- You see 20 results
- Click on page 2
=> Without patch you get empty table
=> With patch you get 2 results
- Check that you see "Results 21 to 22 of 22"
- Delete 2 autorities and retest

Works as intended.

Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 455d94eec9)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2017-12-20 09:13:16 +01:00
..
value_builder Bug 18833: Plugin unimarc_field_210c pagination error 2017-12-20 09:13:16 +01:00
addbiblio.pl Bug 16204: Show friendly error message if trying to edit record which no longer exists 2017-10-23 17:00:05 +02:00
addbooks.pl Bug 15801: Koha::BiblioFrameworks - Remove C4::Koha::getframeworks 2016-10-28 12:04:59 +00:00
additem.pl Bug 15173: Restore SubfieldsToAllowForRestrictedEditing 2017-10-25 10:04:12 +02:00
editor.pl Bug 11559: (QA followup) fix several small issues 2015-10-27 12:25:01 -03:00
linkitem.pl Bug 15758: Koha::Libraries - Ultimate duel for C4::Branch 2016-09-08 14:36:04 +00:00
merge.pl Revert "Bug 18295: C4::Items - Remove get_itemnumbers_of" 2017-06-12 09:17:26 +02:00
merge_ajax.pl Bug 14588: Simplify merge_ajax.pl 2015-08-21 10:21:39 -03:00
moveitem.pl Bug 15758: Koha::Libraries - Ultimate duel for C4::Branch 2016-09-08 14:36:04 +00:00
plugin_launcher.pl Bug 16154: CGI->multi_param - Force scalar context 2016-04-26 23:16:43 +00:00
ysearch.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
z3950_auth_search.pl Bug 16154: CGI->multi_param - Force scalar context 2016-04-26 23:16:43 +00:00
z3950_search.pl Bug 16154: CGI->multi_param - Declare a list 2016-04-26 23:16:42 +00:00