Go to file
Owen Leonard e33f91d3bd Bug 22950: Markup error in OPAC recent comment template
This patch makes minor corrections to the template for the OPAC's
recent comments view. These corrections fix errors returned by the HTML
validator.

The patch moves some inline CSS into a class in the global OPAC CSS.
Some minor reindentation has also been done, so use diff with the '-w'
flag.

To reproduce the problem you should have the 'reviewson' system
preference turned on, and your system should have one or more
approved comments. View the "Recent comments" page in the OPAC. Run the
page through the W3C validation service: https://validator.w3.org.
Either by pasting in the URL for the search results (if web accessible)
or by viewing source, copying, and pasting into "Validate by Direct
Input."

This patch addresses one specific error:

 - "CSS: font-color: Property font-color doesn't exist."

To test, apply the patch and rebuild the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

Try again to reproduce the validation errors. Those errors should no
longer be present. There should be no visible change to the page.

Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit 457000102e)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit 43e16861da)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2019-06-11 13:35:58 +00:00
C4 Bug 22907: Add missing use statement 2019-05-30 21:36:56 +01:00
Koha Bug 22705: Change default value of cxn_pool to 'Static' 2019-05-30 20:41:28 +01:00
OpenILS
…
acqui Bug 22225: Correctly use invoiceincgst over listincgst 2019-05-30 08:15:24 +01:00
admin Bug 22339: Fix search field mappings of MARC fixed fields 2019-04-26 16:20:48 +01:00
api/v1 Bug 13895: (QA follow-up) Make the class plural 2019-04-01 15:02:00 +01:00
authorities Bug 19994: Used Modern::Perl in Authorities perl scripts 2019-02-01 15:06:13 +00:00
basket Bug 21993: Display a user-friendly message when the CSRF token is wrong 2019-01-31 17:07:03 +00:00
catalogue Bug 22762: Fix items.collection display on receiving 2019-04-26 16:04:43 +01:00
cataloguing Bug 16232: Fix edit as new in Rancor 2019-04-26 16:10:34 +01:00
circ Bug 21346: Streamline logic in holds and transfers 2019-04-25 14:21:28 +01:00
clubs Bug 18632: Remove 'CGI::param called in list context' warnings 2017-05-28 22:25:22 -04:00
course_reserves Bug 21003: Removed warning and changed wording on add_items-step2.tt 2019-04-15 11:54:24 +01:00
debian Bug 20692: Extreme toggle checking for plack 2019-04-26 16:27:46 +01:00
docs Bug 7143: (follow-up) Update about page for new devs (Academy) 2019-02-25 18:57:43 +00:00
errors Bug 19998: use Modern::Perl in error perl scripts 2018-02-05 09:45:48 -03:00
etc Bug 22705: Change default value of cxn_pool to 'Static' 2019-05-30 20:41:28 +01:00
ill Bug 20996: Remove prefix use of borrower category 2018-11-02 10:33:02 +00:00
installer Increment version for 18.11.06 release 2019-05-31 07:51:09 +01:00
koha-tmpl Bug 22950: Markup error in OPAC recent comment template 2019-06-11 13:35:58 +00:00
labels Bug 21719: Fix typos 2018-11-08 02:18:46 +00:00
members Bug 22724: Check permissions in the script before displaying template 2019-05-30 21:22:37 +01:00
misc Update release notes for 18.11.06 release 2019-05-31 07:56:36 +01:00
offline_circ Bug 13779: (QA follow-up) Correct checkauth call in offline_circ/download.pl 2018-09-14 17:27:29 +00:00
opac Bug 17698: (RM follow-up) Pass lang variable so letter can be translated 2019-05-30 21:11:47 +01:00
patron_lists Bug 19524: Use existing logged_in_user variable 2018-07-18 16:49:30 +00:00
patroncards Bug 21719: Fix typos 2018-11-08 02:18:46 +00:00
plugins Bug 20011: use Modern::Perl in plugins perl scripts 2018-02-05 09:46:44 -03:00
reports Bug 22090: Add missing information to cash register CSV file 2019-04-25 15:03:03 +01:00
reserve Bug 22895: (bug 22650 follow-up) Correct itemnumber call in placerequest.pl 2019-05-14 13:06:36 +01:00
reviews Bug 18789: Send Koha::Patron object to the templates 2018-02-16 13:03:58 -03:00
rotating_collections Bug 21500: Remove warnings in rotating collections 2018-10-09 15:02:45 +00:00
serials Bug 15149: Serial test prediction pattern does not consider end date 2019-03-01 11:04:21 +00:00
services Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
skel
…
suggestion Bug 21048: (QA follow-up) Fix authorized value statuses in filter 2018-08-08 20:58:23 +00:00
svc Bug 7862: Preventing warns when creating a notice 2019-05-30 08:08:25 +01:00
t Bug 22908: (RMaint follow-up) Correction for tests 2019-05-31 07:21:34 +01:00
tags Bug 22036: Indented code where '^I' was written rather than an indent. 2019-01-23 12:25:07 +00:00
test Bug 9819 - 'stopwords'-related code removed 2015-12-30 15:49:35 +00:00
tmp/modified_authorities
…
tools Bug 7862: Preventing warns when creating a notice 2019-05-30 08:08:25 +01:00
virtualshelves Revert "Bug 22478: (QA follow-up) Handle category in opac-shelves like a boolean" 2019-05-30 08:03:31 +01:00
xt Bug 21576: Keep compatibility with QA script 2018-10-26 17:09:52 +00:00
.editorconfig
…
.gitignore Bug 20427: Convert OPAC LESS to SCSS 2018-08-09 15:17:07 +00:00
.htaccess
…
.mailmap Update mailmap - Jonathan Druart 2017-06-21 12:42:19 -03:00
.scss-lint.yml Bug 21237: Clean up staff client SCSS 2018-08-24 16:23:25 +00:00
INSTALL Bug 17626: Remove existing install instructions and link to the wiki pages instead 2016-11-22 11:29:07 +00:00
Koha.pm Increment version for 18.11.06 release 2019-05-31 07:51:09 +01:00
LICENSE
…
MANIFEST.SKIP
…
Makefile.PL Bug 20174: Remove xml_sax.pl target from Makefile.pl 2019-02-25 15:26:15 +00:00
README
…
README.md Bug 15465: Fix typo in bugs.k-c.org 2017-05-26 11:45:31 -03:00
README.robots
…
about.pl Bug 20996: Remove prefix use of borrower category 2018-11-02 10:33:02 +00:00
changelanguage.pl Bug 21299: (QA follow-up) Rename module and subroutine 2018-11-07 21:52:17 +00:00
fix-perl-path.PL Bug 9978: (followup) Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:43 -03:00
gulpfile.js Bug 20427: Convert OPAC LESS to SCSS 2018-08-09 15:17:07 +00:00
help.pl Bug 19817: Use the language from the interface if valid 2018-09-06 17:32:28 +00:00
koha_perl_deps.pl Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
kohaversion.pl Bug 13758: Move the Koha version from kohaversion.pl 2015-05-07 11:39:04 -03:00
mainpage.pl Bug 21907: Fix article requests count for non-superlibrarians 2019-02-11 13:42:24 +00:00
package.json Bug 19474: Convert staff client CSS to SCSS 2018-08-09 15:12:20 +00:00
rewrite-config.PL Bug 14302: Remove GRS1 specific code 2018-08-31 11:24:20 +00:00
yarn.lock Bug 19474: Convert staff client CSS to SCSS 2018-08-09 15:12:20 +00:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo