Koha-clms/t/db_dependent
Tomas Cohen Arazi 9b009c09d2 Bug 11677: Use zebra not-onloan-count index for availability limit
This uses the work from bug 18098 to use the count of not-onloan items to
determine availability.

It keeps the allrecords,AlwaysMatches='' portion of the query so it still catches
records with the tested indexed missing.
These shouldn't exist except in the case of missing data, but kept for future use as well as
it has no negative impact and minimizes the change made.

Note that availability in this sense means not check out and not lost. Transfers, holds, and not for loan statuses
should probably have indexes built in the same way as bug 18098 (there are related FIXMEs in the code)

This updates the export_records file used for testing - adding three records with a not-onloan-count (999$x) of 1,
but marking the item on the third record lost to prevent its return

To test:
   1 - make sure SearchEngine pref is set to 'Zebra'
   2 - Do a search on the OPAC that returns some records
   3 - Find a record in those results with more than one 1 item, and checkout 1 leaving 1 (or more) available
   4 - Find another record with only 1 item, check that item out
   5 - Limit opac search to available items - both records disappear
   6 - Apply patch
   7 - Restart all the things
   8 - Repeat search
   9 - First record should show, but no second
  10 - Mark other items of first record as lost, return items on second record
  11 - Repeat search, first record should not be in results, second should
  12 - prove -v t/db_dependent/Search.t

Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit d4468c5f33)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit 1fe12aef4d)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2019-09-05 21:52:49 +00:00
..
Acquisition Bug 18736: Calculate tax depending on rounding 2019-03-25 14:29:31 +00:00
Auth
…
Authority
…
Biblio
…
Circulation Bug 18344: Add unit tests 2019-06-19 19:22:48 +00:00
CourseReserves Bug 22142: Do not revert data if 'unchanged' was set 2019-08-28 00:37:31 +00:00
Creators Bug 21281: (QA follow-up) Introduce _add_backtics 2018-09-26 15:22:57 +00:00
Exporter Bug 20486: Add --marc_conditions option to export_records.pl 2018-11-08 02:23:29 +00:00
Holds Bug 21798: replace gimme_a_biblio with build_sample_biblio 2019-02-25 14:45:54 +00:00
Illrequest Bug 20996: (follow-up) Fix test 2018-11-05 14:40:55 +00:00
Items Bug 21975: add Unit Test 2019-04-25 15:17:57 +01:00
Koha Bug 22524: Fix publication date and year search with Elasticsearch 2019-08-31 03:35:36 +00:00
LDAP
…
Labels Bug 21798: replace gimme_a_biblio with build_sample_biblio 2019-02-25 14:45:54 +00:00
Letters Bug 21817: Centralize the mock of userenv from tests 2019-01-07 14:49:50 +00:00
Members Bug 21817: Centralize the mock of userenv from tests 2019-01-07 14:49:50 +00:00
OAI Bug 21798: replace gimme_a_biblio with build_sample_biblio 2019-02-25 14:45:54 +00:00
Patron Bug 13515: Add unit tests 2019-02-25 12:20:13 +00:00
Record Bug 14334: Remove AutoCommit from tests 2018-12-17 12:08:58 +00:00
Reports Bug 20495: Remove get_saved_report 2018-07-02 12:06:54 +00:00
Reserves Bug 21765: Regression tests 2019-03-01 11:34:16 +00:00
SIP Bug 23211: Prevent SIP/Transaction.t to fail randomly 2019-07-25 20:49:45 +00:00
Search Bug 21087: Hash passwords in ->update_password 2018-07-30 14:58:06 -03:00
Serials Bug 14334: Remove AutoCommit from tests 2018-12-17 12:08:58 +00:00
Template/Plugin Bug 22688: (follow-up) Unit tests 2019-04-25 14:30:09 +01:00
Utils Bug 21817: Centralize the mock of userenv from tests 2019-01-07 14:49:50 +00:00
XSLT_Handler
…
api/v1 Bug 13895: Fix test 2019-04-01 15:02:00 +01:00
data Bug 11677: Use zebra not-onloan-count index for availability limit 2019-09-05 21:52:49 +00:00
selenium Bug 23280: Silence warning 2019-08-06 00:17:12 +00:00
www Bug 18316: (follow-up) Don't let 'fields' be undef and adjust tests 2018-11-08 02:18:45 +00:00
00-strict.t Bug 19817: Remove local help files + edit help feature 2018-09-06 17:32:27 +00:00
01-test_dbic.t
…
Accounts.t Bug 18677: Remove new issue_id param from charlostitem 2018-11-16 12:43:11 +00:00
Acquisition.t Bug 22618: (RMaint follow-up) Backport fix 2019-04-15 12:59:00 +01:00
AdditionalField.t Bug 14334: Remove AutoCommit from tests 2018-12-17 12:08:58 +00:00
Amazon.t
…
ArticleRequests.t Bug 21817: Centralize the mock of userenv from tests 2019-01-07 14:49:50 +00:00
AudioAlerts.t
…
Auth.t Bug 22692: Unit tests 2019-04-29 10:43:02 +01:00
Auth_with_cas.t Bug 14334: Remove AutoCommit from tests 2018-12-17 12:08:58 +00:00
Auth_with_ldap.t Bug 18947: LDAP - do not assume anonymous bind if no user or password 2018-08-20 14:40:13 +00:00
AuthorisedValues.t
…
AuthoritiesMarc.t
…
BackgroundJob.t Bug 14334: Remove AutoCommit from tests 2018-12-17 12:08:58 +00:00
Barcodes.t
…
Barcodes_ValueBuilder.t Bug 21937: Add test to show autoBarcode annual increment bug 2019-04-26 15:33:01 +01:00
Biblio.t Bug 21957: Add a flag to ModBiblio to avoid linking auths if called from linker 2019-04-26 14:44:37 +01:00
Bookseller.t Bug 21817: Fix 2 failing tests 2019-01-07 14:50:28 +00:00
Breeding.t Bug 12747: Add extra column in Z3950 search 2018-10-01 13:56:26 +00:00
Budgets.t Bug 18736: Unit tests for GetBudgetHierarchy 2019-03-25 14:29:30 +00:00
Cache.t Bug 22808: Move Cache.t to db_dependent 2019-05-08 16:33:50 +01:00
Calendar.t
…
Charset.t Bug 14334: Remove AutoCommit from tests 2018-12-17 12:08:58 +00:00
Circulation.t Bug 23103: Cannot checkin items lost by deleted patrons with fines attached 2019-08-14 02:06:40 +00:00
Clubs.t
…
ColumnsSettings.t Bug 14334: Remove AutoCommit from tests 2018-12-17 12:08:58 +00:00
Context.t
…
Contract.t Bug 14334: Remove AutoCommit from tests 2018-12-17 12:08:58 +00:00
CourseReserves.t Bug 21603: Remove incorrect GROUP BY from C4::CourseReserves 2018-10-26 16:33:14 +00:00
DecreaseLoanHighHolds.t Bug 22493: Clean up DecreaseLoanHighHolds.t 2019-03-19 09:53:11 +00:00
Filter_MARC_ViewPolicy.t
…
Fines.t Bug 14334: Remove AutoCommit from tests 2018-12-17 12:08:58 +00:00
FrameworkPlugin.t
…
Heading_MARC21.t
…
Hold.t Bug 21478: (QA follow-up) Make sure tests don't fail randomly 2019-02-01 12:02:05 +00:00
Holds.t Bug 17978: Unit tests for changes 2019-04-15 11:59:53 +01:00
HoldsQueue.t
…
Holidays.t
…
ILSDI_Services.t Bug 23156: [18.11] Add pagination to checkouts in ILS-DI GetPatronInfo service 2019-07-25 20:43:05 +00:00
Illcomments.t Bug 18591: Allow any number of comments on ILLs 2018-10-27 13:15:58 +00:00
Illrequestattributes.t
…
Illrequests.t Bug 20996: Fix unit tests 2018-11-02 10:33:03 +00:00
Images.t Bug 21987: (RM follow-up) Add text for simple tests 2019-03-19 09:55:13 +00:00
ImportBatch.t
…
ImportExportFramework.t Bug 21749: (QA follow-up) Add more tests for ImportFramework 2018-11-15 12:47:36 +00:00
Installer.t Bug 22472: Add tests 2019-04-15 18:51:02 +01:00
Items.t Bug 22899: (QA follow-up) Change accessor name 2019-05-24 14:36:41 +01:00
Items_DelItemCheck.t
…
KitchenSinkPlugin.kpz
…
Koha.t
…
Koha_Authority.t
…
Koha_Database.t
…
Koha_ExternalContent_OverDrive.t Bug 21567: Move Koha_ExternalContent_OverDrive.t to db_dependent 2018-11-16 13:04:57 +00:00
Koha_ExternalContent_RecordedBooks.t Bug 17602: RecordedBooks Integration to Koha 2018-10-01 13:56:38 +00:00
Koha_Misc_Files.t Bug 14334: Remove AutoCommit from tests 2018-12-17 12:08:58 +00:00
Languages.t Bug 14334: Remove AutoCommit from tests 2018-12-17 12:08:58 +00:00
Letters.t Bug 21829: (QA follow-up) - Update the number of unit tests 2019-02-12 13:17:29 +00:00
LibraryGroups.t Bug 14334: Remove AutoCommit from tests 2018-12-17 12:08:58 +00:00
Linker_Default.t Bug 21450: (QA follow-up) remove a couple of unused variables to make QA script happy 2019-05-30 21:24:50 +01:00
Linker_FirstMatch.t
…
Log.t Bug 22917: Fix typo in another test file 2019-05-30 20:48:17 +01:00
MarcModificationTemplates.t Bug 21817: Centralize the mock of userenv from tests 2019-01-07 14:49:50 +00:00
Members.t Bug 22052: Unit tests 2019-01-10 13:49:24 +00:00
MungeMarcPrice.t Bug 14334: Remove AutoCommit from tests 2018-12-17 12:08:58 +00:00
NewsChannels.t Bug 14334: Remove AutoCommit from tests 2018-12-17 12:08:58 +00:00
Overdues.t Bug 14334: Remove AutoCommit from tests 2018-12-17 12:08:58 +00:00
Passwordrecovery.t
…
PatronLists.t Bug 21817: Centralize the mock of userenv from tests 2019-01-07 14:49:50 +00:00
Patroncards.t Bug 22878: Add tests 2019-05-30 08:10:41 +01:00
Patrons.t
…
Plugins.t Bug 23230: (follow-up) Fix broken tests 2019-07-26 03:15:09 +00:00
QueryParser.t
…
Record.t Bug 14334: Remove AutoCommit from tests 2018-12-17 12:08:58 +00:00
RecordProcessor_EmbedSeeFromHeadings.t
…
RefundLostItemFeeRule.t
…
Reports.t
…
Reserves.t Bug 21798: replace gimme_a_biblio with build_sample_biblio 2019-02-25 14:45:54 +00:00
RotatingCollections.t Bug 14334: Remove AutoCommit from tests 2018-12-17 12:08:58 +00:00
Search.t Bug 11677: Use zebra not-onloan-count index for availability limit 2019-09-05 21:52:49 +00:00
Serials.t Bug 10215: (follow-up) Fix the failing test 2019-06-12 22:21:49 +00:00
Serials_2.t Bug 20287: Replace occurrences of AddMember with Koha::Patron->new->store->borrowernumber 2018-07-18 15:49:47 +00:00
Service.t
…
ShelfBrowser.t Bug 21133: Fix use statements order 2018-07-31 16:28:02 -03:00
Sitemapper.t Bug 21015: Remove unecessary 'use Koha::Schema' statements in t/ 2018-11-08 02:18:48 +00:00
Stats.t Bug 14334: Remove AutoCommit from tests 2018-12-17 12:08:58 +00:00
StockRotationItems.t Bug 11897: Stockrotation 2018-10-09 15:46:05 +00:00
StockRotationRotas.t Bug 11897: Stockrotation 2018-10-09 15:46:05 +00:00
StockRotationStages.t Bug 11897: Stockrotation 2018-10-09 15:46:05 +00:00
SuggestionEngine_ExplodedTerms.t
…
Suggestions.t Bug 22908: (RMaint follow-up) Correction for tests 2019-05-31 07:21:34 +01:00
Tags.t Bug 21846: Simplify ugly double for loops 2019-03-19 09:59:04 +00:00
Templates.t
…
TestBuilder.t Bug 22930: (QA follow-up) Add two test descriptions 2019-05-30 20:31:19 +01:00
Upload.t Bug 19633: Use alphanumeric error codes in upload 2018-08-10 10:10:46 +00:00
UsageStats.t Bug 21226: Remove xISBN services 2018-08-16 13:20:22 +00:00
Virtualshelves.t Bug 14334: Remove AutoCommit from tests 2018-12-17 12:08:58 +00:00
XISBN.t Bug 12537: Don't retrieve XISBN results for the same biblionumber 2019-08-06 04:35:29 +00:00
XSLT_Handler.t Bug 20272: Replace error numbers by codes in XSLT_Handler 2018-07-02 12:12:48 +00:00
check_kohastructure.t
…
check_sysprefs.t
…
db_structure.t
…
default_search_class.pl
…
rollingloans.t Bug 21817: Centralize the mock of userenv from tests 2019-01-07 14:49:50 +00:00
sysprefs.t Bug 14334: Remove AutoCommit from tests 2018-12-17 12:08:58 +00:00
zebra_config.pl Bug 14302: Remove GRS1 specific code 2018-08-31 11:24:20 +00:00