Koha-clms/t/db_dependent
Mark Tompsett e1b5fa657d Bug 14385: Squash of a lot of patches rebased
- Added missing GetHiddenItems parameter change case
     Without this prove t had a failure.

- Always use mocks, not set_preference

- Tweaks so t/db_dependent/00-strict.t passes
     There was a typo botcat vs borcat and borrowernumber was never
     defined. Grabbing from userenv, like other code does.

- Tweak t/db_dependent/Items.t to fully test changes
     This will test all the if structures fully in GetHiddenItemnumbers.
         prove t/db_dependent/Items.t

- Tweak borrower category code
     $borrower->{categorycode} on a Koha::Patron is not the
     same as $borrower->categorycode. Fixed error.

- Search was returning URLS for wrong interface
     There was one search context place wrong. Changed it to $is_opac
     as the logic for setting $is_opac was modified correctly.

- Corrected issues with category code.
     When a user isn't logged in, $borrower is undef and causes error
     when determining category code. Added conditional check.

- Properly trigger all changes in C4/Search.pm

- Fix QA Test tool failures
     C4/Search.pm had some tabs.

- Add some commenting to make sense of logic

- Refactor EmbedItemsInMarcBiblio parameters to hashref

- Trigger GetMarcBiblio's EmbedItemsInMarcBiblio call.
     prove t/db_dependent/Items.t

- Add missing test to trigger Koha/BiblioUtils/Iterator change

- Add borrower category overrides
     These files generally add borcat parameter to GetMarcBiblio.
     Others might include correction of filtering of items
     (opac-basket), or a comment as to why no changes were done
     (opac-search).

     In the case of opac-search, correcting the first FIXME will
     likely correct the OpacHiddenItems issues on tags. As such,
     that is beyond this bugs scope.

     Some code had loop optimizations and fixes made, like a
     'next unless $record' when the biblio shouldn't even be in
     the list.

- Modify opac-ISBDdetail and opac-MARCdetail
     Both files had similar logic. They were rearranged and
     optimized, so that both files would have practically identical
     initial blocks of code.

     Optimizations were possible, because GetMarcBiblio
     returns a filtered record, so that there is no double call
     (once in the opac-### file and once in GetMarcBiblio) to
     GetHiddenItemnumbers.

- Fix hiding in opac-tags
     opac/opac-tags.pl was not properly hiding.

     There is currently one known bug associated with tags left.
     If you have two biblios tagged by different people with the
     same tag, the opac-search will show the one you tagged that
     is supposed to be hidden, because tag searches work differently
     than regular searches. This is beyond the scope of this bug.
     See the FIXME's in opac/opac-search.pl

- Trigger the C4::ILSDI::Services changes
     prove t/db_dependent/ILSDI_Services.t

- Added missing 'my'

- Test C4/Labels/Label.pm changes

- Improve C4::Record::marcrecord2csv test cases

- Corrected opac-details searchResult call

- Fix breaking issues constraint in ITerator test

- Fix ILSDI_Services test when clubs with branch exist

- Rebased again!
- Rebased t/db_dependent/Items.t conflict.

The test plan is in comment #112 last I checked.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2018-11-02 10:33:12 +00:00
..
Acquisition Bug 18720: Use exception instead of die in GetBasketAsCsv 2018-10-31 13:47:17 +00:00
Auth
…
Authority Bug 14769: Put ControlledIndicators to work 2018-04-12 10:50:35 -03:00
Biblio Bug 20126: Add simple test for ModBiblioMarc 2018-02-02 12:08:42 -03:00
Circulation Bug 15486: Fix failing test in GetHardDueDate.t 2018-10-25 12:36:59 +00:00
CourseReserves Bug 10382: Course reserves: handle empty values 2018-10-15 12:44:50 +00:00
Creators Bug 21281: (QA follow-up) Introduce _add_backtics 2018-09-26 15:22:57 +00:00
Exporter Bug 18201: Tidy tests 2017-12-21 13:21:12 -03:00
Holds Bug 21597: Incorrect date value: '0' for column 'onloan' 2018-10-18 14:18:00 +00:00
Illrequest Bug 7317: Remove traces of UnmediatedILL 2017-11-09 11:42:16 -03:00
Items Bug 21133: Fix use statements order 2018-07-31 16:28:02 -03:00
Koha Bug 14385: Squash of a lot of patches rebased 2018-11-02 10:33:12 +00:00
LDAP
…
Labels Bug 14385: Squash of a lot of patches rebased 2018-11-02 10:33:12 +00:00
Letters Bug 21238: Prevent TemplateToolkit.t to fail on slow servers 2018-08-20 15:03:55 +00:00
Members Bug 21360: Prevent IssueSlip.t to fail when run at 23:59 2018-09-15 23:59:17 +00:00
OAI Bug 20665: Units tests for testing MySQL connection time zone 2018-05-03 12:46:55 -03:00
Patron Bug 21133: Fix use statements order 2018-07-31 16:28:02 -03:00
Record Bug 14385: Squash of a lot of patches rebased 2018-11-02 10:33:12 +00:00
Reports Bug 20495: Remove get_saved_report 2018-07-02 12:06:54 +00:00
Reserves Bug 15524: (QA follow-up) Change Can[Book|Item]BeReserved to return hashref, pass limit to template 2018-08-24 16:27:27 +00:00
SIP Bug 18625: (QA follow-up) Unit tests 2018-04-11 16:45:10 -03:00
Search Bug 21087: Hash passwords in ->update_password 2018-07-30 14:58:06 -03:00
Serials Bug 20144: [sql_modes] Add default value for subscription_numberpatterns.description in tests 2018-02-13 13:59:00 -03:00
Template/Plugin Bug 7534: Use search parameters for Koha::Template::Plugin::Branches->all 2018-09-06 17:27:05 +00:00
Utils Bug 20287: Use DBIC transaction instead of AutoCommit=0 2018-07-18 15:49:49 +00:00
XSLT_Handler
…
api/v1 Bug 20996: Fix unit tests 2018-11-02 10:33:03 +00:00
data Bug 21581: Unit tests and updated data 2018-10-31 13:17:47 +00:00
selenium Bug 21597: Incorrect decimal value: 't_value_bib639' for column 'price' 2018-10-18 14:18:01 +00:00
www Bug 18336: Full stack tests for supplemental UTF-8 chars 2018-02-16 17:53:42 -03:00
00-strict.t Bug 19817: Remove local help files + edit help feature 2018-09-06 17:32:27 +00:00
01-test_dbic.t Bug 18226: Perltidy + license 2017-06-05 17:52:48 -03:00
Accounts.t Bug 21681: Remove C4::Accounts::getcharges 2018-10-31 13:52:07 +00:00
Acquisition.t Bug 18639: Unit tests 2018-08-31 12:46:38 +00:00
AdditionalField.t Bug 20144: [sql_modes] Add default value for subscription_numberpatterns.description in tests 2018-02-13 13:58:53 -03:00
Amazon.t
…
ArticleRequests.t Bug 17530: (QA follow-up) Add pref ArticleRequestsLinkControl 2018-09-07 13:16:10 +00:00
AudioAlerts.t
…
Auth.t Bug 21087: Hash passwords in ->update_password 2018-07-30 14:58:06 -03:00
Auth_with_cas.t Bug 19373: Update tests 2017-10-16 09:38:41 -03:00
Auth_with_ldap.t Bug 18947: LDAP - do not assume anonymous bind if no user or password 2018-08-20 14:40:13 +00:00
AuthorisedValues.t Bug 18748: Noisy t/db_dependent/AuthorisedValues.t 2017-07-14 12:29:22 -03:00
AuthoritiesMarc.t Bug 18448: Fix a few db_dependent tests 2017-04-21 00:09:43 +00:00
BackgroundJob.t Bug 17426: Do not set AutoCommit in tests 2016-10-21 14:34:21 +00:00
Barcodes.t
…
Barcodes_ValueBuilder.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Biblio.t Bug 21556: Do not crash if a biblio is deleted twice 2018-11-01 19:05:12 +00:00
Bookseller.t Bug 20906: Prevent test failures due to precision changes (2) 2018-06-22 12:59:09 +00:00
Breeding.t Bug 12747: Add extra column in Z3950 search 2018-10-01 13:56:26 +00:00
Budgets.t Bug 21604: Add two trivial test cases 2018-11-02 10:33:01 +00:00
Calendar.t Bug 9031: (QA follow-up) Final changes to Calendar::days_between 2017-10-27 14:09:04 -03:00
Charset.t Bug 18269: Move field mappings related code to Koha::FieldMapping[s] 2017-03-31 10:20:00 +00:00
Circulation.t Bug 13098: Do not compare with precision 2018-10-31 13:13:38 +00:00
ClassSource.t
…
Clubs.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
ColumnsSettings.t
…
Context.t Bug 19788: Add a test 2017-12-22 13:15:37 -03:00
Contract.t Bug 13726: Make Koha::Acq::Bookseller using Koha::Object 2016-12-30 11:54:32 +00:00
CourseReserves.t Bug 21603: Remove incorrect GROUP BY from C4::CourseReserves 2018-10-26 16:33:14 +00:00
DecreaseLoanHighHolds.t Bug 21086: Fix wrong mock of DateTime->now 2018-07-19 16:24:57 +00:00
Filter_MARC_ViewPolicy.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Fines.t
…
FrameworkPlugin.t Bug 20204: Add TestBuilder to replace CPL branch 2018-02-15 11:15:53 -03:00
Heading_MARC21.t
…
Hold.t Bug 18856: (QA follow-up) Rename method to avoid confusion 2018-05-17 11:40:03 -03:00
Holds.t Bug 15486: Unit tests 2018-10-24 13:24:04 +00:00
HoldsQueue.t Bug 19059: Move C4::Reserves::CancelReserve to Koha::Hold->cancel 2017-09-12 12:42:58 -03:00
Holidays.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
ILSDI_Services.t Bug 14385: Squash of a lot of patches rebased 2018-11-02 10:33:12 +00:00
Illcomments.t Bug 18591: Allow any number of comments on ILLs 2018-10-27 13:15:58 +00:00
Illrequestattributes.t Bug 7317: (followup) Make tests independent of data on the DB 2017-11-09 11:42:15 -03:00
Illrequests.t Bug 20996: Fix unit tests 2018-11-02 10:33:03 +00:00
ImportBatch.t Bug 20764: (QA follow-up) Fix path to sample plugins 2018-05-14 12:13:20 -03:00
Installer.t Bug 17234: Need to separate KEY and FOREIGN KEY checks 2017-01-12 12:43:10 +00:00
Items.t Bug 14385: Squash of a lot of patches rebased 2018-11-02 10:33:12 +00:00
Items_DelItemCheck.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
KitchenSinkPlugin.kpz Bug 17368: Update KitchenSinkPlugin.kpz 2016-10-21 14:48:53 +00:00
Koha.t Bug 20144: [sql_modes] Correct quotes.timestamp values in tests 2018-02-13 13:58:54 -03:00
Koha_Authority.t
…
Koha_Database.t
…
Koha_Elasticsearch.t Bug 19581: Fix Koha_Elasticsearch.t 2018-04-09 17:44:20 -03:00
Koha_Elasticsearch_Indexer.t Bug 20248: Improve Elasticsearch mappings UI and rebuild_elastic_search.pl. 2018-08-22 14:47:43 +00:00
Koha_ExternalContent_RecordedBooks.t Bug 17602: RecordedBooks Integration to Koha 2018-10-01 13:56:38 +00:00
Koha_Misc_Files.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Koha_SearchEngine_Elasticsearch_Search.t Bug 21032: Fix using facet for searches made on specific index 2018-07-31 13:11:56 -03:00
Languages.t
…
Letters.t Bug 15971: Add biblioitems to available fields for serial claim notices and fix notices editor display 2018-10-01 13:56:34 +00:00
LibraryGroups.t Bug 20838: Add 2 small tests to check ref 2018-06-04 13:40:36 -04:00
Linker_FirstMatch.t
…
Log.t Bug 18991: [QA Follow-up] Use schema txn_begin and txn_rollback 2017-07-28 11:23:40 -03:00
MarcModificationTemplates.t Bug 13560: Unit tests 2018-07-19 17:22:12 +00:00
Members.t Bug 20287: Test exception DuplicateID for Koha::Patron->store 2018-07-18 15:49:57 +00:00
MungeMarcPrice.t
…
NewsChannels.t Bug 17960: Rename opac_news.new with opac_news.content 2017-02-06 17:42:12 +00:00
Overdues.t Bug 15758: Koha::Libraries - Remove GetBranches 2016-09-08 14:36:03 +00:00
Passwordrecovery.t Bug 20474: Mimick Letters.t 2018-03-27 12:21:44 -03:00
PatronLists.t Bug 19524: Share patron lists between staff 2018-07-18 16:49:29 +00:00
Patrons.t Bug 9302: (QA follow-up) Consistency follow-up 2018-04-20 13:34:41 -03:00
Plugins.t Bug 21352: (QA follow-up) - correction to testplan 2018-10-08 12:52:19 +00:00
QueryParser.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Record.t Bug 20097: (follow-up) Add a unit test 2018-03-19 13:54:50 -03:00
RecordProcessor_EmbedSeeFromHeadings.t
…
RefundLostItemFeeRule.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Reports.t
…
Reserves.t Bug 15524: (QA follow-up) Change Can[Book|Item]BeReserved to return hashref, pass limit to template 2018-08-24 16:27:27 +00:00
RotatingCollections.t Bug 21133: Fix use statements order 2018-07-31 16:28:02 -03:00
Search.t Bug 14385: Squash of a lot of patches rebased 2018-11-02 10:33:12 +00:00
Serials.t Bug 21154: Remove unused subs from C4::Serials 2018-08-09 10:42:38 +00:00
Serials_2.t Bug 20287: Replace occurrences of AddMember with Koha::Patron->new->store->borrowernumber 2018-07-18 15:49:47 +00:00
Service.t
…
ShelfBrowser.t Bug 21133: Fix use statements order 2018-07-31 16:28:02 -03:00
Sitemapper.t Bug 21086: Fix wrong mock of DateTime->now 2018-07-19 16:24:57 +00:00
Stats.t Bug 20510: Remove unused sub TotalPaid from C4::Stats 2018-04-05 14:17:36 -03:00
StockRotationItems.t Bug 11897: Stockrotation 2018-10-09 15:46:05 +00:00
StockRotationRotas.t Bug 11897: Stockrotation 2018-10-09 15:46:05 +00:00
StockRotationStages.t Bug 11897: Stockrotation 2018-10-09 15:46:05 +00:00
SuggestionEngine_ExplodedTerms.t Bug 17989: (QA follow-up) Replace bad dots in SuggestionEngine_ExplodedTerms.t 2017-11-01 13:10:18 -03:00
Suggestions.t Bug 20287: Replace occurrences of AddMember with Koha::Patron->new->store->borrowernumber 2018-07-18 15:49:47 +00:00
Tags.t
…
Templates.t Bug 20727: Move temporary_directory() to C4::Context 2018-06-22 16:10:09 +00:00
TestBuilder.t Bug 19985: Make TestBuilder.t pass even if default_circ_rules is not empty 2018-01-23 16:05:54 -03:00
Upload.t Bug 19633: Use alphanumeric error codes in upload 2018-08-10 10:10:46 +00:00
UsageStats.t Bug 21226: Remove xISBN services 2018-08-16 13:20:22 +00:00
Virtualshelves.t Bug 21597: Data too long for column 'invitekey' 2018-10-18 14:18:00 +00:00
XISBN.t Bug 14302: Remove GRS1 specific code 2018-08-31 11:24:20 +00:00
XSLT_Handler.t Bug 20272: Replace error numbers by codes in XSLT_Handler 2018-07-02 12:12:48 +00:00
check_kohastructure.t Bug 19783: Move check_kohastructure.t to db_dependent 2018-01-19 15:13:56 -03:00
check_sysprefs.t Bug 17917: [AMENDED] Fix path issue in t/db_dependent/check_sysprefs.t 2017-01-20 13:39:37 +00:00
db_structure.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
default_search_class.pl
…
rollingloans.t Bug 20900: Add CPL test branch in rollingloans.t 2018-07-13 12:05:46 +00:00
sysprefs.t
…
zebra_config.pl Bug 14302: Remove GRS1 specific code 2018-08-31 11:24:20 +00:00