Koha-clms/Koha/Template/Plugin
Andreas Jonsson 79085c4723
Bug 36025: Incorrect clause in patron search
This patch removes the search clause for
extended_attributes when there is no patron
attribute types which are searchable by default.

The clause was incorrectly added because the array
extended_attribute_types was rendered as [""] in
the template patron-search.inc most likely due to
a bug in DBIx::Class.

Test plan:

* Make sure that no borrower attribute type is set to "searched by default"
  in Koha administration -> Patron attribute types.
* Enable the network monitring in the developer tools in your web browser
  (Ctrl + Shift + E in firefox or Ctrl + Shift + I and select the "Network"
  tab).
* Go to the patrons view members-home.pl (click patrons in top menu bar).
* Search for a string that will match multiple borrowers (to not be automatically
  redirected)
* Examine the ajax-request and make sure that "extended_attributes.code" is NOT
  part of the query.
* Also, in koha-testing-docker with selenium enabled,
  run 'perl t/db_dependent/selenium/patrons_search.t'

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2024-12-30 15:12:47 +01:00
..
AdditionalContents.pm Bug 37628: (follow-up) Remove get_opac_news_by_id 2024-08-16 17:33:51 +02:00
Asset.pm
…
AudioAlerts.pm
…
AuthClient.pm
…
AuthorisedValues.pm
…
Biblio.pm
…
Branches.pm Bug 36941: Limit login branch list when IP restriction enabled 2024-06-28 13:49:26 +02:00
Categories.pm Bug 28924: (QA follow-up): Remove unnecessary template method 2024-07-18 18:25:56 +02:00
CirculationRules.pm
…
ClassSources.pm
…
Context.pm
…
Desks.pm
…
ExtendedAttributeTypes.pm Bug 36025: Incorrect clause in patron search 2024-12-30 15:12:47 +01:00
Frameworks.pm
…
HtmlId.pm
…
HtmlTags.pm
…
I18N.pm
…
ItemTypes.pm
…
JSConsents.pm
…
Koha.pm
…
KohaDates.pm Bug 38758: Add strftime as TT virtual method 2024-12-23 13:36:24 +01:00
KohaPlugins.pm
…
KohaSpan.pm
…
KohaTimes.pm Bug 38043: Add unit tests for KohaTimes TT filter 2024-10-11 11:13:54 +02:00
Languages.pm
…
NoticeTemplates.pm
…
Notices.pm
…
Price.pm
…
Registers.pm
…
Remove_MARC_punctuation.pm
…
SafeURL.pm Bug 22223: Add filter to make item URLs safe in template output 2024-11-07 16:29:18 +01:00
TablesSettings.pm Bug 38594: Remove unused TablesSettings.GetColumns 2024-12-03 17:34:05 +01:00
To.pm
…
raw.pm
…