This patch removes the search clause for extended_attributes when there is no patron attribute types which are searchable by default. The clause was incorrectly added because the array extended_attribute_types was rendered as [""] in the template patron-search.inc most likely due to a bug in DBIx::Class. Test plan: * Make sure that no borrower attribute type is set to "searched by default" in Koha administration -> Patron attribute types. * Enable the network monitring in the developer tools in your web browser (Ctrl + Shift + E in firefox or Ctrl + Shift + I and select the "Network" tab). * Go to the patrons view members-home.pl (click patrons in top menu bar). * Search for a string that will match multiple borrowers (to not be automatically redirected) * Examine the ajax-request and make sure that "extended_attributes.code" is NOT part of the query. * Also, in koha-testing-docker with selenium enabled, run 'perl t/db_dependent/selenium/patrons_search.t' Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> |
||
|---|---|---|
| .. | ||
| AdditionalContents.pm | ||
| Asset.pm | ||
| AudioAlerts.pm | ||
| AuthClient.pm | ||
| AuthorisedValues.pm | ||
| Biblio.pm | ||
| Branches.pm | ||
| Categories.pm | ||
| CirculationRules.pm | ||
| ClassSources.pm | ||
| Context.pm | ||
| Desks.pm | ||
| ExtendedAttributeTypes.pm | ||
| Frameworks.pm | ||
| HtmlId.pm | ||
| HtmlTags.pm | ||
| I18N.pm | ||
| ItemTypes.pm | ||
| JSConsents.pm | ||
| Koha.pm | ||
| KohaDates.pm | ||
| KohaPlugins.pm | ||
| KohaSpan.pm | ||
| KohaTimes.pm | ||
| Languages.pm | ||
| NoticeTemplates.pm | ||
| Notices.pm | ||
| Price.pm | ||
| Registers.pm | ||
| Remove_MARC_punctuation.pm | ||
| SafeURL.pm | ||
| TablesSettings.pm | ||
| To.pm | ||
| raw.pm | ||