Go to file
Jonathan Druart e0ec375ee3 Bug 26990: (bug 22284 follow-up) Prevent hold to be placed if cannot be transferred
There is a missing parameter to CanItemBeReserved, we need to know if
the hold can be placed at a given pickup library.

Test plan:
1 - Set preferences:
     UseBranchTransferLimits: enforce
     BranchTransferLimitsType: itype
     AllowHoldPolicyOverride: Don't allow
2 - Set Centerville 'Book' items to not be allowed to transfer to any other library
3 - Make sure Hold policy is set to 'any library'
4 - Find a record with a Centerville item and other items
5 - Attempt to place an item level hold on the Centerville item (with a
pickup library different than Centerville)
=> Without this patch you are taken to the holds list, but your hold is not placed
Nothing indicates why hold has failed
=> With this patch you cannot select the item from Centerville
"Cannot be transferred to pickup library"

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit fbd0bbf98f)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2020-11-16 22:45:36 +00:00
C4 Bug 26900: Fixes Koka::Libraries typo in C4/Reserves.pm 2020-11-16 20:34:15 +00:00
Koha Bug 26594: (QA follow-up) Make _UpdateBorrowerDebarmentFlags a public method 2020-11-16 22:35:13 +00:00
acqui Bug 26190: Allow to close a basket with only cancelled order lines 2020-11-16 21:18:02 +00:00
admin Bug 26908: (follow-up) Alter template check 2020-11-16 21:52:59 +00:00
api/v1 Bug 26271: Add null to the list of accepted account_line data types 2020-09-14 21:35:32 +00:00
authorities Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
basket Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
catalogue Bug 24663: (follow-up) Remove authnotrequired if set to 0 2020-08-31 20:04:45 +00:00
cataloguing Bug 26605: Correctly URI-encode query string in call number browse plugin 2020-11-16 18:43:41 +00:00
circ Bug 23485: Show barcode in holds to pull 2020-10-20 14:18:38 +00:00
clubs Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
course_reserves Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
debian Bug 24633: (follow-up) Tweak sample plugin targets 2020-11-16 22:22:02 +00:00
docs Bug 21395: (QA follow-up) Remove some introduced issues 2020-07-13 16:45:15 +00:00
errors Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
etc Bug 24633: (follow-up) Tweak sample plugin targets 2020-11-16 22:22:02 +00:00
ill Bug 23173: (follow-up) Small improvements in efficiency 2020-04-06 11:05:09 +01:00
installer Bug 26911: (bug 18936 follow-up) Remove invalid data before copying the circ rules 2020-11-16 21:49:24 +00:00
koha-tmpl Bug 26727: (follow-up) More markup corrections 2020-11-16 22:11:24 +00:00
labels Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
members Bug 26915: Fix FinePaymentAutoPopup behaviour 2020-11-16 21:45:51 +00:00
misc Bug 26832: Make Elasticsearch mappings export use UTF-8 2020-11-16 21:05:21 +00:00
offline_circ Bug 26675: (bug 23463 follow-up) Fix typo onloadn vs onloan 2020-11-10 22:49:05 +00:00
opac Bug 26464: Code correction in opac-main when news_id passed 2020-10-16 15:03:14 +00:00
patron_lists Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
patroncards Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
plugins Bug 24633: Add support for gitlab searching of plugins 2020-11-16 22:21:01 +00:00
pos Bug 26023: Properly secure the cashup and refund actions 2020-09-04 17:43:21 +00:00
reports Bug 17801: Use issuedate for limits in Most Circulated Items 2020-09-14 21:43:59 +00:00
reserve Bug 26990: (bug 22284 follow-up) Prevent hold to be placed if cannot be transferred 2020-11-16 22:45:36 +00:00
reviews Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
rotating_collections Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
serials Bug 26987: (bug 23463 follow-up) Fix serial receipt if makePreviousSerialAvailable 2020-11-16 22:41:43 +00:00
services
…
skel
…
suggestion Bug 24819: (follow-up) Rename suggestor to suggester 2020-04-20 13:36:42 +01:00
svc Bug 17515: Order Z3950 server by rank and preserve ordering 2020-11-16 18:31:26 +00:00
t Bug 26594: add Unit Test 2020-11-16 22:34:38 +00:00
tags Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
tmp/modified_authorities
…
tools Bug 25167: (QA follow-up) Don't add a new variable 2020-11-16 20:40:54 +00:00
virtualshelves Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
xt Bug 26265: add a plan for tests 2020-09-02 14:32:44 +00:00
.editorconfig Bug 24774: Set JSON indentation of 2 spaces in .editorconfig 2020-03-19 09:24:52 +00:00
.eslintrc.json
…
.gitignore
…
.htaccess
…
.mailmap
…
.perlcriticrc Bug 21395: Make perlcritic happy 2020-07-13 16:44:43 +00:00
.scss-lint.yml
…
INSTALL
…
Koha.pm Bug 26853: DBRev 20.05.05.003 2020-11-16 19:10:46 +00:00
LICENSE
…
MANIFEST.SKIP
…
Makefile.PL Bug 26265: Add missing xt dir 2020-09-02 14:32:13 +00:00
README
…
README.md
…
README.robots
…
about.pl Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
changelanguage.pl
…
cpanfile Bug 16357: Plack error logs are not time stamped 2020-10-20 14:26:24 +00:00
fix-perl-path.PL Bug 21395: Make perlcritic happy 2020-07-13 16:44:43 +00:00
gulpfile.js Bug 26228: Update gulpfile to work with Node.js v12 2020-09-03 14:49:31 +00:00
help.pl
…
koha_perl_deps.pl Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
kohaversion.pl
…
mainpage.pl Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
package.json Bug 26228: Update gulpfile to work with Node.js v12 2020-09-03 14:49:31 +00:00
rewrite-config.PL Bug 25792: Rename 'ttf-dejavu' package to 'fonts-dejavu' for Debian 11 2020-07-28 14:46:44 +00:00
yarn.lock Bug 26228: Update gulpfile to work with Node.js v12 2020-09-03 14:49:31 +00:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo