Koha-clms/C4/SIP
Joonas Kylmälä e07c676e43 Bug 25690: Remove double usage of 'Reserved' return value
The patch "Bug 19116: Hold not set to waiting after transfer" added a
new meaning to 'Reserved' return value of C4::Reserves::CheckReserves
function. Let's remove double usage and have separate Transferred
return value so we can differentiate between attached and non-attached
holds. This will come useful in future refactorings.

This patch does no changes to the logic except in the
/cgi-bin/koha/circ/branchtransfers.pl and circulation.pl we now give
similarly to waiting state notice about hold being transferred.

To test:
   1) Apply this patch
   2) Create a new item level hold so that pickup library is different
   than where the item is currently. Then return the item so that hold
   is being attached and transferred.
   3) Go to branchtransfers.pl and try to create a new transfer: it
   should prompt you with message "Item is attached to a hold and
   being transferred for XXX" and provide you with option to cancel
   the hold or to ignore the transfer.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit fbef547832)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2021-03-08 16:35:52 +01:00
..
ILS Bug 25690: Remove double usage of 'Reserved' return value 2021-03-08 16:35:52 +01:00
Sip Bug 26591: SIP option prevcheckout_block_checkout to block checkout of previously checked-out documents 2021-03-04 11:20:18 +01:00
t Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
ILS.pm Bug 26591: SIP option prevcheckout_block_checkout to block checkout of previously checked-out documents 2021-03-04 11:20:18 +01:00
ILS.pod
…
Logger.pm Bug 26673: Remove shebangs from Perl modules 2020-10-26 00:14:42 +01:00
Makefile
…
README Bug 15253: Rename syslog() to siplog() 2020-05-12 11:46:46 +01:00
SIPServer.pm Bug 26673: Remove shebangs from Perl modules 2020-10-26 00:14:42 +01:00
Sip.pm Bug 15253: Convert all tabs into 4 spaces in affected files 2020-05-12 11:47:01 +01:00
Trapper.pm Bug 15253: Add POD to C4/SIP/Logger.pm and C4/SIP/Trapper.pm 2020-05-12 11:47:04 +01:00
acstest.py
…
example_institution_dump.sh
…
interactive_item_dump.pl Bug 17196: Move marcxml out of the biblioitems table 2017-01-13 13:49:26 +00:00
interactive_patron_check_password.pl
…
interactive_patron_dump.pl
…
interactive_renew_all_dump.pl
…
test.txt
…
xmlparse.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00

README

README for Open NSIP 3M-SIP Server

DEPENDENCIES

SIPServer is written entirely in Perl, but it require these CPAN
perl modules to run:

     Net::Server - The SIP server is a Net::Server::Prefork server
     XML::LibXML
     XML::Parser
     XML::Simple - for parsing the config file
     UNIVERSAL::require - for loading the correct ILS interface module
     Clone - for running the test cases

LOGGING

SIPServer uses Koha::Logger for status and debugging messages.