Koha-clms/misc
Jonathan Druart 3e5eb8aacf Bug 24123: Fix import of UTF-8 encoded MARC21 MARCXML using bulkmarcimport (elastic only)
If elastic is used as search engine, the bulkmarcimport.pl will not
handle correctly UTF-8 encoded MARCXML

Koha::SearchEngine::Search->new uses a require statement to load the correct Search module.
This is done l.257 of bulkmarcimport.pl:
  257 my $searcher = Koha::SearchEngine::Search->new

Koha::SearchEngine::Elasticsearch::Search will `use MARC::File::XML`, and so resets the arguments set before:
  216     $MARC::File::XML::_load_args{BinaryEncoding} = 'utf-8';

  220     $MARC::File::XML::_load_args{RecordFormat} = $recordformat;

An easy (but dirty) fix could be to move the declaration of my $searcher before in the script.
The tricky (but correct) fix would be to remove the long standing "ugly hack follows" comment.

This patch is the easy, and dirty, fix

Test plan:
Use the command line tool to import MARXCML records that contains unicode characters into Koha

Something like `misc/migration_tools/bulkmarcimport.pl -biblios -file record.marcxml -m=MARCXML`

Without this patch you will notice that unicode characters will not be displayed correctly

Signed-off-by: Michal Denar <black23@gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
(cherry picked from commit b11946bc37)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2020-02-05 21:32:32 +00:00
..
admin Bug 23193: Make set_password.pl use Koha::Script 2019-07-25 13:45:24 +02:00
bin Revert Bug 11081 - Port Koha::Contrib::Tamil indexer into Koha code base 2016-03-01 16:56:35 +00:00
cronjobs Bug 24235: DUEDGST not sent if PREDUDGST checkbox is off 2020-01-07 22:42:07 +00:00
devel Bug 22600: Set 'commandline' interface appropriately 2019-04-10 19:43:11 +00:00
interface_customization Bug 20647: (alternate) When ILL is enabled the hover effect on the ILL requests button is wrong 2018-08-10 10:38:12 +00:00
load_testing Bug 17829: Move GetMember to Koha::Patron 2017-07-10 13:14:19 -03:00
maintenance Bug 23846: Handle exception gracefully at the OPAC 2019-11-15 11:31:02 +01:00
migration_tools Bug 24123: Fix import of UTF-8 encoded MARC21 MARCXML using bulkmarcimport (elastic only) 2020-02-05 21:32:32 +00:00
release_notes Update release notes for 19.05.07 release 2020-01-22 21:44:04 +00:00
search_tools Bug 22892: Remove warning from rebuild_es if --processes not passed 2019-05-15 12:10:53 +00:00
translator Translation updates for Koha 19.05.07 2020-01-22 18:30:57 -03:00
batchCompareMARCvsFrameworks.pl Bug 22600: Set 'commandline' interface appropriately 2019-04-10 19:43:11 +00:00
batchDeleteUnusedSubfields.pl Bug 22600: Set 'commandline' interface appropriately 2019-04-10 19:43:11 +00:00
batchImportMARCWithBiblionumbers.pl Bug 22600: Set 'commandline' interface appropriately 2019-04-10 19:43:11 +00:00
batchRebuildBiblioTables.pl Bug 22600: Set 'commandline' interface appropriately 2019-04-10 19:43:11 +00:00
batchRebuildItemsTables.pl Bug 22600: Set 'commandline' interface appropriately 2019-04-10 19:43:11 +00:00
batchRepairMissingBiblionumbers.pl Bug 22600: Set 'commandline' interface appropriately 2019-04-10 19:43:11 +00:00
batchdeletebiblios.pl Bug 22600: Set 'commandline' interface appropriately 2019-04-10 19:43:11 +00:00
check_sysprefs.pl Bug 22600: Set 'commandline' interface appropriately 2019-04-10 19:43:11 +00:00
commit_file.pl Bug 22600: Set 'commandline' interface appropriately 2019-04-10 19:43:11 +00:00
export_borrowers.pl Bug 22600: Set 'commandline' interface appropriately 2019-04-10 19:43:11 +00:00
export_records.pl Bug 20485: Don't account for items timestamps when items not included 2019-05-10 17:22:27 +00:00
exportauth.pl Bug 22600: Set 'commandline' interface appropriately 2019-04-10 19:43:11 +00:00
import_patrons.pl Bug 22875: Document verbose option in import_patrons 2019-05-15 12:10:53 +00:00
koha-install-log Bug 14302: Remove GRS1 specific code 2018-08-31 11:24:20 +00:00
kohalib.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
link_bibs_to_authorities.pl Bug 21957: Add a flag to ModBiblio to avoid linking auths if called from linker 2019-04-18 10:02:03 +00:00
mod_zebraqueue.pl Bug 22600: Set 'commandline' interface appropriately 2019-04-10 19:43:11 +00:00
perlmodule_ls.pl Bug 2505 - add strict and warnings to perlmodule_ls 2010-04-21 20:30:52 +12:00
perlmodule_rm.pl Bug 2505 - remove unnecessary -w and replace with use warnings; 2010-04-07 13:27:07 -04:00
recreateIssueStatistics.pl Bug 22600: Set 'commandline' interface appropriately 2019-04-10 19:43:11 +00:00
sax_parser_print.pl Bug 17626 (QA followup) 2016-11-22 11:29:07 +00:00
sax_parser_test.pl Bug 6752: Be stricter with utf-8 encoding of output 2012-01-27 12:11:06 +01:00
sip_cli_emulator.pl Bug 16757 - Add support for Fee Paid to SIP cli emulator for testing 2017-03-31 13:56:37 +00:00
stage_file.pl Bug 22600: Set 'commandline' interface appropriately 2019-04-10 19:43:11 +00:00