gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
52,910 Commits 39 Branches 720 Tags 6 GiB
Perl 44.2%
JavaScript 41.1%
HTML 6%
XSLT 3.1%
Vue 1.9%
Other 3.2%
Go to file
Emmi Takkinen dac285957d
Bug 36368: Declare template param "op" after variable $op is set 
If an error occurs while adding new patron, after fixing the error and
hitting save, patron entry page reloads to "Modify patron" section
and error "Patron not found. Return to search" is displayed. But no
patron is saved.

This happens because we declare template param op too early in the
code and it receives value "cud-insert" instead of "add_form" as it should.

To test:
1. Add new patron and cause an error (wrong age etc.).
2. Attempt to save patron, error message is displayed.
3. Fix your errors and attempt to save again.
=> Error message "Patron not found. Return to search" is displayed and new
patron is not saved to database.
4. Apply this patch.
5. Repeat steps from 1 to 3.
=> Saving patron should now work.
=> To be save, test if modifying patron also works as it should.

Sponsored-by: Koha-Suomi Oy
Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
 		2024-04-02 17:59:08 +02:00
C4 Bug 34943: (QA follow-up) Use `before_biblio_action` and an `action` param 2024-03-25 09:53:20 +01:00
Koha Bug 35107: (QA follow-up) Use extended_attributes 2024-03-25 17:34:09 +01:00
acqui Bug 27595: Place holds when ordering from a suggestion 2024-03-19 10:25:03 +01:00
admin Bug 35564: Add homebranch to the holds queue report 2024-03-22 15:47:33 +01:00
api Bug 34431: Allow for x-koha-embed in ill/backends endpoint 2024-03-22 15:07:33 +01:00
authorities Bug 30554: Use XSLT (if enabled) in authority search cataloguing plugin 2024-03-22 15:47:35 +01:00
basket Bug 34478: Add 'op' to sendbasketform 2024-03-01 10:58:53 +01:00
bin
…
bookings Bug 35574: Bookings tab from biblio details should only require manage_bookings permission 2023-12-18 15:21:04 +01:00
catalogue Bug 36336: (bug 34478 follow-up) Fix export from catalogue detail 2024-03-22 10:35:20 +01:00
cataloguing Bug 33036: REST API: Merge biblio records implements merging of records 2024-03-18 11:03:39 +01:00
circ Bug 23208: Add ability to set a default hold ratio value 2024-03-25 09:53:22 +01:00
clubs Bug 34478: Manual fix - add op clubs/templates-add-modify 2024-03-01 10:57:55 +01:00
course_reserves Bug 34478: Manual fix - Course reserves 2024-03-01 10:56:56 +01:00
debian Bug 27291: Reformat Zebra output logs 2024-03-22 10:35:25 +01:00
docs Bug 35504: Split list of ERM Topic experts 2024-01-11 15:44:51 +01:00
erm Bug 32922: Remove space in shebang 2023-02-20 09:44:06 -03:00
errors Bug 36148: Improve error handling and restore programming errors 2024-03-01 11:01:06 +01:00
etc Bug 35621: Map ÿ to y for searching (Non-ICU) 2024-03-22 15:47:34 +01:00
ill Bug 35331: Add table actions hook to ILL table 2024-03-18 11:03:33 +01:00
installer Bug 34793: (QA follow-up): forgotten 'Cookie consents'=>'Cookies policy' 2024-03-26 11:21:17 +01:00
koha-tmpl Bug 34886: Adjust other opac detail scripts 2024-04-02 17:59:06 +02:00
labels Bug 34478: Update label ops 'edit' to 'edit_form' 2024-03-01 10:56:33 +01:00
lib/CGI/Session/Serialize
…
members Bug 36368: Declare template param "op" after variable $op is set 2024-04-02 17:59:08 +02:00
misc Bug 31286: Embed see-from headings into bibliographic records export 2024-03-25 09:53:24 +01:00
offline_circ Bug 34478: Changes for offline_circ 2024-03-01 10:58:34 +01:00
opac Bug 34886: Adjust other opac detail scripts 2024-04-02 17:59:06 +02:00
patron_lists Bug 34478: Changes for patron_lists/add-modify 2024-03-01 10:57:41 +01:00
patroncards Bug 34478: (follow-up) patroncards: FIXMEs for op and missing script 2024-03-01 11:00:00 +01:00
plugins Bug 35536: Refine verbose handling in some Koha::Plugins calls 2024-03-22 12:26:40 +01:00
pos Bug 34478: Manual fix - add op - pos/pay 2024-03-01 10:57:34 +01:00
preservation Bug 34030: Add a "print slips" action links to print in batch 2023-10-23 11:33:55 -03:00
recalls Bug 34478: op =~ ^cud- in pl/pm 2024-03-01 10:56:11 +01:00
reports Bug 31988: Remove reports/itemtypes.plugin 2024-03-18 18:03:39 +01:00
reserve Bug 35782: Fix scoping problem with "biblio" 2024-03-15 09:38:40 +01:00
reviews Bug 34478: op =~ ^cud- in pl/pm 2024-03-01 10:56:11 +01:00
rotating_collections Bug 34478: Manual fix - add op - rotating_collections/addItems 2024-03-01 10:57:33 +01:00
serials Bug 36195: serials/routing-preview.pl - Fix save and preview 2024-03-12 17:47:26 +01:00
services
…
skel
…
suggestion Bug 35916: Purchase suggestions bibliographic filter should be a "contains" search 2024-03-08 18:58:27 +01:00
svc Bug 36418: Catch more cases where header response should be application/json 2024-04-02 17:59:04 +02:00
t Bug 34886: Comment failing tests 2024-04-02 17:59:08 +02:00
tags Bug 34478: Add 'op' to tags/review 2024-03-01 10:58:25 +01:00
tools Bug 36326: Fix batch item mod/del access from biblio detail page 2024-03-22 12:26:36 +01:00
virtualshelves Bug 34478: Correct op name for list edit confirmation 2024-03-01 11:00:09 +01:00
xt Bug 36190: (QA follow-up) Tidy 2024-03-15 09:38:53 +01:00
.editorconfig Bug 27375: Set YAML file settings in .editorconfig 2021-11-03 15:40:52 +01:00
.eslintrc.json
…
.gitignore Bug 35174: Add misc/translator/po to .gitignore 2023-11-16 08:56:36 +01:00
.htaccess
…
.mailmap 23.11.00: Update mailmap 2023-11-30 14:58:47 -03:00
.perlcriticrc
…
.perltidyrc Bug 30002: Adjust perltidy 2023-06-08 08:32:42 -03:00
.proverc.dist
…
.stylelintrc.json Bug 31528: (follow-up) A few additional rules 2022-10-03 08:23:15 -03:00
INSTALL
…
Koha.pm Bug 23208: DBRev 23.12.00.013 2024-03-25 09:53:23 +01:00
LICENSE
…
MANIFEST.SKIP
…
Makefile.PL Bug 35759: (bug 30708 follow-up) Generated dist file not installed for preservation module 2024-01-16 12:06:17 +01:00
README
…
README.md
…
README.robots
…
about.pl Bug 36134: Read complete Elasticsearch configuration in about.pl 2024-03-07 17:35:36 +01:00
app.psgi
…
build-resources.PL Bug 32609: Use the current yarn.lock to generate node_modules 2023-02-10 11:07:57 -03:00
changelanguage.pl
…
cpanfile Bug 34064: Add SQL::Translator dependency to cpanfile 2023-10-10 10:54:04 -03:00
cypress.config.ts Bug 36012: Extend cypress's requestTimeout value 2024-03-22 15:07:36 +01:00
fix-perl-path.PL
…
gulpfile.js Bug 35428: Remove temporary files for gulp po tasks 2023-12-12 15:04:54 +01:00
help.pl
…
koha_perl_deps.pl
…
kohaversion.pl
…
mainpage.pl Bug 34478: Remove generate_csrf from pl 2024-03-01 10:55:56 +01:00
package.json Bug 36177: Cypress tests - yarn add cypress-mysql 2024-03-12 17:47:33 +01:00
rewrite-config.PL
…
tsconfig.json Bug 32030: Move cypress to t - fix build_js/watch_js 2022-11-08 09:44:52 -03:00
webpack.config.js Bug 30708: Vue app 2023-10-18 15:41:40 -03:00
yarn.lock Bug 36177: Cypress tests - yarn add cypress-mysql 2024-03-12 17:47:33 +01:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo