Go to file
David Cook d9749756ca Bug 11575 - OPACBaseURL sometimes set by ENV variable and not system preference
This patch changes how the OPACBaseURL parameter gets set in the subroutine
get_template_and_user in Auth.pm.

Currently, it's being set by the $ENV{'SERVER_NAME'} variable. In many
cases, this will probably match the URL that the user uses to access a
page. However, this causes problems with reverse proxies.

There are ways to compensate for proxy servers (such as inspecting
other variables set by the web server), but such a solution seems
a bit convoluted...especially since we already use the system preference
OPACBaseURL in many other parts of Koha.

We probably shouldn't be passing OPACBaseURL from Auth.pm at all, and
instead use the Koha TT plugin and using_https param to determine
protocol. However, that's outside the scope of this bug/patch.

This patch is just meant to fix an existing bug.

I did leave the $ENV{'SERVER_NAME'} as a full back if OPACBaseURL isn't
set, but that's it.

_TEST PLAN_

Before applying:

1) Clear your OPACBaseURL preference
2) Perform a search in the OPAC
3) Click on or hover over the orange RSS icon
4) Note that the URL used for the RSS links is either:
  a) The same URL you used to access Koha (no reverse proxy)
  b) The ServerName from your Koha apache conf which isn't the
  same URL you used to access Koha (reverse proxy)
5) Add an OPACBaseURL that isn't the same as the actual OPAC URL
6) Note that the OPACBaseURL system preference has no effect here

After applying the patch:

7) Refresh the page
8) Note that the URL you see now is actually the OPACBaseURL system
preference that you set
9) Clear your OPACBaseURL system preference
10) Refresh your search page
11) Note that the URL has reverted back to the URL that you saw before
(either the original Koha site URL or the Koha ServerName defined
in Apache and not the URL of the proxy)

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
2014-07-15 10:33:47 -03:00
C4 Bug 11575 - OPACBaseURL sometimes set by ENV variable and not system preference 2014-07-15 10:33:47 -03:00
Koha Bug 12558: (follow-up) remove old versions of schema classes for two tables 2014-07-11 16:26:48 -03:00
OpenILS Bug 9239 QA follow-up: remove stray debug code 2013-03-16 21:32:34 -04:00
acqui Bug 11715: require authentication for various staff scripts 2014-06-25 12:27:08 -03:00
admin Bug 12265: [QA Follow-up] - Improve usage of find 2014-07-14 09:10:25 -03:00
authorities Bug 10862: Add search history to the intranet interface 2014-05-05 03:06:33 +00:00
basket Bug 12065: use encode_qp consistently when sending basket/shelf 2014-05-09 15:14:40 +00:00
catalogue Bug 12237: Remove the "horrible hack" in C4::Templates 2014-07-03 10:34:11 -03:00
cataloguing Bug 11638: Remove HTML from addbiblio.pl 2014-07-03 15:01:10 -03:00
circ Bug 12495 - Include streetnumber in hold alert address 2014-07-07 10:56:06 -03:00
course_reserves Bug 11866: (follow-up) repair security issue introduced by main patch 2014-03-10 14:57:17 +00:00
debian Bug 8773 - Start per-instance koha-index-daemon in .deb setup 2014-07-14 09:15:22 -03:00
docs Bug 7143: Updating new developers 2014-06-30 10:01:52 -03:00
errors Housekeeping in errors scripts 2010-05-12 07:29:03 -04:00
etc Bug 9612: (follow-up) restore elementSetName in Context.pm 2014-05-19 16:46:57 +00:00
install_misc Bug 11757: remove dependency on POE 2014-02-15 01:38:15 +00:00
installer Bug 11030 - Add 359, 947 and 969 fields in french unimarc_complete framework - followup 2014-07-07 13:10:27 -03:00
koha-tmpl Bug 12377 [QA Followup] - Remove readonly from input 2014-07-15 10:33:16 -03:00
labels Bug 8375: Use TrueType fonts in PDF::Reuse 2014-05-05 21:53:18 +00:00
members Bug 12332: Fix for tab "Purchase suggestions" not lighting up 2014-07-08 10:43:46 -03:00
misc Bug 12396 - MTT FIX: Due notices (DUEDGST) are multiplicated and all of them are sent to everybody who is about to receive ODUEDGST. 2014-06-15 11:14:45 -03:00
offline_circ Bug 10240: (follow-up) don't display patrons as lost or gone-no-address incorrectly 2013-10-11 01:57:05 +00:00
opac Bug 12062: Follow up to fix more untraslatable cases 2014-07-07 10:32:08 -03:00
patron_lists Bug 10565: (follow-up) add new user permission for patron list management 2013-10-14 22:43:03 +00:00
patroncards Bug 10636 - patronimage should have borrowernumber as PK, not cardnumber 2013-10-14 21:08:02 +00:00
plugins Bug 7804 - Add Koha Plugin System - QA Followup 2 2013-03-20 14:50:19 -04:00
reports Bug 12151: Remove uses of smartmatch operator in report scripts 2014-07-07 10:16:45 -03:00
reserve Bug 11801: In transit hold items incorrectly labels as "Waiting to be pulled" on request.pl 2014-06-18 15:40:47 -03:00
reviews Bug 1623 - Provide view of approved comments 2011-12-27 18:26:50 +01:00
rotating_collections Bug 9605: rotating collections permissions are wrong 2013-03-30 22:11:05 -04:00
selenium
…
serials Bug 11226: subscription frequencies and numbering patterns should be editable with serials permissions 2014-07-14 11:17:23 -03:00
services Bug 11715: require authentication for various staff scripts 2014-06-25 12:27:08 -03:00
skel Bug 11078: Add locking to rebuild_zebra 2014-02-28 22:21:41 +00:00
sms Bug 10611: Use mysql_auto_reconnect instead of ping 2014-03-10 23:15:35 +00:00
suggestion Bug 10519: (followup) Fix context for evalyating $borrowernumber 2014-07-14 16:02:36 -03:00
svc Bug 11703: (qa followup) consistency in svc 2014-07-03 12:38:13 -03:00
t Bug 10519: (followup) unit tests leave problematic cruft 2014-07-14 16:30:51 -03:00
tags Bug 10730: Use DataTables on the tag review page 2013-09-25 16:47:59 +00:00
test Bug 5449: JSON malformed in Koha - Blocker with jQuery 1.4.x 2011-03-12 08:53:41 +13:00
tmp/modified_authorities
…
tools Bug 12151: Remove use of smartmatch operator in tools/batchMod.pl 2014-07-07 10:16:54 -03:00
virtualshelves Bug 12065: use encode_qp consistently when sending basket/shelf 2014-05-09 15:14:40 +00:00
xt Bug 12041 - POD fixing followup 2014-06-19 13:05:15 -03:00
.htaccess Fix file permissions: if it is not a script, it should not be executable. 2010-04-16 00:40:34 -04:00
.mailmap Bug 12479: (QA followup) minor fixes, and tcohen added 2014-06-30 10:04:10 -03:00
INSTALL Bug 7759, update of install files to use background indexing (and some whitespace tidy) 2012-04-20 16:11:52 +02:00
INSTALL.debian Bug 8092 follow-up: Add optional dependency on CHI 2012-06-09 13:08:18 +02:00
INSTALL.fedora7 Bug 11757: remove dependency on POE 2014-02-15 01:38:15 +00:00
INSTALL.opensuse Bug 11757: remove dependency on POE 2014-02-15 01:38:15 +00:00
INSTALL.ubuntu Bug 7764: (follow-up) editorial tweaks 2013-10-04 16:27:55 +00:00
LICENSE Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
MANIFEST.SKIP Bug 9546 : Updating make manifest tardist 2013-02-06 23:54:46 -05:00
Makefile.PL Bug 10729: Add phrases configuration for ICU 2014-05-05 04:10:57 +00:00
README Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
README.robots Bug 6411 add another example to README.robots 2011-07-05 14:48:05 +12:00
about.pl Bug 11596: report warnings on the about patch if indexing options in koha-conf.xml are missing 2014-04-20 17:07:04 +00:00
changelanguage.pl Bug 6755 Problems with switching languages 2011-09-23 09:47:09 +12:00
edithelp.pl Bug 11661: sanitize file names supplied to edithelp.pl 2014-02-05 01:36:10 +00:00
fix-perl-path.PL
…
help.pl Bug 11238: contruct links to the appropriate manual version dynamically 2013-11-23 19:30:16 +00:00
install-CPAN.pl Bug 5370: Fix all the references to koha.org 2010-11-08 09:41:49 +13:00
koha_perl_deps.pl bug 10548: fix count of missing required dependencies by koha_perl_deps.pl 2013-07-11 14:03:32 +00:00
kohaversion.pl Bug 11703: DBRev 3.17.00.009 2014-07-03 12:38:13 -03:00
mainpage.pl Bug 7567 - Use, display, filter News by library 2014-04-07 18:14:19 +00:00
rewrite-config.PL Bug 10729: Add phrases configuration for ICU 2014-05-05 04:10:57 +00:00

README

Koha is a free software integrated library system.

Koha is distributed under the GNU GPL version 3 or later.
Please read the file LICENSE for more details.

To install or upgrade Koha, please see the INSTALL file appropriate
to your platform.

Report bugs at http://bugs.koha-community.org/

Visit the Koha Project website at http://www.koha-community.org/