Koha-clms/misc/migration_tools
Thomas Klausner d836f19689
Bug 37020: (follow-up) Fix txn handling, loop label and record_number counter
So, I reviewed the code, which has a bunch of issues:

* there's a call to `next RECORD`, but no `RECORD` loop label.
* $record_number is incremented twice
* and the calls to txn_begin is moved from the outside the loop into each record, starting one transaction per record. Not sure how mysql handles this, but postgres would not like it.

This patch fixes those issues:

After I fixed the first two issues, I ran the patched script on a file containing 75 authorities (from GND), and not one was added to the DB, presuambly because nested transactions don't work in mysql?

So I also moved the BEGIN transaction outside of the main loop and started a new one after each commit, and added a final commit after to loop.

Signed-off-by: Jan Kissig <bibliothek@th-wildau.de>
Signed-off-by: Thomas Klausner <domm@plix.at>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit 01d36c5e8b)
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
2025-05-26 20:17:05 +02:00
..
22_to_30 Bug 29697: Replace GetMarcBiblio occurrences with $biblio->metadata->record 2022-07-22 15:24:11 -03:00
ifla Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
buildCOUNTRY.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
buildEDITORS.pl Bug 29697: Replace GetMarcBiblio occurrences with $biblio->metadata->record 2022-07-22 15:24:11 -03:00
buildLANG.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
build_oai_sets.pl Bug 35442: Script migration_tools/build_oai_sets.pl add ORDER BY 2024-09-30 15:24:21 +01:00
bulkmarcimport.pl Bug 37020: (follow-up) Fix txn handling, loop label and record_number counter 2025-05-26 20:17:05 +02:00
checkNonIndexedBiblios.pl Bug 28617: Remove kohalib.pl and rely on PERL5LIB 2021-12-07 12:16:28 -10:00
create_analytical_rel.pl Bug 29697: Replace GetMarcBiblio occurrences with $biblio->metadata->record 2022-07-22 15:24:11 -03:00
import_lexile.pl Bug 33339: Prevent Formula Injection (CSV Injection) in CSV files 2024-11-14 10:46:31 +01:00
koha-svc.pl Bug 37553: Tidy to make QA tools happy 2024-08-02 18:59:59 +02:00
rebuild_zebra.pl Bug 31224: Update instances of metadata->record 2024-11-07 16:29:23 +01:00
rebuild_zebra_sliced.sh
…
remove_unused_authorities.pl Bug 29238: Cataloging cron jobs are not logged 2025-04-22 23:02:26 +02:00
switch_marc21_series_info.pl Bug 29697: Replace GetMarcBiblio occurrences with $biblio->metadata->record 2022-07-22 15:24:11 -03:00
upgradeitems.pl Bug 29697: Replace GetMarcBiblio occurrences with $biblio->metadata->record 2022-07-22 15:24:11 -03:00