Go to file
Tomas Cohen Arazi d7bec9181e Bug 27593: Regression tests
This patch introduces tests for the behaviour change (400 => 404) and
also adds tests for untested (error) behaviours. Notably, the 'Biblio
not found' problematic return value couldn't be triggered, because the
OpenAPI plugin returns a 500 because the response was malformed
(expected { error => 'message' } and it was returning a string).

For the above reason, running the regression tests will show a 500...
instead of the expected 400.

I covered the rest of the codepaths that trigger errors to have full
coverage.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/clubs_holds.t
=> FAIL: Tests fail loudly

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 024a32ca80)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit e950abb535)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
2021-03-05 17:15:09 +00:00
C4 Bug 27729: Fix use of grep and split in CheckReserves 2021-03-05 16:37:43 +00:00
Koha Bug 27714: Prevent Koha::NewsItem->author to explode 2021-03-05 14:22:06 +00:00
acqui Bug 26997: Remove 0000-00-00 from aqorders.datecancellationprinted 2021-03-04 18:00:34 +00:00
admin Bug 26051: Add sort=1 on cn-sort in mappings.yaml 2021-03-05 13:44:51 +00:00
api/v1 Bug 27330: (QA follow-up) Return 409 instead 2021-03-04 17:26:56 +00:00
authorities Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
basket Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
catalogue Bug 23475: Use localStorage to preserve simple search values 2020-12-15 20:00:00 +00:00
cataloguing Bug 26605: Correctly URI-encode query string in call number browse plugin 2020-11-16 18:43:41 +00:00
circ Bug 27676: Correct finesMode ne off condition 2021-02-18 14:41:58 +00:00
clubs Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
course_reserves Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
debian Bug 17429: document the --plack/--noplack options of koha-list 2021-01-29 21:27:24 +00:00
docs Bug 7143: Update about page for new devs 2021-02-03 21:54:32 +00:00
errors Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
etc Revert "Bug 27299: Remove tokenization for phrase register/index with ICU" 2021-02-03 18:56:42 +00:00
ill Bug 23173: (follow-up) Small improvements in efficiency 2020-04-06 11:05:09 +01:00
installer Bug 23675: Add leader and default value for ACQ 2021-03-05 13:54:44 +00:00
koha-tmpl Bug 27713: Duplicate search field IDs in MARC framework administration template 2021-03-05 17:01:03 +00:00
labels Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
members Bug 27454: Pass the arrayref 2021-02-18 13:21:07 +00:00
misc Update release notes for 20.05.08 release 2021-02-23 20:31:51 +00:00
offline_circ Bug 26675: (bug 23463 follow-up) Fix typo onloadn vs onloan 2020-11-10 22:49:05 +00:00
opac Bug 27626: Fix self registration if categorycode is hidden and PatronSelfRegistrationVerifyByEmail 2021-03-04 21:24:42 +00:00
patron_lists Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
patroncards Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
plugins Bug 24633: Add support for gitlab searching of plugins 2020-11-16 22:21:01 +00:00
pos Bug 26023: Properly secure the cashup and refund actions 2020-09-04 17:43:21 +00:00
reports Bug 17801: Use issuedate for limits in Most Circulated Items 2020-09-14 21:43:59 +00:00
reserve Bug 26698: Use is_at_destination to determine if hold is at destination 2021-01-13 21:50:48 +00:00
reviews Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
rotating_collections Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
serials Bug 27332: Use the branchcode from the subscription when renewing 2021-03-05 16:53:16 +00:00
services
…
skel
…
suggestion Bug 26738: [20.05.x] (bug 24819 follow-up) Fix manager selection 2020-11-17 17:46:48 +00:00
svc Bug 27306: Add subtitle to return-claims-table 2021-01-29 14:52:19 +00:00
t Bug 27593: Regression tests 2021-03-05 17:15:09 +00:00
tags Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
tmp/modified_authorities
…
tools Bug 26059: Create guarantor/guarantee links on patron import 2021-02-22 22:32:30 +00:00
virtualshelves Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
xt Bug 26265: add a plan for tests 2020-09-02 14:32:44 +00:00
.editorconfig Bug 24774: Set JSON indentation of 2 spaces in .editorconfig 2020-03-19 09:24:52 +00:00
.eslintrc.json
…
.gitignore
…
.htaccess
…
.mailmap
…
.perlcriticrc Bug 21395: Make perlcritic happy 2020-07-13 16:44:43 +00:00
.scss-lint.yml
…
INSTALL
…
Koha.pm Increment version for 21.05.09 2021-02-23 20:19:43 +00:00
LICENSE
…
MANIFEST.SKIP
…
Makefile.PL Bug 26265: Add missing xt dir 2020-09-02 14:32:13 +00:00
README
…
README.md Bug 27092: Remove note about "synced repo" from README.md 2020-12-14 15:32:15 +00:00
README.robots
…
about.pl Bug 25826: Add a warning to the about page 2021-01-13 21:59:36 +00:00
changelanguage.pl
…
cpanfile Bug 26848: Fix Readonly dependency in cpanfile 2021-01-20 01:54:26 +00:00
fix-perl-path.PL Bug 21395: Make perlcritic happy 2020-07-13 16:44:43 +00:00
gulpfile.js Bug 26228: Update gulpfile to work with Node.js v12 2020-09-03 14:49:31 +00:00
help.pl
…
koha_perl_deps.pl Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
kohaversion.pl
…
mainpage.pl Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
package.json Bug 26228: Update gulpfile to work with Node.js v12 2020-09-03 14:49:31 +00:00
rewrite-config.PL Bug 25792: Rename 'ttf-dejavu' package to 'fonts-dejavu' for Debian 11 2020-07-28 14:46:44 +00:00
yarn.lock Bug 26228: Update gulpfile to work with Node.js v12 2020-09-03 14:49:31 +00:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo