gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
49,238 Commits 39 Branches 720 Tags 6 GiB
Perl 44.2%
JavaScript 41.1%
HTML 6%
XSLT 3.1%
Vue 1.9%
Other 3.2%
Go to file
Kyle M Hall d4d3f68fc9 Bug 33838: Don't reset the renewal count 
I cannot find any justification for this line existing.
MarkIssueReturned does not do this.

Resetting item's renewal count was introduced in bug 5877 with no explanation.

Test Plan:
1) Check out item 3999900000001 to a patron
2) Upload the KOC file attached to this bug report
3) Navigate the Pending Offline Circ actions, see your return is listed
4) Click the checkbox to select your return
5) Click Process once. Nothing appears to happen
6) In a new tab, pull up the bib for item 3999900000001, see that it has been checked in
7) Back on your Offline Circ tab, click Process a second time
8) Koha tells you the item is not checked out
9) Apply this patch, restart all the things!
10) Repeat steps 1-4, everything should now work!

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Edit: this line was introduced by bug 30275, by mistake. The
renewals_count attribute belongs to the `issues` table, and I agree it
shouldn't be set to 0 at all as it will (with no reason) make us loose
the value!
Tests pass with and without this change, so this isn't even tested.
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 9c565eff13)
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
 		2023-06-08 17:22:33 +00:00
C4 Bug 33838: Don't reset the renewal count 2023-06-08 17:22:33 +00:00
Koha Bug 33854: Fix typo in ImportBatchProfiles controller 2023-06-08 17:22:31 +00:00
acqui Bug 33653: Use filter_by_active instead 2023-05-15 12:06:44 +00:00
admin Bug 30649: Vendor EDI account passwords should be encrypted in the database 2023-06-02 11:49:09 +00:00
api Bug 33708: Provide non-public endpoint for OAuth/OIDC for staff interface 2023-06-08 16:51:21 +00:00
authorities Bug 32484: (QA follow-up) Few typos 2023-05-11 11:38:21 +01:00
basket Bug 33102: Display fields from biblioitems in OPAC/staff interface cart 2023-05-12 16:34:19 +01:00
bin
…
catalogue Bug 33788: Limit the number of old issues rows returned 2023-06-08 17:22:32 +00:00
cataloguing Bug 32959: Don't store results of autobarcode in item editor templates 2023-06-08 16:51:19 +00:00
circ Bug 33345: On-site checkout checkbox does not work since issue date using flatpickr 2023-04-18 12:04:58 +00:00
clubs Bug 30718: Use flatpickr's altInput 2022-08-19 08:26:31 -03:00
course_reserves Bug 31893: Use checkauth and do not fetch about.tt template 2023-01-31 14:09:05 +00:00
debian Bug 33371: Add [Install] section to koha-common.service 2023-06-08 16:59:56 +00:00
docs 22.11.00: Update history.txt 2022-11-25 15:20:02 -03:00
erm Bug 32922: Remove space in shebang 2023-02-24 07:51:37 +00:00
errors Bug 29420: HTTP status code incorrect when calling error pages directly under Plack/PSGI 2022-04-20 09:03:39 -10:00
etc Bug 33580: Bring back ability to mark item as seen via SIP2 item information request 2023-05-16 07:35:11 +01:00
ill Bug 28909: Allow illview to use backend template 2022-08-09 13:21:39 -03:00
installer Bug 33138: Don't copy tag 147 to authority MARC frameworks 2023-06-08 16:51:20 +00:00
koha-tmpl Bug 33821: Allow direct input of dates on the OPAC 2023-06-08 17:22:32 +00:00
labels Bug 31633: (follow-up) Group template params 2022-10-03 14:09:59 -03:00
lib/CGI/Session/Serialize Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
members Bug 33010: Do not filter checkins with logged in patrons branch in printslip.pl 2023-06-08 16:51:19 +00:00
misc Bug 33717: Typo in search_for_data_inconsistencies.pl 2023-06-02 11:23:40 +00:00
offline_circ Bug 30016: Remove GetOpenIssue subroutine 2022-08-31 08:50:37 -03:00
opac Bug 21330: Allow XSLT for authority detail view in OPAC 2023-06-07 09:05:01 +00:00
patron_lists Bug 16446: Add ability to add patrons to list by borrowernumber 2021-10-21 12:24:04 +02:00
patroncards Bug 24001: Fix patron card template edition 2022-04-28 10:49:20 -10:00
plugins Bug 30367: (follow-up) Same adjustment for gitlab 2023-05-12 15:58:09 +01:00
pos Bug 30619: Add email receipt to POS 2022-09-07 15:59:34 -07:00
recalls Bug 33220: Fix recalls to pull to not show in transit or allocated items 2023-06-07 12:18:10 +00:00
reports Bug 27513: Add notes to variables for report parameters template 2023-04-16 18:41:07 +01:00
reserve Bug 30687: Allow pickup location to be forced when override is allowed 2023-05-15 13:01:46 +00:00
reviews Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
rotating_collections Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
serials Bug 29608: Made so doesn't require full permission 2022-09-07 13:49:53 -07:00
services Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
skel
…
suggestion Bug 33421: Fix filtering suggestions by status 2023-06-08 16:43:04 +00:00
svc Bug 33408: Fetch sysprefs from svc/config/systempreferences 2023-05-15 13:15:07 +00:00
t Bug 33815: Regression tests 2023-06-08 17:15:34 +00:00
tags Bug 30718: Use flatpickr's altInput 2022-08-19 08:26:31 -03:00
tools Bug 33595: (bug 26628 follow-up) Fix authorization for tools-home.pl 2023-06-07 10:16:07 +00:00
virtualshelves Bug 16522: (follow-up) MARC display templates and get_marc_host fixes 2023-01-31 17:15:27 +00:00
xt Bug 33743: Make xt/find-missing-filters.t and xt/single_quotes.t check directories in git index only 2023-06-07 12:18:10 +00:00
.editorconfig Bug 27375: Set YAML file settings in .editorconfig 2021-11-03 15:40:52 +01:00
.eslintrc.json
…
.gitignore Bug 33710: Ignore how-to related files 2023-05-15 13:03:55 +00:00
.htaccess
…
.mailmap Bug 32582: Fix error in .mailmap 2023-01-25 14:39:04 +00:00
.perlcriticrc Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
.proverc.dist Bug 19821: Install sample data, ES mappings and Version syspref 2021-10-25 11:27:40 +02:00
.stylelintrc.json Bug 31528: (follow-up) A few additional rules 2022-10-03 08:23:15 -03:00
INSTALL Bug 26617: Update INSTALL file to include koha-testing-docker and Gitlab links 2020-10-15 12:56:30 +02:00
Koha.pm Bug 33297: DBRev 22.11.06.003 2023-06-07 12:18:10 +00:00
LICENSE
…
MANIFEST.SKIP
…
Makefile.PL Bug 32994: Remove breaking css/maps/*.map files from Makefile.PL 2023-03-14 14:08:27 +00:00
README
…
README.md Bug 27092: Remove note about "synced repo" from README.md 2020-11-25 16:31:58 +01:00
README.robots
…
about.pl Bug 28267: Simplify things 2023-05-12 15:02:26 +01:00
app.psgi Bug 20582: Fix PSGI file when behind a reverse proxy 2020-10-06 12:00:04 +02:00
build-resources.PL Bug 32609: Use the current yarn.lock to generate node_modules 2023-03-10 12:27:47 +00:00
changelanguage.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
cpanfile Bug 32558: (QA follow-up) Move ForkManager to required 2023-03-08 14:39:16 +00:00
cypress.json Bug 33408: Extend defaultCommandTimeout for cypress 2023-05-15 13:15:43 +00:00
fix-perl-path.PL Bug 28606: Remove $DEBUG and $ENV{DEBUG} 2021-06-24 11:53:44 +02:00
gulpfile.js Bug 32609: Improve yarn build commands 2023-03-10 12:27:27 +00:00
help.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
koha_perl_deps.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
kohaversion.pl
…
mainpage.pl Bug 33133: Add fast cataloging to 'Cataloging' page 2023-04-11 10:51:27 +00:00
package.json Bug 33066: Introduce a KohaTable Vue component 2023-05-11 17:01:22 +01:00
rewrite-config.PL Bug 28519: Put CGI::Session::Serialize::yamlxs in lib directory 2021-06-17 10:07:36 +02:00
tsconfig.json Bug 32030: Move cypress to t - fix build_js/watch_js 2022-11-08 09:44:52 -03:00
webpack.config.js Bug 32806: Move main-erm.ts to modules/erm.ts 2023-02-28 18:54:57 +00:00
yarn.lock Bug 33066: Introduce a KohaTable Vue component 2023-05-11 17:01:22 +01:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo