Koha-clms/Koha
Tomas Cohen Arazi afd00523a3
Bug 40254: Fix error in overrides check allowing too much
This patch fixes a subtle (yet naive) error making the controller not
care about blocking conditions if they were more than one and the first
one was overridden.

To test:
1. Apply the regression tests
2. Run:
   $ ktd --shell
  k$ prove t/db_dependent/api/v1/holds.t
=> FAIL: Tests fail! Some tests expect a 409 (denied for a conflict) but
return a 201!
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Sign off :-D

Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-06-30 08:30:45 -06:00
..
Account Bug 39177: Add additional fields to credit types 2025-05-15 09:20:49 +02:00
Acquisition Bug 39832: Add $basket->vendor method 2025-05-09 09:12:14 +02:00
App
…
ArticleRequest
…
Auth
…
Authority Bug 39367: Automatic changes 2025-04-23 09:35:14 +02:00
BackgroundJob Bug 23010: Report on count of items not modified via batchMod 2025-06-24 16:10:20 -06:00
Biblio Bug 39367: Automatic changes 2025-04-23 09:35:14 +02:00
Cache
…
Cash Bug 39325: Automatic fix 2025-04-28 18:51:22 +02:00
Charges
…
Checkouts
…
Club Bug 39325: Automatic fix 2025-04-28 18:51:22 +02:00
CodeList/Unimarc
…
Config Bug 39367: Automatic changes 2025-04-23 09:35:14 +02:00
Course
…
Database
…
DateTime/Format
…
ERM Bug 39823: Identify error messages based on code 2025-06-02 15:26:19 -06:00
Edifact Bug 39904: (QA follow-up) Fix a few other cases 2025-05-19 09:49:42 +02:00
Exceptions Bug 39191: Add `format` parameter to Koha::Exceptions::ArticleRequest::WrongFormat 2025-04-23 09:35:20 +02:00
Exporter
…
ExternalContent Bug 39367: Automatic changes 2025-04-23 09:35:14 +02:00
Filter/MARC Bug 39325: Manual fixes 2025-04-28 18:51:23 +02:00
Hold
…
ILL Bug 38928: (QA follow-up) 2025-06-24 15:56:43 -06:00
Import
…
Indexer
…
Installer
…
Item Bug 32034: Add item transfers to action logs 2025-04-25 18:35:02 +02:00
Library
…
List
…
MetadataRecord Bug 39367: Automatic changes 2025-04-23 09:35:14 +02:00
Middleware Bug 39367: Automatic changes 2025-04-23 09:35:14 +02:00
Misc Bug 39325: (follow-up) A few minor corrections 2025-04-28 18:51:29 +02:00
Notice Bug 39367: Automatic changes 2025-04-23 09:35:14 +02:00
Number
…
OAI Bug 39857: Fix expanded_avs option for OAI 2025-05-09 09:12:04 +02:00
Object
…
Objects
…
Old Bug 38395: Display bibliographic data for deleted biblios in holds history 2025-05-02 08:49:22 +02:00
Patron Bug 39325: Automatic fix 2025-04-28 18:51:22 +02:00
Patrons Bug 39325: Manual fixes 2025-04-28 18:51:23 +02:00
Plugins Bug 39325: Manual fixes 2025-04-28 18:51:23 +02:00
Policy
…
Preservation
…
REST Bug 40254: Fix error in overrides check allowing too much 2025-06-30 08:30:45 -06:00
RecordProcessor Bug 39325: Automatic fix 2025-04-28 18:51:22 +02:00
Result
…
SMS
…
SMTP
…
Schema Bug 30301: DBIC file 2025-05-19 18:54:29 +02:00
SearchEngine Bug 39503: Collapse thesaurus if value in 008_/11 = 'z' and 040 $f 2025-05-13 18:47:00 +02:00
Serial Bug 39367: Automatic changes 2025-04-23 09:35:14 +02:00
Sitemapper
…
Subscription Bug 39367: Automatic changes 2025-04-23 09:35:14 +02:00
SuggestionEngine Bug 39325: Automatic fix 2025-04-28 18:51:22 +02:00
Tags
…
Template/Plugin Bug 39325: Automatic fix 2025-04-28 18:51:22 +02:00
Ticket
…
UI Bug 40003: Remove warning from log when creating a new bib record 2025-06-06 09:41:17 -06:00
Util
…
XSLT
…
Z3950Responder
…
pdfformat Bug 39325: Automatic fix 2025-04-28 18:51:22 +02:00
Account.pm Bug 33473: Rename UseEmailReceipts to AutomaticEmailReceipts 2025-04-25 08:46:43 +02:00
ActionLog.pm
…
ActionLogs.pm
…
AdditionalContent.pm
…
AdditionalContents.pm Bug 40020: Remove warnings from Koha/AdditionalContents.t 2025-06-06 09:41:14 -06:00
AdditionalContentsLocalization.pm
…
AdditionalContentsLocalizations.pm
…
AdditionalField.pm
…
AdditionalFieldValue.pm
…
AdditionalFieldValues.pm Bug 39367: Automatic changes 2025-04-23 09:35:14 +02:00
AdditionalFields.pm Bug 39367: Automatic changes 2025-04-23 09:35:14 +02:00
AdvancedEditorMacro.pm
…
AdvancedEditorMacros.pm
…
ApiKey.pm
…
ApiKeys.pm
…
ArticleRequest.pm Bug 39191: Add `format` parameter to Koha::Exceptions::ArticleRequest::WrongFormat 2025-04-23 09:35:20 +02:00
ArticleRequests.pm Bug 39367: Automatic changes 2025-04-23 09:35:14 +02:00
AudioAlert.pm
…
AudioAlerts.pm
…
AuthUtils.pm
…
AuthorisedValue.pm
…
AuthorisedValueCategories.pm Bug 39367: Automatic changes 2025-04-23 09:35:14 +02:00
AuthorisedValueCategory.pm
…
AuthorisedValues.pm Bug 39367: Automatic changes 2025-04-23 09:35:14 +02:00
Authorities.pm
…
Authority.pm
…
BackgroundJob.pm Bug 34070: Deal with broker connection issues 2025-05-19 18:54:25 +02:00
BackgroundJobs.pm
…
Biblio.pm Bug 37364: Add requested RDA handling to generate_marc_host_field 2025-06-02 15:26:21 -06:00
BiblioFramework.pm
…
BiblioFrameworks.pm Bug 39367: Automatic changes 2025-04-23 09:35:14 +02:00
BiblioUtils.pm
…
Biblioitem.pm
…
Biblioitems.pm Bug 39367: Automatic changes 2025-04-23 09:35:14 +02:00
Biblios.pm
…
Booking.pm
…
Bookings.pm
…
Cache.pm Bug 39367: Automatic changes 2025-04-23 09:35:14 +02:00
Caches.pm
…
Calendar.pm
…
Checkout.pm
…
Checkouts.pm
…
CirculationRule.pm
…
CirculationRules.pm
…
Cities.pm Bug 39367: Automatic changes 2025-04-23 09:35:14 +02:00
City.pm
…
ClassSortRule.pm
…
ClassSortRules.pm
…
ClassSource.pm
…
ClassSources.pm
…
ClassSplitRule.pm Bug 39325: Automatic fix 2025-04-28 18:51:22 +02:00
ClassSplitRules.pm
…
Club.pm Bug 39367: Automatic changes 2025-04-23 09:35:14 +02:00
Clubs.pm Bug 39367: Automatic changes 2025-04-23 09:35:14 +02:00
Config.pm
…
CookieManager.pm Bug 39206: Add an allowlist to Koha::CookieManager 2025-06-26 11:09:54 -06:00
Course.pm
…
Courses.pm
…
CoverImage.pm
…
CoverImages.pm Bug 39367: Automatic changes 2025-04-23 09:35:14 +02:00
CsvProfile.pm
…
CsvProfiles.pm Bug 39367: Automatic changes 2025-04-23 09:35:14 +02:00
CurbsidePickup.pm
…
CurbsidePickupIssue.pm
…
CurbsidePickupIssues.pm
…
CurbsidePickupOpeningSlot.pm
…
CurbsidePickupOpeningSlots.pm
…
CurbsidePickupPolicies.pm
…
CurbsidePickupPolicy.pm
…
CurbsidePickups.pm
…
Database.pm
…
DateUtils.pm Bug 39367: Automatic changes 2025-04-23 09:35:14 +02:00
Desk.pm
…
Desks.pm
…
EDI.pm Bug 39325: Automatic fix 2025-04-28 18:51:22 +02:00
Edifact.pm Bug 39325: (QA follow-up) Adjust some issues 2025-04-28 18:51:30 +02:00
Email.pm
…
Encryption.pm
…
Exception.pm Bug 39367: Manual changes 2025-04-23 09:35:15 +02:00
Exceptions.pm
…
ExternalContent.pm Bug 39367: Automatic changes 2025-04-23 09:35:14 +02:00
FrameworkPlugin.pm Bug 39325: Automatic fix 2025-04-28 18:51:22 +02:00
Hold.pm Bug 39912: Update RealTimeHoldsQueue when hold pickup location is updated 2025-06-26 11:09:57 -06:00
Holds.pm
…
I18N.pm
…
ImportBatch.pm
…
ImportBatchProfile.pm
…
ImportBatchProfiles.pm
…
ImportBatches.pm
…
Installer.pm
…
Item.pm Bug 23010: Update pref name to PreventWithdrawingItemsStatus 2025-06-24 16:10:20 -06:00
ItemType.pm
…
ItemTypes.pm
…
Items.pm Bug 23010: Report on count of items not modified via batchMod 2025-06-24 16:10:20 -06:00
KeyboardShortcut.pm
…
KeyboardShortcuts.pm
…
Language.pm
…
Libraries.pm Bug 39367: Automatic changes 2025-04-23 09:35:14 +02:00
Library.pm
…
Linktracker.pm Bug 39367: Automatic changes 2025-04-23 09:35:14 +02:00
Localization.pm Bug 39365: Fix 3 files 2025-04-23 09:35:18 +02:00
Localizations.pm
…
Logger.pm
…
Manual.pm Bug 38010: Fix links to the manual 2025-05-02 17:19:24 +02:00
MarcOrder.pm Bug 39620: Fallback to GetMarcPrice if nessesary 2025-05-15 08:34:03 +02:00
MarcOrderAccount.pm
…
MarcOrderAccounts.pm
…
MarcOverlayRule.pm Bug 39365: Fix 3 files 2025-04-23 09:35:18 +02:00
MarcOverlayRules.pm
…
MarcSubfieldStructure.pm
…
MarcSubfieldStructures.pm
…
MetaSearcher.pm
…
MetadataIterator.pm
…
MetadataRecord.pm
…
MoreUtils.pm
…
OAIServer.pm
…
OAIServers.pm
…
OAuth.pm
…
OAuthAccessToken.pm
…
OAuthAccessTokens.pm
…
Object.pm
…
Objects.pm
…
OverdueRule.pm
…
OverdueRules.pm
…
Patron.pm Bug 40101: Add `Koha::Patron->can_place_holds()` 2025-06-26 11:10:02 -06:00
Patrons.pm
…
Plugins.pm
…
ProblemReport.pm
…
ProblemReports.pm
…
PseudonymizedTransaction.pm Bug 39322: (follow-up) Further improvements 2025-05-08 07:59:05 +02:00
PseudonymizedTransactions.pm
…
Quote.pm
…
Quotes.pm Bug 40242: Remove double operator in Quotes.pm 2025-06-26 11:09:56 -06:00
Rating.pm
…
Ratings.pm Bug 39367: Automatic changes 2025-04-23 09:35:14 +02:00
Recall.pm
…
Recalls.pm
…
RecordProcessor.pm Bug 39325: Automatic fix 2025-04-28 18:51:22 +02:00
RecordSource.pm
…
RecordSources.pm
…
Report.pm
…
Reports.pm
…
Review.pm
…
Reviews.pm Bug 39367: Automatic changes 2025-04-23 09:35:14 +02:00
Schema.pm
…
Script.pm
…
SearchEngine.pm
…
SearchField.pm Bug 39367: Automatic changes 2025-04-23 09:35:14 +02:00
SearchFields.pm Bug 39367: Automatic changes 2025-04-23 09:35:14 +02:00
SearchFilter.pm
…
SearchFilters.pm
…
SearchMarcMap.pm Bug 39367: Automatic changes 2025-04-23 09:35:14 +02:00
SearchMarcMaps.pm Bug 39367: Automatic changes 2025-04-23 09:35:14 +02:00
Serial.pm
…
Serials.pm Bug 39367: Automatic changes 2025-04-23 09:35:14 +02:00
Session.pm
…
SharedContent.pm
…
SimpleMARC.pm Bug 39367: Automatic changes 2025-04-23 09:35:14 +02:00
Sitemapper.pm
…
Statistic.pm
…
Statistics.pm
…
StockRotationItem.pm
…
StockRotationItems.pm
…
StockRotationRota.pm
…
StockRotationRotas.pm
…
StockRotationStage.pm Bug 39717: Use numeric comparison for stock rotation stages 2025-04-24 19:53:15 +02:00
StockRotationStages.pm
…
Subscription.pm
…
Subscriptions.pm Bug 39367: Automatic changes 2025-04-23 09:35:14 +02:00
Suggestion.pm Bug 33430: Add strings_map method 2025-05-19 18:54:20 +02:00
SuggestionEngine.pm Bug 39325: Automatic fix 2025-04-28 18:51:22 +02:00
Suggestions.pm
…
Tag.pm
…
Tags.pm
…
TemplateUtils.pm Bug 39184: Turn off ABSOLUTE and EVAL_PERL for user-entered templates 2025-05-26 18:45:48 +02:00
Ticket.pm
…
Tickets.pm
…
Token.pm
…
TrackedLink.pm
…
TrackedLinks.pm Bug 39367: Automatic changes 2025-04-23 09:35:14 +02:00
UploadedFile.pm
…
UploadedFiles.pm
…
Uploader.pm
…
Virtualshelf.pm Bug 33440: Added permission requirements to unauthorized_transfer 2025-06-13 13:21:38 -06:00
Virtualshelfcontent.pm
…
Virtualshelfcontents.pm Bug 39367: Automatic changes 2025-04-23 09:35:14 +02:00
Virtualshelfshare.pm
…
Virtualshelfshares.pm Bug 39367: Automatic changes 2025-04-23 09:35:14 +02:00
Virtualshelves.pm
…
Z3950Responder.pm
…
Z3950Server.pm
…
Z3950Servers.pm
…