Koha-clms

History

Kyle M Hall 4a03a9dce2 Bug 41811: SIP server will inadvertently remove non-alphanumeric characters from the end of a message If a message ends in a non-alphanumeric character, that character is stripped from the message. For example: 6300120260210 182641 AOMPL\|AA23529000035676(\| 64 00120260210 182831000000000000000000000000AOCPL\|AA23529000035676\|AEHenry Acevedo\|BLY\|BHUSD\|BV0\|CC5\|BD4345 Library Rd. Springfield, MA 44224\|BF(212) 555-1212\|PB19580530\|PCS\|PIY\|AFGreetings from Koha. \| versus: 6300120260210 182641 AOMPL\|AA23529000035676(\|ACkoha\| 64YYYY 00120260210 182835000000000000000000000000AOCPL\|AA23529000035676(\|AE\|BLN\|AFInvalid cardnumber\| The former should be returning the same "Invalid cardnumber" message the latter does. Test Plan ( assumes you are using KTD ): 1) Install telnet: sudo apt install -y telnet 2) telnet 127.0.0.1 6001 3) Log in with: 9300CNkoha\|COkoha\|CPMPL\| 4) Send the patron information request: 6300120260210 183346 AOMPL\|AA23529000035676(\| 5) Note you get a patron back 6) Apply this patch 7) Restart SIP! 8) Repeat steps 2-5 9) Noe you doe not get a patron back in the response! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>		2026-05-23 15:58:45 -04:00
..
ILS	Bug 41818: Add new Koha::Patron::Message method to SIP2	2026-05-23 15:58:45 -04:00
Sip	Bug 40915: Add enhanced debug logging for empty critical fields in SIP message parsing	2025-10-28 21:29:02 +01:00
ILS.pm	Bug 39325: Automatic fix	2025-04-28 18:51:22 +02:00
Logger.pm	Bug 26673: Remove shebangs from Perl modules	2020-10-26 00:14:42 +01:00
Makefile	bug 3435: SIP2 - 3M extension for SmartChute checkin.	2009-07-30 11:06:53 -04:00
README	Bug 15253: Rename syslog() to siplog()	2020-05-12 11:46:46 +01:00
SIPServer.pm	Bug 41811: SIP server will inadvertently remove non-alphanumeric characters from the end of a message	2026-05-23 15:58:45 -04:00
Sip.pm	Bug 40675: Fix SIP message corruption from embedded line endings	2025-09-25 16:22:51 +02:00
Trapper.pm	Bug 39911: Remove redundant warn	2025-06-22 23:48:47 +02:00

README

README for Open NSIP 3M-SIP Server

DEPENDENCIES

SIPServer is written entirely in Perl, but it require these CPAN
perl modules to run:

     Net::Server - The SIP server is a Net::Server::Prefork server
     XML::LibXML
     XML::Parser
     XML::Simple - for parsing the config file
     UNIVERSAL::require - for loading the correct ILS interface module
     Clone - for running the test cases

LOGGING

SIPServer uses Koha::Logger for status and debugging messages.