Koha-clms/acqui
Kyle M Hall d1475051ba Bug 19425: Adding orders from order file with multiple budgets per record triggers error
If you import an order file ( using MarcItemFieldsToOrder ) that has a different budget for each item to be ordered, you will get an error and a partially created basket. This is because Koha attempts to add the item to each order *for each budget*. This is clearly incorrect. Instead, we should be grouping items by budget and for each budget only adding those items that have a matching budget.

Test plan:
1) Do not apply this patch
2) Download the provided MARC record
3) Add the branchcode 'ALD' to your server
4) Add the ccode 'ACOL' to your server
5) Add the budget codes 'adultay' and 'branchay' to your server
6) Stage the order file
7) Create a basket, import the order file
8) No we have 3 records, 2 of them have 2 items each with different budget codes
9) Attempt to import, note the error
10) Apply this patch
11) Repeat steps 6-8, note the order completes and results in 5 order lines being added to the basket!

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Christopher Kellermeyer <ckellermeyer@altadenalibrary.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
First step of test plan amended (not apply instead of apply).

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 0dc722c518)
2017-10-25 10:34:02 +02:00
..
pdfformat Bug 13726: Make Koha::Acq::Bookseller using Koha::Object 2016-12-30 11:54:32 +00:00
acqui-home.pl Bug 15758: Koha::Libraries - Ultimate duel for C4::Branch 2016-09-08 14:36:04 +00:00
add_user_search.pl Bug 15758: Koha::Libraries - Remove GetBranches 2016-09-08 14:36:03 +00:00
addorder.pl Bug 13321: use the populate_with_prices where needed 2016-10-28 13:46:06 +00:00
addorderiso2709.pl Bug 19425: Adding orders from order file with multiple budgets per record triggers error 2017-10-25 10:34:02 +02:00
ajax-getauthvaluedropbox.pl Bug 17847: Replace C4::Koha::GetAuthvalueDropbox with Koha::AuthorisedValues 2017-03-31 10:12:37 +00:00
basket.pl Bug 19180: [FOLLOW-UP] Renaming all instances of 'name' variable to 'booksellername' 2017-10-23 17:02:14 +02:00
basketgroup.pl Bug 19332 - Basket grouping PDF and CSV exports empty 2017-09-19 16:28:28 +02:00
basketheader.pl Bug 19130: (followup) Controller scripts should preserve behaviour 2017-09-29 15:21:57 +02:00
booksellers.pl Bug 19130: (followup) Controller scripts should preserve behaviour 2017-09-29 15:21:57 +02:00
cancelorder.pl Bug 7162: Factorize code for order cancellation (QA fixes) 2014-10-30 00:44:16 -03:00
check_budget_total.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
check_duplicate_barcode_ajax.pl Bug 16154: CGI->multi_param - Declare a list 2016-04-26 23:16:42 +00:00
check_uniqueness.pl Bug 16154: CGI->multi_param - Declare a list 2016-04-26 23:16:42 +00:00
edi_ean.pl Bug 7736: Support Ordering via Edifact EDI messages 2016-04-01 20:03:17 +00:00
edifactmsgs.pl Bug 17081 Incorrect comparison operator used in edifactmsgs.pl 2016-08-10 14:03:37 +00:00
edimsg.pl Bug 7736: Support Ordering via Edifact EDI messages 2016-04-01 20:03:17 +00:00
finishreceive.pl Bug 18471 - Receiving order with unitprice greater than 1000 processing incorrectly 2017-04-28 06:27:51 -04:00
histsearch.pl Bug 15758: Koha::Libraries - Ultimate duel for C4::Branch 2016-09-08 14:36:04 +00:00
invoice-files.pl Bug 16154: CGI->multi_param - Force scalar context 2016-04-26 23:16:43 +00:00
invoice.pl Bug 18471 - Receiving order with unitprice greater than 1000 processing incorrectly 2017-04-28 06:27:51 -04:00
invoices.pl Bug 19130: (followup) Controller scripts should preserve behaviour 2017-09-29 15:21:57 +02:00
lateorders-export.pl Bug 16154: CGI->multi_param - Declare a list 2016-04-26 23:16:42 +00:00
lateorders.pl Bug 14535: Update the supplier filter too 2017-03-31 12:38:44 +00:00
modordernotes.pl Bug 13726: Make Koha::Acq::Bookseller using Koha::Object 2016-12-30 11:54:32 +00:00
neworderbiblio.pl Bug 13726: Make Koha::Acq::Bookseller using Koha::Object 2016-12-30 11:54:32 +00:00
neworderempty.pl Bug 18432 : Follow up - Updating to use they/them 2017-04-21 10:56:43 -04:00
newordersubscription.pl Bug 13726: Make Koha::Acq::Bookseller using Koha::Object 2016-12-30 11:54:32 +00:00
newordersuggestion.pl Bug 13726: Make Koha::Acq::Bookseller using Koha::Object 2016-12-30 11:54:32 +00:00
ordered.pl Bug 17771: Add link to bibliographic record on spent/ordered lists in acquisitions 2017-01-19 11:44:29 +00:00
orderreceive.pl Bug 19194: Check itemtype is defined when receiving an order 2017-09-12 16:36:10 +02:00
parcel.pl Bug 18432: code comments assume male gender 2017-04-21 10:56:43 -04:00
parcels.pl Bug 18432: code comments assume male gender 2017-04-21 10:56:43 -04:00
spent.pl Bug 17771: aqorders.biblionumber was already part of the query 2017-01-19 12:00:16 +00:00
supplier.pl Bug 13726: Make Koha::Acq::Bookseller using Koha::Object 2016-12-30 11:54:32 +00:00
transferorder.pl Bug 19130: (followup) Controller scripts should preserve behaviour 2017-09-29 15:21:57 +02:00
uncertainprice.pl Bug 11122 - publisher code and publication year not fetched in acq orders 2017-06-09 15:15:50 +02:00
updatesupplier.pl Bug 18716: Remove CGI::param warns from updatesupplier.pl 2017-06-12 12:32:47 +02:00
z3950_search.pl Bug 19372: (bug 15801 follow-up) pass selected frameworkcode to the template 2017-10-17 10:14:21 +02:00