gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Koha-clms/acqui
History
Kyle M Hall d003bfa37c Bug 10277 - Add C4::Context->IsSuperLibrarian() 
The method of checking the logged in user for superlibrarian privileges
is obtuse ( $userenv && $userenv->{flags} % 2 != 1 ) to say the least.
The codebase is littered with these lines, with no explanation given. It
would be much better if we had one subroutine that returned a boolean
value to tell us if the logged in user is a superlibrarian or not.

Test Plan:
1) Apply this patch
2) Verify superlibrarian behavior remains unchanged

Signed-off-by: Joel Sasse <jsasse@plumcreeklibrary.net>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Comments on second patch.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit fb4025b67b)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
 		2014-08-07 09:36:50 +02:00
..
pdfformat Bug 7267: Add account number to German PDF template 2014-08-06 09:59:04 +02:00
acqui-home.pl Bug 10792: fix sorting of funds table on acquisitions home page 2013-09-16 15:30:33 +00:00
addorder.pl Bug 9822: Alert on adding an order to a basket if budget s exceeded 2013-10-30 15:10:11 +00:00
addorderiso2709.pl Bug 11018: allow adding order from a reverted MARC batch 2014-03-25 09:39:28 +01:00
aqbasketuser_search.pl Bug 7295: More granular permissions for baskets 2013-10-31 16:35:35 +00:00
basket.pl Bug 10277 - Add C4::Context->IsSuperLibrarian() 2014-08-07 09:36:50 +02:00
basketgroup.pl Bug 11828: Add German translation of layout2pages PDF template 2014-08-06 09:55:26 +02:00
basketheader.pl Bug 9364: fixes billing/delivery addresses for new baskets 2013-01-18 19:15:24 -05:00
booksellers.pl Bug 11171: Display basket group name on the supplier list page 2013-12-13 14:57:50 +01:00
check_budget_total.pl Bug 5385: POD Cleanups (part 1) 2010-11-12 10:06:55 +13:00
check_duplicate_barcode_ajax.pl Bug 6963: Corrects a problem when a new order is created with a duplicate barcode. 2011-11-04 10:22:28 +01:00
check_uniqueness.pl Bug 10483: fix item uniqueness check on order form 2013-08-14 21:17:11 +00:00
currency.pl Fix FSF address in directory acqui/ 2010-03-16 20:17:51 -04:00
fetch_sort_dropbox.pl Bug 8629: update of statistics fields on fund selection in order creation/edition 2012-09-14 16:57:02 +02:00
finishreceive.pl Bug 11699: change ModReceiveOrder to used named parameters 2014-08-06 14:58:06 +02:00
histsearch.pl Bug 5336: (follow-up) multiple QA fixes 2013-10-22 13:30:34 +00:00
invoice.pl Bug 10401: Add ability to merge invoices 2013-10-21 19:08:03 +00:00
invoices.pl Bug 10401: Add ability to merge invoices 2013-10-21 19:08:03 +00:00
lateorders-export.pl Bug 7298: (follow-up) various QA fixes 2013-10-31 15:51:25 +00:00
lateorders.pl Bug 7298: (follow-up) fix uninitialized variable warning 2013-10-31 15:52:47 +00:00
modordernotes.pl Bug 7166: Adds edit order notes when the basket is closed 2012-03-20 16:45:37 +01:00
neworderbiblio.pl Bug 9239 QA follow-up: the last QA follow-up was missing a require 2013-03-16 21:32:34 -04:00
neworderempty.pl Bug 10277 - Add C4::Context->IsSuperLibrarian() 2014-08-07 09:36:50 +02:00
newordersubscription.pl Bug 9508: Standardize the dateformat value from C4::Auth 2013-05-20 09:05:01 -07:00
newordersuggestion.pl Bug 11715: require authentication for various staff scripts 2014-06-26 14:08:24 +02:00
ordered.pl Bug 7735: removal of C4::Dates when unused 2012-03-20 18:11:04 +01:00
orderreceive.pl Bug 10403: Show inactive but unlocked budgets on orderreceive 2013-10-22 12:57:41 +00:00
parcel.pl Bug 9823: Refactor return from GetReservesFromBiblionumber 2014-05-27 12:17:44 +02:00
parcels.pl Bug 8821: make receive shipment page hide inactive funds like new order form 2013-09-16 16:26:12 +00:00
spent.pl Bug 9987: Remove DB field aqorders.biblioitemnunmber 2013-07-02 15:18:50 -07:00
supplier.pl Bug 11680: (follow-up) fix unexpected tax rate changes on edit 2014-08-06 14:05:03 +02:00
transferorder.pl Bug 11715: require authentication for various staff scripts 2014-06-26 14:08:24 +02:00
uncertainprice.pl Bug 10723: Merge GetPendingOrders and SearchOrders routines 2013-10-21 18:24:32 +00:00
updatesupplier.pl Bug 5335 - More granular VAT 2012-09-20 18:09:53 +02:00
z3950_search.pl Bug 11715: require authentication for various staff scripts 2014-06-26 14:08:24 +02:00