gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
41,482 Commits 39 Branches 720 Tags 6 GiB
Perl 44.2%
JavaScript 41.1%
HTML 6%
XSLT 3.1%
Vue 1.9%
Other 3.2%
Go to file
Nick Clemens cfc8b989d5 Bug 28754: Only adjust holds on specific biblio and don't go past end of array 
Our query for lowest priority holds only needs to adjust holds on the biblio we are looking at
so I add biblionumber

Additionally we can simply find the end of the array and use that rather than 99998
so I set new_rank to scalar @priority

Lastly, we don't need to fetch the lowest priority holds if we are ignoring lowest priority
so I move it into the conditional

To test:
 1 - Add holds with lowest priorty to 2 records in the catalog
 2 - Add a hold on a third record
 3 - Note errors in log like:
    [2021/07/23 17:47:17] [WARN] splice() offset past end of array at /kohadevbox/koha/C4/Reserves.pm line 1649
 4 - Apply patch and restart all the things
 5 - Add a new hold on third record - no warns
 6 - Make one of the holds on third record have lowestPriority (click rightmost arrow with line at bottom)
 7 - Note no warns
 8 - Adjust other holds on record and note no warns

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit a1748ae566)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
 		2021-08-11 10:01:41 -10:00
C4 Bug 28754: Only adjust holds on specific biblio and don't go past end of array 2021-08-11 10:01:41 -10:00
Koha Bug 22801: (follow-up) Use date-of-publication directly 2021-08-02 15:44:34 -10:00
acqui Bug 27828: (bug 24469 follow-up) Add missing import 2021-03-04 13:18:22 +01:00
admin Bug 28567: Fix 0 vs "" vs undef on the admin library form 2021-08-11 09:16:02 -10:00
api Revert "Bug 28480: Add q parameters for GET /patrons" 2021-08-02 15:56:27 -10:00
authorities Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
basket Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
bin Bug 20582: Turn Koha into a Mojolicious application 2020-10-06 12:00:04 +02:00
catalogue Bug 28513: Fix analytics search links so they don't match unrelated biblios 2021-07-07 14:49:13 -10:00
cataloguing Bug 28533: Set subfields to 'undef' if whole field request in itemcallnumebr system preference 2021-08-11 09:58:14 -10:00
circ Bug 16785: Remove Autocomplete from overdues report filter 2021-05-20 15:07:59 +02:00
clubs Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
course_reserves Bug 25898: Fix new occurrences 2020-10-15 13:56:41 +02:00
debian Bug 28620: Remove trailing space when logging with log4perl 2021-08-02 18:48:46 -10:00
docs Bug 28476: Update info in docs/teams.yaml file 2021-07-09 17:30:59 -10:00
errors
…
etc Bug 28620: Remove trailing space when logging with log4perl 2021-08-02 18:48:46 -10:00
ill Bug 22818: Add generation and sending of notices 2020-11-11 08:35:10 +01:00
installer Bug 28567: DBRev 21.06.00.011 2021-08-11 09:17:41 -10:00
koha-tmpl Bug 28704: Library MARCOrgCode field needs maxlength attribute 2021-08-11 09:47:36 -10:00
labels Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
members Bug 26940: don't reset debarredcomment on patron update 2021-04-29 11:47:16 +02:00
misc Bug 28399: Remove txn error from batchRebuildItemsTables.pl 2021-08-02 11:10:03 -10:00
offline_circ Bug 24083: Add support for unseen_renewals 2020-11-11 16:09:58 +01:00
opac Bug 28561: Remove DBIC warning in opac-shelves 2021-08-02 11:12:33 -10:00
patron_lists Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
patroncards Bug 27716: Update permissions for patroncards creator 2021-03-19 16:25:37 +01:00
plugins Bug 24633: Add support for gitlab searching of plugins 2020-11-06 15:55:17 +01:00
pos Bug 28181: Filter out archived debit types in point of sale 2021-05-12 16:38:02 +02:00
reports Bug 28570: Remove log to /tmp file from bor_issues_top.pl 2021-08-02 10:12:14 -10:00
reserve Bug 28057: (follow-up) Get the biblionumber column 2021-08-11 09:52:19 -10:00
reviews Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
rotating_collections Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
serials Bug 7806: Fix remaining occurrences of 0000-00-00 2021-03-04 10:24:48 +01:00
services Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
skel
…
suggestion Bug 7806: Fix remaining occurrences of 0000-00-00 2021-03-04 10:24:48 +01:00
svc Bug 27061: Remove duplicate permission check in svc/mana/search 2021-05-11 12:09:40 +02:00
t Bug 28632: Prevent api/v1/patrons.t to fail on dates comparison 2021-08-02 18:57:43 -10:00
tags
…
tmp/modified_authorities
…
tools Bug 28353: Display a list of items that cannot be deleted 2021-06-21 14:26:18 +02:00
virtualshelves Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
xt Bug 26971: Remove obsolete test file translatable-templates.t 2020-11-09 11:20:43 +01:00
.editorconfig
…
.eslintrc.json
…
.gitignore
…
.htaccess
…
.mailmap Bug 28386: Disambiguate Tomas and Blou 2021-06-23 07:35:21 +02:00
.perlcriticrc Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
.scss-lint.yml
…
INSTALL Bug 26617: Update INSTALL file to include koha-testing-docker and Gitlab links 2020-10-15 12:56:30 +02:00
Koha.pm Bug 28567: DBRev 21.06.00.011 2021-08-11 09:17:41 -10:00
LICENSE
…
MANIFEST.SKIP
…
Makefile.PL Bug 26363: Provide a systemd unit file for koha-worker for source installs 2021-03-02 08:31:29 +01:00
README
…
README.md Bug 27092: Remove note about "synced repo" from README.md 2020-11-25 16:31:58 +01:00
README.robots
…
about.pl Bug 28386: Sort authors by lastname || firstname 2021-06-23 07:35:21 +02:00
app.psgi Bug 20582: Fix PSGI file when behind a reverse proxy 2020-10-06 12:00:04 +02:00
changelanguage.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
cpanfile Bug 28302: Forbid CGI::Compile 0.24 2021-05-18 12:14:19 +02:00
fix-perl-path.PL
…
gulpfile.js Bug 27072: Don't process staff interface CSS with rtlcss 2020-11-24 21:27:59 +01:00
help.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
koha_perl_deps.pl
…
kohaversion.pl Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
mainpage.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
package.json Bug 25067: Move PO file manipulation code into gulp tasks 2020-11-06 09:46:11 +01:00
rewrite-config.PL Bug 26290: Make Makefile.PL aware of SMTP configs 2020-10-02 15:27:18 +02:00
yarn.lock Bug 25067: Move PO file manipulation code into gulp tasks 2020-11-06 09:46:11 +01:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo