759e63ccf4
If the pref KohaAdminEmailAddress was not set correctly (invalid email)
and has been used to generate message, the message_queue table can contain
some messages that are not sent (pending) and will be processed each
time a new self-reg is done.
The PatronSelfRegistrationVerifyByEmail feature must send only the
notice we just generated, not the whole pending queue.
Test plan:
1. Do not apply the patches
2. Set KohaAdminEmailAddress to an invalid email (root@localhost for
instance)
3. Turn on PatronSelfRegistrationVerifyByEmail
4. Self-reg a patron
5. Boom (that must be fixed on a separate bug report)
6. Set KohaAdminEmailAddress to a valid email (root@example.org)
7. Self-reg a patron
8. Still Boom! (because it's processing the first invalid email)
9. Apply the patches, restart_all
10. Self-reg a patron
=> The email is sent!
Notice the change in DB, the first email is still there with status
"pending" and second email is sent!
QA: at step 10. TODO first email must be 'failed' (highlight in tests)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit
|
||
|---|---|---|
| .. | ||
| clubs | ||
| errors | ||
| external/overdrive | ||
| rss | ||
| sci | ||
| sco | ||
| svc | ||
| ilsdi.pl | ||
| maintenance.pl | ||
| oai.pl | ||
| opac-ISBDdetail.pl | ||
| opac-MARCdetail.pl | ||
| opac-account-pay-paypal-return.pl | ||
| opac-account-pay-return.pl | ||
| opac-account-pay.pl | ||
| opac-account.pl | ||
| opac-addbybiblionumber.pl | ||
| opac-alert-subscribe.pl | ||
| opac-article-request-cancel.pl | ||
| opac-authorities-home.pl | ||
| opac-authoritiesdetail.pl | ||
| opac-basket.pl | ||
| opac-blocked.pl | ||
| opac-browse.pl | ||
| opac-browser.pl | ||
| opac-changelanguage.pl | ||
| opac-course-details.pl | ||
| opac-course-reserves.pl | ||
| opac-detail.pl | ||
| opac-discharge.pl | ||
| opac-downloadcart.pl | ||
| opac-downloadshelf.pl | ||
| opac-export.pl | ||
| opac-holdshistory.pl | ||
| opac-ics.pl | ||
| opac-idref.pl | ||
| opac-illrequests.pl | ||
| opac-image.pl | ||
| opac-imageviewer.pl | ||
| opac-issue-note.pl | ||
| opac-library.pl | ||
| opac-main.pl | ||
| opac-memberentry.pl | ||
| opac-messaging.pl | ||
| opac-modrequest-suspend.pl | ||
| opac-modrequest.pl | ||
| opac-mymessages.pl | ||
| opac-news-rss.pl | ||
| opac-overdrive-search.pl | ||
| opac-passwd.pl | ||
| opac-password-recovery.pl | ||
| opac-patron-consent.pl | ||
| opac-patron-image.pl | ||
| opac-privacy.pl | ||
| opac-ratings-ajax.pl | ||
| opac-ratings.pl | ||
| opac-readingrecord.pl | ||
| opac-recordedbooks-search.pl | ||
| opac-registration-verify.pl | ||
| opac-renew.pl | ||
| opac-reportproblem.pl | ||
| opac-request-article.pl | ||
| opac-reserve.pl | ||
| opac-restrictedpage.pl | ||
| opac-retrieve-file.pl | ||
| opac-review.pl | ||
| opac-routing-lists.pl | ||
| opac-search-history.pl | ||
| opac-search.pl | ||
| opac-sendbasket.pl | ||
| opac-sendshelf.pl | ||
| opac-serial-issues.pl | ||
| opac-shareshelf.pl | ||
| opac-shelves.pl | ||
| opac-showmarc.pl | ||
| opac-showreviews.pl | ||
| opac-suggestions.pl | ||
| opac-tags.pl | ||
| opac-tags_subject.pl | ||
| opac-topissues.pl | ||
| opac-user.pl | ||
| tracklinks.pl | ||
| unapi | ||