Koha-clms/t/db_dependent
Nick Clemens ce161fda9b Bug 25273: Make match-heading rely on authority type configuration
The match-heading field is a special field used only by the linker, not accessible
to staff or patrons via the interface. This field is used to store the constructed
'search form' used for matching bib headings to authority fields.

In bug 24269 I attempted to use the mappings defined in the inferface and also inject the search term.
This did not work as too many subfields were indexed on their own and leading to false matches.
In this bug we remove the mappings for this field, and create it ourselves during
the indexing process. The C4::Headings module is still used to generate the correct form,
however, the mappings are set based on the authority types in the system. This gives the user
the ability to add new typoes, but prevents mapping changes from breaking linker functionality

To test:
 1 - Start form a sample database with ElasticSearch working
 2 - Download via Z39.50 2 authorities, one of which is a narrower heading of the other, e.g.:
    Waterworks
    Waterworks - Costs
 3 - Place a heading for the broader term in a record. e.g. Waterworks
       In 650$a, without the cataloguing authority plugin. We don't want
       the link created now.
       You need syspref BiblioAddsAuthorities => allow
 4 - Make sure linker is set to default
 5 - Attempt to link the records
       misc/link_bibs_to_authorities.pl
 6 - Linking fails
 7 - Apply patch
 8 - refresh index settings (if using a custom file, remove 'match-heading')
       You can reset mappings in the UI or run this:
       misc/search_tools/rebuild_elasticsearch.pl -v -d -r
 9 - Reindex ES
10 - Try to link again
11 - It succeeds!
12 - Run the tests
     prove t/db_dependent/Koha/SearchEngine/Elasticsearch.t

Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Bug 25273: (follow-up)

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2020-08-31 16:10:25 +02:00
..
Acquisition Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
Auth
…
Authority Bug 22437: Add test case to Merge.t 2020-05-12 11:01:49 +01:00
Biblio Bug 24715: Cache repeatable subfield in TransformKohaToMarc 2020-04-17 09:25:06 +01:00
Circulation Bug 23695: (follow-up) Adjust for addition of transfer trigger 2020-08-18 15:45:48 +02:00
CourseReserves Bug 25444: Add unit tests 2020-05-28 17:01:55 +02:00
Creators Bug 25852: Add tests 2020-07-31 10:03:27 +02:00
Exporter
…
Holds Bug 24683: whole test formatted by 'perltidy' 2020-08-24 10:12:46 +02:00
Illrequest Bug 23632: Remove C4::Logs::GetLogs 2020-08-18 15:45:48 +02:00
Items Bug 23463: Move DelItem.t and Items_DelItemCheck.t tests to a Koha/Item.t subtest 2020-03-23 09:26:33 +00:00
Koha Bug 25273: Make match-heading rely on authority type configuration 2020-08-31 16:10:25 +02:00
LDAP Bug 21395: (QA follow-up) Remove some introduced issues 2020-06-29 12:37:02 +02:00
Labels Bug 23463: Replace ModItem with Koha::Item->store 2020-03-23 09:26:30 +00:00
Letters Bug 25629: Fix capitalization in sample notices 2020-07-22 10:17:53 +02:00
Members Bug 20443: Remove extended_attributes_code_value_arrayref AND C4::Members::Attributes 2020-03-23 13:49:22 +00:00
OAI Bug 24840: Replace DateTime->now with dt_from_string 2020-04-08 11:54:23 +01:00
Patron Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
Record Bug 21395: Fix QA errors 2020-06-29 12:37:02 +02:00
Reports Bug 22001: Make the DBD error regex less strict 2020-03-31 17:46:21 +01:00
Reserves Bug 25566: Add option to ignore found holds and use it when checking high holds 2020-07-16 15:32:18 +01:00
SIP Bug 25903: Add unit tests 2020-08-24 10:46:13 +02:00
Search
…
Serials Bug 7046: Implemented subscription renewal dropdown sub length element 2020-04-08 11:48:03 +01:00
Template/Plugin Bug 25765: (QA follow-up) Save a DB hit 2020-07-23 11:17:27 +02:00
Utils Bug 25875: Unit test 2020-06-29 12:37:02 +02:00
api/v1 Bug 25662: (follow-up) Add tests for the wrong patron_id added behaviour 2020-08-25 15:07:27 +02:00
cronjobs Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
data
…
selenium Bug 26015: Replace 2 missing occurrences 2020-08-31 16:10:25 +02:00
www Bug 26015: Terminology: Fix tons more staff clients to staff interfaces 2020-08-31 16:10:25 +02:00
00-strict.t
…
01-test_dbic.t
…
Accounts.t Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
Acquisition.t Bug 24161: Keep tracks of late orders claims 2020-05-04 09:44:44 +01:00
Amazon.t
…
ArticleRequests.t Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
AudioAlerts.t Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
Auth.t
…
Auth_with_cas.t Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
Auth_with_ldap.t Bug 25172: Fix Auth_with_ldap.t 2020-04-22 15:43:16 +01:00
AuthorisedValues.t Bug 17355: Fix failing tests 2020-05-05 14:59:30 +01:00
AuthoritiesMarc.t
…
BackgroundJob.t Bug 24760: (follow-up) Add a neighboring test messsage 2020-03-06 14:58:47 +00:00
Barcodes.t Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
Barcodes_ValueBuilder.t
…
Biblio.t Bug 25189: Unit tests 2020-06-24 14:31:37 +02:00
Breeding.t Bug 24052: Fix Koha/XSLT/Base.t 2020-03-24 10:42:23 +00:00
Budgets.t
…
Cache.t
…
Calendar.t Bug 25850: (QA follow-up) use dt_from_string 2020-07-16 15:28:06 +01:00
Charset.t
…
Circulation.t Bug 18501: (QA follow-up) Migrate and update unit tests 2020-08-20 12:31:59 +02:00
Clubs.t
…
Context.t Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
Contract.t
…
CourseReserves.t Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
DecreaseLoanHighHolds.t Bug 25566: Add option to ignore found holds and use it when checking high holds 2020-07-16 15:32:18 +01:00
Filter_MARC_ViewPolicy.t Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
Fines.t Bug 18936: (follow-up) Add foreign key and scope enhancement to circ rules 2020-02-04 09:56:24 +00:00
FrameworkPlugin.t
…
Heading.t Bug 24269: Adjust C4::Heading to generate headings from auth tags 2020-02-19 13:33:32 +00:00
Heading_MARC21.t Bug 24269: Adjust C4::Heading to generate headings from auth tags 2020-02-19 13:33:32 +00:00
Hold.t Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
Holds.t Bug 22789: (follow-up) Fix atomic update, GUI and more than one hold 2020-08-31 16:10:25 +02:00
HoldsQueue.t Bug 25786: AddReserve now takes a hashref 2020-06-18 18:51:58 +02:00
Holidays.t Bug 25723: Remove tests for removed method 2020-07-20 17:45:31 +02:00
ILSDI_Services.t Bug 24769: Regression tests 2020-05-05 11:03:45 +01:00
Illcomments.t
…
Illrequestattributes.t
…
Illrequests.t Bug 26114: Regression tests 2020-08-13 10:15:33 +02:00
ImportBatch.t Bug 20415: Remove UseKohaPlugins system preference 2020-03-26 11:42:02 +00:00
ImportExportFramework.t
…
Installer.t Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
Items.t Bug 18501: Don't use paidfor for DB fields not mapped with a MARC field 2020-08-21 12:03:09 +02:00
Koha.t Bug 16371: Remove GetDailyQuote tests from Koha.t 2020-08-13 10:15:33 +02:00
Koha_Authority.t
…
Koha_Database.t
…
Koha_Elasticsearch.t
…
Koha_ExternalContent_OverDrive.t Bug 25527: Add logger to Koha::ExternalContent 2020-05-18 15:25:03 +01:00
Koha_ExternalContent_RecordedBooks.t
…
Koha_Misc_Files.t Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
Languages.t
…
Letters.t Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
LibraryGroups.t Bug 22284: New methods in Koha::Library::Groups and Koha::Library 2020-01-03 12:58:03 +00:00
Linker_Default.t Bug 24269: Adjust C4::Heading to generate headings from auth tags 2020-02-19 13:33:32 +00:00
Linker_FirstMatch.t Bug 24269: Adjust C4::Heading to generate headings from auth tags 2020-02-19 13:33:32 +00:00
Log.t Bug 23632: Remove C4::Logs::GetLogs 2020-08-18 15:45:48 +02:00
MarcModificationTemplates.t Bug 24900: Checks in MARC mod templates for when from field does not equal conditional field 2020-04-03 14:26:31 +01:00
Members.t
…
MungeMarcPrice.t
…
NewsChannels.t
…
Overdues.t Bug 25127: Correction to tests 2020-05-01 15:44:51 +01:00
Passwordrecovery.t Bug 24840: Replace DateTime->now with dt_from_string 2020-04-08 11:54:23 +01:00
PatronLists.t
…
Patroncards.t
…
Patrons.t Bug 25683: Patron with no accountlines should have 0 outstanding (not NULL) 2020-08-06 11:37:06 +02:00
Record.t
…
RecordProcessor_EmbedSeeFromHeadings.t
…
Reports.t
…
Reserves.t Bug 23070: Add tests 2020-07-20 16:16:37 +02:00
RotatingCollections.t Bug 23463: Replace AddItem calls with Koha::Item->store 2020-03-23 09:26:26 +00:00
Search.t Bug 23086: Unit test 2020-07-27 17:24:26 +02:00
Serials.t Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
Serials_2.t Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
Service.t
…
ShelfBrowser.t Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
Sitemapper.t Bug 24840: Replace DateTime->now with dt_from_string 2020-04-08 11:54:23 +01:00
Stats.t
…
StockRotationItems.t Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
StockRotationRotas.t Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
StockRotationStages.t Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
SuggestionEngine_ExplodedTerms.t
…
Suggestions.t Bug 25033: Fix number of tests 2020-08-25 11:31:42 +02:00
TablesSettings.t Bug 24156: Make sort order and number of items to display configurable (basket page) 2020-06-25 10:51:59 +02:00
Tags.t
…
Templates.t
…
TestBuilder.t Bug 18936: (follow-up) Add foreign key and scope enhancement to circ rules 2020-02-04 09:56:24 +00:00
Upload.t Bug 21684: Fix UploadedFile[s]->delete 2020-01-07 16:32:53 +00:00
UsageStats.t Bug 24159: Move useDaysMode pref to circulation rules 2020-06-25 10:51:59 +02:00
Virtualshelves.t Bug 21684: Adjust some tests 2020-01-03 10:58:51 +00:00
XISBN.t Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
XSLT.t Bug 23463: Fix XSLT.t 2020-03-23 09:26:34 +00:00
check_kohastructure.t
…
check_sysprefs.t Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
db_structure.t
…
rollingloans.t
…
sysprefs.t Bug 22880: (follow-up) Loose ends: Better DB update, global inclusion, etc. 2020-02-24 13:24:25 +00:00
zebra_config.pl Bug 24735: Remove QueryParser-related code 2020-03-02 11:13:03 +00:00