gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
40,188 Commits 39 Branches 720 Tags 6 GiB
Perl 44.2%
JavaScript 41.1%
HTML 6%
XSLT 3.1%
Vue 1.9%
Other 3.2%
Go to file
Jonathan Druart cd742a15dd Bug 26738: (bug 24819 follow-up) Fix manager selection 
Bug 23590 added a new feature to select the manager of a suggestion.
One month later bug 24819 added the ability to pick the suggester.

This second patchset broke the manager selection.

This patch simplifies the way the suggester is selected, using the
generic way and mimicking what is done for the manager.

Test plan:
- create a new purchase suggestion from within acquisitions (suggestion.pl?op=add)
- click "select manager," search for user, click Select
- see that the user you just selected shows under "Created by,"
- see that "Managed by" still says "You"
- modify the suggester
- save your suggestion
=> Everything is saved correctly

QA will test the permission alert:
Edit suggestion.tt and remove "&permissions=suggestions.suggestions_manage"
Edit the suggestion, select a manager, pick a patron in the list who
does not have sufficient permissions, save
=> you get the alert

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
 		2020-11-04 12:59:32 +01:00
C4 Bug 26896: Enable SIP option holds_block_checkin to actually block checkin of items with holds 2020-11-03 11:07:22 +01:00
Koha Bug 26853: DBIC schema changes 2020-11-03 10:57:34 +01:00
acqui Bug 26577: Make basket.pl and cancelorder.pl use ->cancel 2020-10-15 14:50:07 +02:00
admin Bug 26721: Fix permission check on debit and credit type admin pages 2020-11-03 10:57:35 +01:00
api Bug 26595: Embed the whole smtp_server object 2020-10-14 15:53:38 +02:00
authorities Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
basket Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
bin Bug 20582: Turn Koha into a Mojolicious application 2020-10-06 12:00:04 +02:00
catalogue Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
cataloguing Bug 26605: Correctly URI-encode query string in call number browse plugin 2020-11-02 11:03:09 +01:00
circ Bug 18170: Show damaged status in table of checkins 2020-10-15 12:56:31 +02:00
clubs Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
course_reserves Bug 25898: Fix new occurrences 2020-10-15 13:56:41 +02:00
debian Bug 26702: Remove explicit libnet-stomp-perl from debian/control.in 2020-11-02 11:03:09 +01:00
docs Bug 25700: (follow-up) 2 minor corrections for KohaCon 2020-11-02 11:03:09 +01:00
errors Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
etc Bug 20582: Add very simple configuration file for Apache 2020-10-06 12:00:04 +02:00
ill Bug 23173: (follow-up) Small improvements in efficiency 2020-04-06 11:05:09 +01:00
installer Bug 26853: DBRev 20.06.00.056 2020-11-03 10:57:34 +01:00
koha-tmpl Bug 26738: (bug 24819 follow-up) Fix manager selection 2020-11-04 12:59:32 +01:00
labels Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
members Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
misc Bug 26601: Add utf8 encoding to text output of overdue_notices.pl 2020-10-26 00:14:41 +01:00
offline_circ Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
opac Bug 22806: (QA follow-up) 2020-11-02 11:03:08 +01:00
patron_lists Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
patroncards Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
plugins Bug 26751: Fix fatal exception if only one repo defined 2020-10-22 10:23:55 +02:00
pos Bug 26418: Fix translatability of REFUND credit type 2020-09-28 15:07:27 +02:00
reports Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
reserve Bug 22806: (QA follow-up) 2020-11-02 11:03:08 +01:00
reviews Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
rotating_collections Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
serials Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
services Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
skel Bug 11078: Add locking to rebuild_zebra 2014-02-28 22:21:41 +00:00
suggestion Bug 26738: (bug 24819 follow-up) Fix manager selection 2020-11-04 12:59:32 +01:00
svc Bug 17515: Order Z3950 server by rank and preserve ordering 2020-11-02 11:03:09 +01:00
t Bug 26896: Enable SIP option holds_block_checkin to actually block checkin of items with holds 2020-11-03 11:07:22 +01:00
tags Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
tmp/modified_authorities
…
tools Bug 25167: (QA follow-up) Don't add a new variable 2020-11-03 10:57:35 +01:00
virtualshelves Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
xt Bug 24972: Remove de-DE installer data 2020-10-26 00:14:42 +01:00
.editorconfig Bug 24774: Set JSON indentation of 2 spaces in .editorconfig 2020-03-19 09:24:52 +00:00
.eslintrc.json Bug 23834: Add default ESLint configuration 2019-11-03 08:02:39 +00:00
.gitignore Bug 20427: Convert OPAC LESS to SCSS 2018-08-09 15:17:07 +00:00
.htaccess
…
.mailmap Bug 26621: Adjust .mailmap to reduce the number of invalid authors 2020-10-15 12:56:30 +02:00
.perlcriticrc Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
.scss-lint.yml Bug 21237: Clean up staff client SCSS 2018-08-24 16:23:25 +00:00
INSTALL Bug 26617: Update INSTALL file to include koha-testing-docker and Gitlab links 2020-10-15 12:56:30 +02:00
Koha.pm Bug 26853: DBRev 20.06.00.056 2020-11-03 10:57:34 +01:00
LICENSE
…
MANIFEST.SKIP
…
Makefile.PL Bug 20582: Map app.psgi file and bin directory in Makefile.PL 2020-10-06 18:14:30 +02:00
README
…
README.md Bug 15465: Fix typo in bugs.k-c.org 2017-05-26 11:45:31 -03:00
README.robots
…
about.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
app.psgi Bug 20582: Fix PSGI file when behind a reverse proxy 2020-10-06 12:00:04 +02:00
changelanguage.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
cpanfile Bug 22417: Add new Net::Stomp dependency 2020-10-05 15:23:08 +02:00
fix-perl-path.PL Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
gulpfile.js Bug 20168: (follow-up) Add automatic creation of RTL CSS 2020-09-09 14:13:09 +02:00
help.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
koha_perl_deps.pl Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
kohaversion.pl Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
mainpage.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
package.json Bug 20168: (follow-up) Add automatic creation of RTL CSS 2020-09-09 14:13:09 +02:00
rewrite-config.PL Bug 26290: Make Makefile.PL aware of SMTP configs 2020-10-02 15:27:18 +02:00
yarn.lock Bug 20168: (follow-up) Add automatic creation of RTL CSS 2020-09-09 14:13:09 +02:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo