cc8cee9089
This code is a bit weird, its purpose it to auto select the library depending on the IP. A problem appears if the same IP is used, then the user's choice will might be overwritten randomly by another library. To recreate the problem: Turn on AutoLocation Use koha/koha @CPL for test And the following config: *************************** 1. row *************************** branchcode: CPL branchname: Centerville branchip: 172.18.0.1 *************************** 2. row *************************** branchcode: FFL branchname: Fairfield branchip: 172.18.0.1 *************************** 3. row *************************** branchcode: FPL branchname: Fairview branchip: 172.18.0.4 Connect and select CPL. Randomly FFL will be picked instead. Signed-off-by: Magnus Enger <magnus@libriotech.no> Tested this on top of 35890 and 35904 because git bz said they were required dependencies. Figured out the IP Koha was seeing me as coming from in /var/log/koha/kohadev/plack.log. Added that IP to the branchip for Centerville, Fairfield and Fairview. Set AutoLocation = Yes. After this I could recreate the problem: If i left the "Library" field in the login screen at "My Library" I got logged into a random library selected from the three i had set branchip for. Applying the patches fixed this, as expected. Tests pass, with AutoLocation off. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> |
||
|---|---|---|
| C4 | ||
| Koha | ||
| acqui | ||
| admin | ||
| api | ||
| authorities | ||
| basket | ||
| bin | ||
| catalogue | ||
| cataloguing | ||
| circ | ||
| clubs | ||
| course_reserves | ||
| debian | ||
| docs | ||
| erm | ||
| errors | ||
| etc | ||
| ill | ||
| installer | ||
| koha-tmpl | ||
| labels | ||
| lib/CGI/Session/Serialize | ||
| members | ||
| misc | ||
| offline_circ | ||
| opac | ||
| patron_lists | ||
| patroncards | ||
| plugins | ||
| pos | ||
| recalls | ||
| reports | ||
| reserve | ||
| reviews | ||
| rotating_collections | ||
| serials | ||
| services | ||
| skel | ||
| suggestion | ||
| svc | ||
| t | ||
| tags | ||
| tools | ||
| virtualshelves | ||
| xt | ||
| .editorconfig | ||
| .eslintrc.json | ||
| .gitignore | ||
| .htaccess | ||
| .mailmap | ||
| .perlcriticrc | ||
| .perltidyrc | ||
| .proverc.dist | ||
| .stylelintrc.json | ||
| INSTALL | ||
| Koha.pm | ||
| LICENSE | ||
| MANIFEST.SKIP | ||
| Makefile.PL | ||
| README | ||
| README.md | ||
| README.robots | ||
| about.pl | ||
| app.psgi | ||
| build-resources.PL | ||
| changelanguage.pl | ||
| cpanfile | ||
| cypress.json | ||
| fix-perl-path.PL | ||
| gulpfile.js | ||
| help.pl | ||
| koha_perl_deps.pl | ||
| kohaversion.pl | ||
| mainpage.pl | ||
| package.json | ||
| rewrite-config.PL | ||
| tsconfig.json | ||
| webpack.config.js | ||
| yarn.lock | ||
README.md
Koha is a free software integrated library system (ILS).
Koha is distributed under the GNU GPL version 3 or later.
Note: Koha does not accept pull requests from git hosting sites.
Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.
For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch
The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook
