Go to file
Tomas Cohen Arazi cc418a482a Bug 29418: Make clean_search_term escape double quotes
We noticed that several characters will break Zebra queries. So search
terms need to be quoted for things to work. In this context, double
quotes inside search terms are problematic because double quotes are
what we use for quoting strings.

This patch makes the clean_search_term method escape double quotes.

To test:
1. Apply the unit tests patch
2. Run:
   $ kshell
  k$ prove t/Koha/SearchEngine/Zebra/QueryBuilder.t
=> FAIL: It doesn't work as it should!
3. Apply this patch
4. Repeat 2
=> SUCCESS: It does the job!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
2022-07-14 21:40:22 +02:00
C4 Revert "Bug 30035: Fix month name in prediction pattern" 2022-07-14 21:40:19 +02:00
Koha Bug 29418: Make clean_search_term escape double quotes 2022-07-14 21:40:22 +02:00
acqui Bug 29771: Remove trivial cases 2022-04-25 19:44:44 +00:00
admin Bug 30142: Remove spaces from ElasticSearch mapping MARC fields 2022-04-25 20:40:11 +00:00
api Bug 30663: Add x-koha-override options to /suggestions 2022-06-25 04:48:54 +02:00
authorities Bug 28160: Values from 150$a aren't prefilled in z39.50 search form from an existing authority record 2021-05-10 15:52:53 +02:00
basket Bug 27268: (QA follow-up) Add Koha::Biblios to basket scripts 2021-03-09 17:20:47 +01:00
bin Bug 20582: Turn Koha into a Mojolicious application 2020-10-06 12:00:04 +02:00
catalogue Bug 29785: Rename Koha::Object->message with ->object_messages 2022-02-21 16:35:20 +00:00
cataloguing Bug 29511: Sort hash keys 2022-02-21 15:22:39 +00:00
circ Bug 30630: Prevent crash on check-in if HoldsAutoFill is ON 2022-06-23 01:31:59 +02:00
clubs Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
course_reserves Bug 25898: Fix new occurrences 2020-10-15 13:56:41 +02:00
debian Bug 30084: Remove explicit dependency of liblocale-codes-perl 2022-03-20 14:48:51 +00:00
docs Bug 30808: Add the 22.05 release team. 2022-06-27 16:46:36 +02:00
errors Bug 26048: Use ErrorDocument middleware for Plack HTTP errors 2021-01-27 10:30:43 +01:00
etc Bug 18540: (QA follow-up) Only mention index_sort_title if defined 2022-02-11 18:50:53 +00:00
ill Bug 22818: Add generation and sending of notices 2020-11-11 08:35:10 +01:00
installer Increment version for 21.05.16 release 2022-06-27 16:50:33 +02:00
koha-tmpl Bug 30628: Fix patron selection in batch patron modification tool 2022-06-23 03:51:17 +02:00
labels Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
lib/CGI/Session/Serialize Bug 28519: Put CGI::Session::Serialize::yamlxs in lib directory 2021-06-18 11:23:42 -04:00
members Bug 29758: Get rid of warning in members/boraccount.pl 2022-02-11 18:53:57 +00:00
misc Update release notes for 21.05.16 release 2022-06-28 01:36:40 +02:00
offline_circ Bug 29255: Built-in offline circulation broken with SQL error 2021-11-19 10:51:05 -05:00
opac Bug 30199: Do not generate jwt if patron does not exist 2022-05-03 20:12:54 +00:00
patron_lists Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
patroncards Bug 24001: Fix patron card template edition 2022-06-17 05:25:04 +02:00
plugins Bug 29931: [21.05.x] Check cookie status before continuing 2022-03-09 15:09:19 +00:00
pos Bug 28481: (RM follow-up) formatting 2021-12-17 21:22:24 +00:00
reports Bug 28977: Fix cat_issues_top.pl report with strict SQL modes 2022-02-21 16:30:35 +00:00
reserve Bug 29043: Don't fetch items if when are not on the 'Place a hold on' form 2022-02-21 15:28:43 +00:00
reviews Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
rotating_collections Bug 26618: (QA follow-up) Fix unit test for TranferCollection change 2021-03-03 15:36:13 +01:00
serials Bug 23243: Adjust previous patch 2021-04-21 15:25:07 +02:00
services Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
skel
…
suggestion Bug 28946: (bug 23271 follow-up) Missing occurrence in add_user_search.pl 2021-10-01 13:26:38 -04:00
svc Bug 29771: Remove trivial cases 2022-04-25 19:44:44 +00:00
t Bug 29418: Unit tests 2022-07-14 21:40:22 +02:00
tags Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
tmp/modified_authorities
…
tools Bug 29771: Scalar context for split 2022-04-25 19:50:15 +00:00
virtualshelves Bug 29542: Prevent access to private list to non authorized users 2022-01-28 14:17:15 +00:00
xt Bug 28370: Rewrite tests 2021-05-25 09:28:18 +02:00
.editorconfig
…
.eslintrc.json
…
.gitignore
…
.htaccess
…
.mailmap Bug 28386: Disambiguate Tomas and Blou 2021-05-26 12:30:59 +02:00
.perlcriticrc Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
.scss-lint.yml
…
INSTALL Bug 26617: Update INSTALL file to include koha-testing-docker and Gitlab links 2020-10-15 12:56:30 +02:00
Koha.pm Increment version for 21.05.16 release 2022-06-27 16:50:33 +02:00
LICENSE
…
MANIFEST.SKIP
…
Makefile.PL Bug 28519: Put CGI::Session::Serialize::yamlxs in lib directory 2021-06-18 11:23:42 -04:00
README
…
README.md Bug 27092: Remove note about "synced repo" from README.md 2020-11-25 16:31:58 +01:00
README.robots
…
about.pl Bug 28870: Move email address validation to a specific class method 2021-11-15 07:21:49 -05:00
app.psgi Bug 20582: Fix PSGI file when behind a reverse proxy 2020-10-06 12:00:04 +02:00
changelanguage.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
cpanfile Bug 30084: Remove dependency of liblocale-codes-perl (follow-up) 2022-03-20 14:49:03 +00:00
fix-perl-path.PL
…
gulpfile.js Bug 27072: Don't process staff interface CSS with rtlcss 2020-11-24 21:27:59 +01:00
help.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
koha_perl_deps.pl
…
kohaversion.pl Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
mainpage.pl Bug 29020: Add link on the mainpage for users without admin access 2022-04-15 18:04:06 +00:00
package.json Bug 27939: Update yarn.lock file 2021-03-16 12:04:06 +01:00
rewrite-config.PL Bug 28519: Put CGI::Session::Serialize::yamlxs in lib directory 2021-06-18 11:23:42 -04:00
yarn.lock Bug 27939: Update yarn.lock file 2021-03-16 12:04:06 +01:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo