Koha-clms/Koha/Patron
emlam 148eec6bb3 Bug 34435: Remove side effect from get_password_expiry_date
If get_password_expiry_date is passed a DateTime object
as a parameter, it modifies and returns the original
object. This can create possible side effects.

This patch modifies get_password_expiry_date to clone the
DateTime object that it receives as a parameter and
return the modified clone, so that object references can
be passed in safely.

To test:
prove t/db_dependent/Koha/Patron/Category.t

Signed-off-by: Sam Lau <samalau@gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit dae5607fd1)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit f067a82e3a)
Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
2023-08-18 13:50:43 +00:00
..
Attribute Bug 8326: Make repeatable and unique_id modifiable when editing patron attribute type 2021-02-15 11:48:55 +01:00
Password Bug 31739: Password recovery from staff fails if previous expired reset-entry exists. 2022-10-24 14:12:16 -03:00
Restriction Bug 31095: Remove keyed_on_code 2023-02-01 15:36:12 +00:00
Attribute.pm Bug 28031: Remove type from parameter of *_ok methods 2021-04-09 15:43:34 +02:00
Attributes.pm Bug 29844: Fix t/db_dependent/Koha/* 2022-02-09 15:36:23 -10:00
Categories.pm Bug 23271: (QA follow-up) Minor POD fix 2021-04-21 15:25:07 +02:00
Category.pm Bug 34435: Remove side effect from get_password_expiry_date 2023-08-18 13:50:43 +00:00
Consent.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Consents.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Debarments.pm Bug 31095: Remove GetDebarments from Koha::Patron::Debarments 2023-02-01 15:39:29 +00:00
Discharge.pm Bug 29395: use EXPORT_OK from Koha::Patron::Debarments 2021-11-03 15:40:52 +01:00
Files.pm Bug 28572: Remove C4::Debug 2021-06-22 12:04:32 +02:00
HouseboundProfile.pm Bug 29847: Make Koha::Patron::HouseboundProfile->housebound_visits return a resultset 2022-02-09 15:36:23 -10:00
HouseboundProfiles.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
HouseboundRole.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
HouseboundRoles.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
HouseboundVisit.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
HouseboundVisits.pm Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Image.pm Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
Images.pm Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
Message.pm Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
Messages.pm Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
Modification.pm Bug 29844: Fix ->search occurrences 2022-02-09 15:36:23 -10:00
Modifications.pm Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
Relationship.pm Bug 33671: Update POD, remove unneeded check in relationship->guarantor 2023-05-15 12:23:29 +00:00
Relationships.pm Bug 29844: Fix t/db_dependent/Koha/* 2022-02-09 15:36:23 -10:00
Restriction.pm Bug 31095: (QA follow-up) Fix POD 2023-02-01 15:40:26 +00:00
Restrictions.pm Bug 31095: (QA follow-up) Fix POD 2023-02-01 15:40:26 +00:00