Go to file
Nick Clemens cbeb763ada Bug 29483: [21.11.x] Check ItemsAnyAvailableAndNotRestricted once per patron
ItemsAnyAvailableAndNotRestricted can take a long time and create nested loops.
We can check it once per patron, however, this requires us to flip the loops.
Since an item can only be used once, we now add a check to see if this item has already
been assigned to a borrower.

To test:
1 - Find or create a biblio with 100 items
2 - Place ten 'Next available' holds on a biblio
3 - Set preference 'AllowRenewalIfOtherItemsAvailable' to 'Allow'
    Set circ rules 'On shelf holds allowed' to 'If any unavailable'
4 - Checkout one of the items to a patron, backdated to be overdue
5 - Note a long loading time for the patron's checkouts
6 - Apply patch, restart_all
7 - Patron loads much faster

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Bug 29483: Unit tests

This patch updates the AllowRenewalIfOtherItemsAvailable tests to
remove deletion of all data, and create specific circ rules for this
test. It adjust several other tests that were relying on the rules from
this test, so thy too create their opwn specific rules.

Additionally, we add tests to cover the case of mutliple items on the record,
and some items cannot fill some reserves.

What is uncovered here is that the same patron is checked twice, so two holds can
be filled, but they only satisfy a single patron

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Bug 29483: Further improve performance of script

This patch adds a few tests to cover more cases, and to highlight current functionality.

The script only allows renewal if all outstanding holds can be filled by available items.
This means we can return as soon as we have determined that not all holds can be filled.

I add FIXME and some explanatory comments - I will file a follow-up bug for those, but
I feel we can accept these improvements to the performance and deal with the issues
of how it 'should' work versus how it does work on another report.

To test:
1 - prove -v t/db_dependent/Circulation.t

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2022-05-06 10:53:32 -04:00
C4 Bug 29483: [21.11.x] Check ItemsAnyAvailableAndNotRestricted once per patron 2022-05-06 10:53:32 -04:00
Koha Bug 30461: Fix BatchUpdateAuthority 2022-05-06 10:52:26 -04:00
acqui Bug 29771: Remove trivial cases 2022-03-11 06:35:45 -05:00
admin Bug 30142: Remove spaces from ElasticSearch mapping MARC fields 2022-04-15 07:40:36 -04:00
api Bug 30165: Make q parameter 'multi' 2022-03-25 09:37:06 -04:00
authorities Bug 29334: Do not apply defaultvalue to existing auth record 2021-11-15 12:38:39 +01:00
basket Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
bin Bug 20582: Turn Koha into a Mojolicious application 2020-10-06 12:00:04 +02:00
catalogue Bug 30008: (bug 29690 follow-up) Fix Invalid data, cannot decode metadata object 2022-03-25 09:52:21 -04:00
cataloguing Bug 25616: [21.11.x] Uppercase hard coded lower case boolean operators for Elasticsearch 2022-03-04 09:20:36 -05:00
circ Bug 30251: (bug 10902 follow-up) With IndependentBranches non-superlibrarians do not get autocomplete list in circulation module 2022-04-01 06:36:48 -04:00
clubs Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
course_reserves Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
debian Bug 29957: Add --keep-cookie option to koha-create 2022-04-15 07:15:21 -04:00
docs 21.11.00 - Update history.txt 2021-11-26 12:26:22 +01:00
errors Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
etc Bug 29957: Add example lines in koha-conf.xml 2022-04-15 07:15:21 -04:00
ill Bug 22614: Migrate original request 2021-09-21 20:22:57 +02:00
installer Bug 27253: (follow-up) Fix UNIXTIME(0) in db_revs/211200037.pl 2022-04-29 13:35:04 -04:00
koha-tmpl Bug 18392: Add noExport of rows and don't export 'edit' row 2022-04-29 13:31:14 -04:00
labels Bug 25616: [21.11.x] (QA follow-up) Catch a case in labels/label-item-search.pl 2022-03-04 09:20:36 -05:00
lib/CGI/Session/Serialize Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
members Bug 17648: (QA follow-up) Restore imediate sending of the notice 2022-03-25 09:32:21 -04:00
misc Update release notes for 21.11.05 release 2022-04-26 17:56:09 +00:00
offline_circ Bug 30525: Items batch modification broken 2022-04-22 14:29:43 -04:00
opac Bug 30532: (bug 29957 follow-up) Fix '$cookie->value' 2022-04-22 14:29:10 -04:00
patron_lists Bug 16446: Add ability to add patrons to list by borrowernumber 2021-10-21 12:24:04 +02:00
patroncards Bug 28576: Update the maximum size of an image. 2022-02-18 06:40:58 -05:00
plugins Bug 29787: Add plugin version to plugin search results 2022-04-15 06:36:54 -04:00
pos Bug 28481: (RM follow-up) formatting 2021-12-17 10:04:21 -05:00
reports Bug 30532: (bug 29957 follow-up) Fix '$cookie->value' 2022-04-22 14:29:10 -04:00
reserve Bug 29771: Scalar context for split 2022-03-11 06:35:50 -05:00
reviews Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
rotating_collections Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
serials Bug 30377: Fix two CGI::param called in list context-warnings 2022-04-08 10:40:16 -04:00
services Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
skel
…
suggestion Bug 24370: Allow resetting library to ANY 2021-11-02 14:57:04 +01:00
svc Bug 26669: (QA follow-up) Update last run when report run by name 2022-04-08 10:46:13 -04:00
t Bug 29483: [21.11.x] Check ItemsAnyAvailableAndNotRestricted once per patron 2022-05-06 10:53:32 -04:00
tags Bug 29469: (bug 17600 follow-up) Fix tag approval/rejection from staff 2021-11-16 15:49:22 +01:00
tmp/modified_authorities
…
tools Bug 30525: Items batch modification broken 2022-04-22 14:29:43 -04:00
virtualshelves Bug 29542: Prevent access to private list to non authorized users 2022-01-25 14:43:23 -05:00
xt Bug 27622: Fix sample_notices.t 2021-10-07 15:49:01 +02:00
.editorconfig Bug 27375: Set YAML file settings in .editorconfig 2021-11-03 15:40:52 +01:00
.eslintrc.json Bug 23834: Add default ESLint configuration 2019-11-03 08:02:39 +00:00
.gitignore Bug 20427: Convert OPAC LESS to SCSS 2018-08-09 15:17:07 +00:00
.htaccess
…
.mailmap 21.11.00 - Update .mailmap 2021-11-26 12:26:22 +01:00
.perlcriticrc Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
.proverc.dist Bug 19821: Install sample data, ES mappings and Version syspref 2021-10-25 11:27:40 +02:00
.scss-lint.yml Bug 21237: Clean up staff client SCSS 2018-08-24 16:23:25 +00:00
INSTALL Bug 26617: Update INSTALL file to include koha-testing-docker and Gitlab links 2020-10-15 12:56:30 +02:00
Koha.pm Bug 27253: DBRev 21.11.05.001 2022-04-29 13:29:06 -04:00
LICENSE
…
MANIFEST.SKIP
…
Makefile.PL Bug 18984: Remove NORMARC support 2021-10-07 15:36:40 +02:00
README
…
README.md Bug 27092: Remove note about "synced repo" from README.md 2020-11-25 16:31:58 +01:00
README.robots
…
about.pl Bug 28870: Move email address validation to a specific class method 2021-09-28 10:22:36 +02:00
app.psgi Bug 20582: Fix PSGI file when behind a reverse proxy 2020-10-06 12:00:04 +02:00
changelanguage.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
cpanfile Bug 28610: Elasticsearch 7 - hits.total is now an object 2022-04-08 10:41:05 -04:00
fix-perl-path.PL Bug 28606: Remove $DEBUG and $ENV{DEBUG} 2021-06-24 11:53:44 +02:00
gulpfile.js Bug 18984: Remove NORMARC support 2021-10-07 15:36:40 +02:00
help.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
koha_perl_deps.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
kohaversion.pl Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
mainpage.pl Bug 29020: Add link on the mainpage for users without admin access 2021-10-19 09:29:09 +02:00
package.json Bug 27939: Update yarn.lock file 2021-03-16 12:04:06 +01:00
rewrite-config.PL Bug 28519: Put CGI::Session::Serialize::yamlxs in lib directory 2021-06-17 10:07:36 +02:00
yarn.lock Bug 27939: Update yarn.lock file 2021-03-16 12:04:06 +01:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo