gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Koha-clms/C4
History
Jared Camins-Esakov 9086611f2d Bug 9174: Fix itemtype image display in OPAC lists 
Prior to this patch, C4::VirtualShelves::Page did not make sure that
the itemtype images that it chose when displaying itemtype images for
biblio-level itemtypes were for the correct interface, so
even on the OPAC the Intranet icons were requested. On standard
installations, intranet-tmpl is not available to the OPAC.

To test:
1) Set noItemTypeImages to "Show" and item-level_items to "biblio record"
2) Create a list and add an item with the default item type (942$c in
   MARC21) set to something with an itemtype image associated with it.
3) View the list in the OPAC.
4) If you are an a standard install, the itemtype image will be a broken
   link. If on a dev install, you can confirm with Firebug or the like
   that the image is pulled from /intranet-tmpl.
5) Apply patch.
6) Run `prove t/db_dependent/Koha.t` to confirm that the behavior of the
   routine used to retrieve the image URL is correct. (Note that you
   must have an item type with the code 'BK')
7) Refresh the list, noting that the display is now correct/the image is
   pulled from opac-tmpl.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
It works as expected. All tests in Koha.t passed.
Signed-off-by: Mason James <mtj@kohaaloha.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>

Conflicts:

	t/db_dependent/Koha.t

Squashed with: Bug 9174 follow-up: Eliminate warning and fix POD

Thanks to Marcel for spotting these issues.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Mason James <mtj@kohaaloha.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
 		2013-02-03 15:27:40 +13:00
..
AuthoritiesMarc Bug 7941 : Module versions bumped pre release 2012-06-14 19:19:50 +12:00
Barcodes Bug 8524 follow-up: fix Javascript syntax error 2012-09-14 08:58:28 +12:00
Cache Bug 5385: POD Cleanups (part 1) 2010-11-12 10:06:55 +13:00
ClassSortRoutine Bug 7941 : Module versions bumped pre release 2012-06-14 19:19:50 +12:00
Creators Bug 8315 - remove use C4::* version 2012-07-14 10:26:07 +12:00
External Bug 7941 : Module versions bumped pre release 2012-06-14 19:19:50 +12:00
Form Fix for Bug 6458 - incorrect parsing result in translation processing 2011-09-15 08:38:58 +12:00
Heading Bug 7941 : Module versions bumped pre release 2012-06-14 19:19:50 +12:00
ILSDI Bug 8850: Export CanItemBeReserved in C4::ILSDI::Services 2012-10-06 20:10:46 +13:00
Installer Bug 8806 - [3.8.x] Changelog updates, dependencies 2012-10-11 14:58:45 +13:00
Labels Bug 7941 : Module versions bumped pre release 2012-06-14 19:19:50 +12:00
Linker Bug 8447: Make sure we have enough subfields for broader_headings 2012-09-16 08:18:58 +12:00
Members Bug 7941 : Module versions bumped pre release 2012-06-14 19:19:50 +12:00
OAI Bug 6440: Implement OAI-PMH Sets 2012-03-20 11:38:26 +01:00
Output Fix FSF address in directory C4/ 2010-03-16 20:17:56 -04:00
Patroncards Bug 8315 - remove use C4::* version 2012-07-14 10:26:07 +12:00
Reports Bug 8594 - prevent the report system from breaking some subqueries 2012-09-06 11:05:15 +12:00
SIP Bug 8336 follow-up, tabs to space 2012-09-19 14:56:17 +12:00
Search Bug 5385: POD Cleanups (part 1) 2010-11-12 10:06:55 +13:00
Utils Bug 7941 : Module versions bumped pre release 2012-06-14 19:19:50 +12:00
VirtualShelves Bug 9174: Fix itemtype image display in OPAC lists 2013-02-03 15:27:40 +13:00
Accounts.pm Bug 8739 follow-up fixing perlcritic error 2012-10-04 08:34:38 +13:00
Acquisition.pm SIGNED-OFF] bug 8382: It is not possible to cancel an order on a filtered page in parcel.pl 2012-12-14 08:56:29 +13:00
Auth.pm Bug 9102 : Set HttpOnly on the CGISESSID cookie 2013-01-13 08:01:58 +13:00
Auth_cas_servers.yaml.orig Bug 5630 CAS improvements 2011-10-13 10:49:49 +13:00
Auth_with_cas.pm Bug 7941 : Module versions bumped pre release 2012-06-14 19:19:50 +12:00
Auth_with_ldap.pm Bug 7941 : Module versions bumped pre release 2012-06-14 19:19:50 +12:00
AuthoritiesMarc.pm Bug 9123: Authorities search ordered by authid does not work 2012-12-03 20:00:51 +13:00
BackgroundJob.pm Bug 7941 : Module versions bumped pre release 2012-06-14 19:19:50 +12:00
Barcodes.pm Bug 7941 : Module versions bumped pre release 2012-06-14 19:19:50 +12:00
Biblio.pm Bug 9147: OPAC hidden fields are not hidden in ISBD view 2013-02-01 21:00:43 +13:00
Bookseller.pm Bug 8223 - Properly format SQL query in C4::Bookseller::GetBookSeller 2012-06-22 14:17:59 +12:00
Boolean.pm Bug 7941 : Module versions bumped pre release 2012-06-14 19:19:50 +12:00
Branch.pm Bug 7941 : Module versions bumped pre release 2012-06-14 19:19:50 +12:00
Breeding.pm Bug 8350: warning in logs when searching for nonexistent ISBN 2012-10-04 08:06:50 +13:00
Budgets.pm Bug 7941 : Module versions bumped pre release 2012-06-14 19:19:50 +12:00
Cache.pm Bug 5363 - Removing unused module (C4::Cache::FastMemcached) 2010-11-04 20:05:36 +13:00
Calendar.pm Bug 7477: Followup: Fix perlcritic issues 2012-03-19 18:16:40 +01:00
Category.pm Bug 4330 : Adding copyright headers and fixing FSF addresses 2012-05-29 16:52:19 +12:00
Charset.pm Bug 7941 : Module versions bumped pre release 2012-06-14 19:19:50 +12:00
Circulation.pm Bug 8800 - useDaysMode=Datedue wrong behaviour (revisited) 2012-11-26 13:22:56 +13:00
ClassSortRoutine.pm Bug 7941 : Module versions bumped pre release 2012-06-14 19:19:50 +12:00
ClassSource.pm Bug 7941 : Module versions bumped pre release 2012-06-14 19:19:50 +12:00
Context.pm Bug 9085 - Installer will not run with DEBUG set 2012-11-21 08:42:12 +13:00
Contract.pm Bug 7941 : Module versions bumped pre release 2012-06-14 19:19:50 +12:00
Creators.pm Bug 8315 - remove use C4::* version 2012-07-14 10:26:07 +12:00
Csv.pm Bug 7941 : Module versions bumped pre release 2012-06-14 19:19:50 +12:00
Dates.pm Bug 7941 : Module versions bumped pre release 2012-06-14 19:19:50 +12:00
Debug.pm Bug 7941 : Module versions bumped pre release 2012-06-14 19:19:50 +12:00
Heading.pm Bug 7941 : Module versions bumped pre release 2012-06-14 19:19:50 +12:00
Images.pm Bug 7941 : Module versions bumped pre release 2012-06-14 19:19:50 +12:00
ImportBatch.pm Bug 7329 [Followup] : when reverting an import, keep matching biblionumber in batch table, if items are not deleted because they are issued. 2012-06-20 21:01:02 +12:00
ImportExportFramework.pm Bug 7941 : Module versions bumped pre release 2012-06-14 19:19:50 +12:00
Input.pm Bug 7941 : Module versions bumped pre release 2012-06-14 19:19:50 +12:00
Installer.pm Bug 8315 - remove use C4::* version 2012-07-14 10:26:07 +12:00
ItemCirculationAlertPreference.pm Bug 4330 : Adding copyright headers and fixing FSF addresses 2012-05-29 16:52:19 +12:00
ItemType.pm Bug 4330 : Adding copyright headers and fixing FSF addresses 2012-05-29 16:52:19 +12:00
Items.pm Bug 8988: item status uses authorized value description for intranet 2012-11-11 18:56:53 +13:00
Koha.pm Bug 9174: Fix itemtype image display in OPAC lists 2013-02-03 15:27:40 +13:00
Labels.pm Bug 8315 - remove use C4::* version 2012-07-14 10:26:07 +12:00
Languages.pm Bug 8954: Make languages list in advanced search translatable (revision 1) 2012-11-26 13:19:24 +13:00
Letters.pm Bug 9348 - Format dates in HOLD notices consistently 2013-02-01 21:11:28 +13:00
Linker.pm Bug 7284: Fix unit test broken by erroneous POD 2012-03-08 15:24:18 +01:00
Log.pm Bug 7941 : Module versions bumped pre release 2012-06-14 19:19:50 +12:00
Maintainance.pm Bug 7941 : Module versions bumped pre release 2012-06-14 19:19:50 +12:00
Matcher.pm Bug 7941 : Module versions bumped pre release 2012-06-14 19:19:50 +12:00
Members.pm Bug 8017 reduce manipulation of GetAllIssues return 2012-09-16 07:14:04 +12:00
Message.pm Bug 4330 : Adding copyright headers and fixing FSF addresses 2012-05-29 16:52:19 +12:00
NewsChannels.pm Bug 7941 : Module versions bumped pre release 2012-06-14 19:19:50 +12:00
Output.pm Bug 7941 : Module versions bumped pre release 2012-06-14 19:19:50 +12:00
Overdues.pm Bug 8939 : Fines being charged during the grace period 2012-10-27 14:30:46 +13:00
Patroncards.pm Bug 8315 - remove use C4::* version 2012-07-14 10:26:07 +12:00
Print.pm Bug 7941 : Module versions bumped pre release 2012-06-14 19:19:50 +12:00
Ratings.pm Bug 7941 : Module versions bumped pre release 2012-06-14 19:19:50 +12:00
Record.pm Bug 7941 : Module versions bumped pre release 2012-06-14 19:19:50 +12:00
Reports.pm Bug 7941 : Module versions bumped pre release 2012-06-14 19:19:50 +12:00
Reserves.pm Bug 8700 - RESERVESLIP fields not being replaced correctly 2012-10-11 10:32:37 +13:00
Review.pm Bug 7941 : Module versions bumped pre release 2012-06-14 19:19:50 +12:00
Ris.pm Bug 7941 : Module versions bumped pre release 2012-06-14 19:19:50 +12:00
RotatingCollections.pm Bug 7941 : Module versions bumped pre release 2012-06-14 19:19:50 +12:00
SMS.pm Bug 7941 : Module versions bumped pre release 2012-06-14 19:19:50 +12:00
SQLHelper.pm Bug 7941 : Module versions bumped pre release 2012-06-14 19:19:50 +12:00
Scheduler.pm Bug 7941 : Module versions bumped pre release 2012-06-14 19:19:50 +12:00
Scrubber.pm Bug 7941 : Module versions bumped pre release 2012-06-14 19:19:50 +12:00
Search.pm Bug 8996: In result page items with negative notforloan are available 2012-11-11 19:00:07 +13:00
Serials.pm Bug 6655 - Sorting order of serial issues in OPAC 2012-08-03 09:24:48 +12:00
Service.pm POD Cleanups 2010-06-09 08:38:59 -04:00
ShelfBrowser.pm Bug 7941 : Module versions bumped pre release 2012-06-14 19:19:50 +12:00
SocialData.pm bug 7470 follow-up, fix POD doc 2012-03-26 17:53:28 +02:00
Stats.pm Bug 7941 : Module versions bumped pre release 2012-06-14 19:19:50 +12:00
Suggestions.pm Bug 7941 : Module versions bumped pre release 2012-06-14 19:19:50 +12:00
TTParser.pm Bug 5327 : Follow up for TTParser test 2012-07-07 11:35:47 +12:00
Tags.pm Bug 7642: Fixing typo 2012-10-02 11:26:19 +13:00
Templates.pm Stop unnecessary warnings in get_language 2012-04-04 18:33:11 +02:00
TmplToken.pm Bug 7941 : Module versions bumped pre release 2012-06-14 19:19:50 +12:00
TmplTokenType.pm Bug 7941 : Module versions bumped pre release 2012-06-14 19:19:50 +12:00
UploadedFile.pm Bug 7941 : Module versions bumped pre release 2012-06-14 19:19:50 +12:00
Utils.pm Bug 7941 : Module versions bumped pre release 2012-06-14 19:19:50 +12:00
VirtualShelves.pm 7805 Followup for perlcritic messages 2012-11-08 16:09:40 +13:00
XISBN.pm Bug 7941 : Module versions bumped pre release 2012-06-14 19:19:50 +12:00
XSLT.pm Bug 6886 - OPAC XSLT respecting single branch mode 2012-09-06 11:14:41 +12:00
Z3950.pm Bug 7941 : Module versions bumped pre release 2012-06-14 19:19:50 +12:00