Koha-clms/C4
Colin Campbell c82169bc32 Bug 4305 Improve code flow
Use the ISBN Object's method to format the string
rather than add extra code to do it
Clean up the code flow for clarity
Benchmarking shows its a bit faster too
Don't add to the number of Test::Perl::Critic warnings
 for no benefit

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit c95b5153e0)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2010-11-11 19:48:15 -05:00
..
AuthoritiesMarc Bug 5385: POD Cleanups (part 1) 2010-11-11 19:48:14 -05:00
Barcodes Bug 5385: POD Cleanups (part 1) 2010-11-11 19:48:14 -05:00
Cache Bug 5385: POD Cleanups (part 1) 2010-11-11 19:48:14 -05:00
ClassSortRoutine replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Creators Bug 5385: POD Cleanups (part 1) 2010-11-11 19:48:14 -05:00
External Bug 5385: POD Cleanups (part 1) 2010-11-11 19:48:14 -05:00
Form Bug 4254 - adding new patron advanced notice doesn't save 2010-11-04 20:17:11 -04:00
Heading Bug 5385: POD Cleanups (part 1) 2010-11-11 19:48:14 -05:00
ILSDI Bug 5385: POD Cleanups (part 1) 2010-11-11 19:48:14 -05:00
Installer Bug 4305 Get Amazon book covers for ISBN13 2010-10-06 06:18:48 -04:00
Labels fixing various links to point to *.koha-community.org 2010-10-21 22:08:24 -04:00
Members Bug 5385: POD Cleanups (part 1) 2010-11-11 19:48:14 -05:00
Output
…
Patroncards fixing various links to point to *.koha-community.org 2010-10-21 22:08:24 -04:00
Reports Bug 5385: POD Cleanups (part 1) 2010-11-11 19:48:14 -05:00
SIP Bug 5385: POD Cleanups (part 1) 2010-11-11 19:48:14 -05:00
Search Bug 5385: POD Cleanups (part 1) 2010-11-11 19:48:14 -05:00
VirtualShelves Bug 5385: POD Cleanups (part 1) 2010-11-11 19:48:14 -05:00
tests
…
Accounts.pm fixing various links to point to *.koha-community.org 2010-10-21 22:08:24 -04:00
Acquisition.pm remove a bunch of unconditional debug warns 2010-07-02 10:57:08 -04:00
Auth.pm bug 3756: start removing references to disused sysprefs 2010-10-21 20:35:35 -04:00
Auth_with_cas.pm
…
Auth_with_ldap.pm
…
AuthoritiesMarc.pm bug 5243: avoid crash when saving authority records on certain setups 2010-11-02 20:17:13 -04:00
BackgroundJob.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Barcodes.pm Another batch of POD cleanups 2010-06-09 08:38:56 -04:00
Biblio.pm bug 3902: item class source can now be set during serials receiving 2010-07-02 15:15:12 -04:00
Bookseller.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Boolean.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Branch.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Breeding.pm
…
Budgets.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Cache.pm Bug 5363 - Removing unused module (C4::Cache::FastMemcached) 2010-11-04 19:17:19 -04:00
Calendar.pm Fix for Bug 4991, Overhaul of Calendar interface 2010-11-02 22:11:38 -04:00
Category.pm POD Cleanups 2010-06-09 08:38:59 -04:00
Charset.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Circulation.pm (bug 3536) fix homeorholdingbranch on return 2010-10-21 20:04:30 -04:00
ClassSortRoutine.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
ClassSource.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Context.pm remove old revision history notes from a couple files 2010-06-25 05:18:44 -04:00
Contract.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Creators.pm
…
Csv.pm
…
Dates.pm
…
Debug.pm More POD cleanups 2010-06-09 08:38:58 -04:00
Heading.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
ImportBatch.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Input.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Installer.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
ItemCirculationAlertPreference.pm POD Cleanups 2010-06-09 08:38:59 -04:00
ItemType.pm POD Cleanups 2010-06-09 08:38:59 -04:00
Items.pm bug 3597: DelItemCheck now refuses to delete items in transit for holds 2010-10-21 23:01:34 -04:00
Koha.pm Bug 4305 Improve code flow 2010-11-11 19:48:15 -05:00
Labels.pm
…
Languages.pm bug 4188: move PDF templates for printed purchase orders 2010-07-02 08:49:44 -04:00
Letters.pm Bug 5303 Overdue notices subject is improperly encoded 2010-10-21 19:52:05 -04:00
Log.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Maintainance.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Matcher.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Members.pm Fixing non placeholder sql in UpdateGuarantees 2010-10-06 08:42:01 -04:00
Message.pm POD Cleanups 2010-06-09 08:38:59 -04:00
NewsChannels.pm
…
Output.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Overdues.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Patroncards.pm
…
Print.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Record.pm remove two disused functions 2010-10-21 20:31:51 -04:00
Reports.pm More POD cleanups 2010-06-09 08:38:58 -04:00
Reserves.pm (MT 2985) simplify CanBookBeReserved 2010-11-05 15:08:14 -04:00
Review.pm
…
Ris.pm remove a bunch of unconditional debug warns 2010-07-02 10:57:08 -04:00
RotatingCollections.pm POD Cleanups 2010-06-09 08:38:59 -04:00
SMS.pm More POD cleanups 2010-06-09 08:38:58 -04:00
SQLHelper.pm POD Cleanups 2010-06-09 08:38:59 -04:00
Scheduler.pm POD Cleanups 2010-06-09 08:38:59 -04:00
Scrubber.pm POD Cleanups 2010-06-09 08:38:59 -04:00
Search.pm Bug 3630 Impossible to perform Scan Indexes search 2010-10-06 08:18:17 -04:00
Serials.pm bug 5086: fix setting claim date 2010-10-06 07:45:41 -04:00
Service.pm POD Cleanups 2010-06-09 08:38:59 -04:00
Stats.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Suggestions.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Tags.pm More POD cleanups 2010-06-09 08:38:58 -04:00
UploadedFile.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Utils.pm
…
VirtualShelves.pm removed AddToShelfFromBiblio from C4::VirtualShelves 2010-10-06 10:39:36 -04:00
XISBN.pm More POD cleanups 2010-06-09 08:38:58 -04:00
XSLT.pm Bug 5370: Fix all references to koha.org 2010-11-07 16:20:32 -05:00
Z3950.pm fixing various links to point to *.koha-community.org 2010-10-21 22:08:24 -04:00