Go to file
Alexandre Noel c4cf8d698e Bug 37108: Cash register statistics wizard is wrongly sorting payment by manager_id branchcode
With this patch, it displays now the accountlines branchcode and not the
manager's branchcode.

(cr: Marie-Luce test plan)

Setup - before test

Staff accounts
    - have a superlibrarian account
    - create 2 limited access staff accounts, one by branches:
        e.g.
        - staff 1 - attached to branch A
        - staff 2 - attached to branch B

    Both restricted staff accounts should have the following permissions:

        - (circulate) ,
        - (borrowers),
        - in the patron fines: (manual_invoice), and (remaining_permissions)
        - ***ability to switch login library (loggedinlibrary)

Debit type
    - Add few debit types in your Koha (administration > debit types) to ease transactions search.
        e.g: "printing cost", "new card", "lost item"

        ***Ensure that each debit type is configured to "can be manually invoiced"

Test plan

1.  Login with "staff 1" in the intranet
    --> Koha should connect to branch A
2.  Find a "branch A" patron
3.  Add a manual invoice    (e.g printing -- 2.50$ )
4.  Pay this invoice
5.  Log out of the intranet
6.  Login with "staff2"
    --> Koha should connect to branch B
7.  Find a "branch B" patron
8.  Add a manual invoice with a unique debit type and amount (e.g. lost item - 12.80$ )
9.  Pay this invoice
10. Stay connect with "staff2" account, and switch to "branch A" at the top right corner of the screen
11. Find another "branch A" patron
12. Add a manual invoice with a unique debit type and amount (e.g. new card - 5.00$ )
13. Pay this invoice
14. Log out
15. Login with a "superlibrarian" account
16. Run the "Cash register" statistics wizards for "branch A"
        - Go to (Reports > Statistics wizards > Cash Registers )
        - dates: select the current date

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit cf2fcbda75)
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2024-11-18 18:05:28 +00:00
C4 Bug 37249: Disambiguate itemnumber with USING clause 2024-11-18 17:46:48 +00:00
Koha Bug 37231: (Bug 34940 follow-up) Highlight logged-in library in facets does not work with ES 2024-11-18 18:05:21 +00:00
acqui Bug 37551: (24.05.x) Only delete price when there is already an itemprice 2024-09-17 14:41:05 +00:00
admin Bug 37229: Fix table configuration listings for course reserves 2024-11-18 17:58:05 +00:00
api Bug 29509: Update swagger specification and add permissions to users 2024-08-28 19:58:39 +00:00
authorities Bug 37235: Fix export of single authority record 2024-11-18 17:47:35 +00:00
basket Bug 34478: Add 'op' to sendbasketform 2024-03-01 10:58:53 +01:00
bin
…
bookings Bug 35574: Bookings tab from biblio details should only require manage_bookings permission 2023-12-18 15:21:04 +01:00
catalogue Bug 37244: Facets should not impact library pulldown. 2024-11-18 17:46:17 +00:00
cataloguing Bug 38211: frameworkcode must be set before read 2024-10-23 22:49:20 +00:00
circ Bug 33339: Prevent Formula Injection (CSV Injection) in CSV files 2024-11-07 23:02:54 +00:00
clubs Bug 34478: Manual fix - add op clubs/templates-add-modify 2024-03-01 10:57:55 +01:00
course_reserves Bug 28762: Use Koha::Course in course-details controller 2024-08-28 20:20:33 +00:00
debian Bug 37056: Mount a new intranet_svc api to avoid redirects 2024-11-18 17:42:23 +00:00
docs Bug 37003: (follow-up) Amend 22.11 RMaint 2024-07-18 19:44:01 +00:00
erm Bug 32922: Remove space in shebang 2023-02-20 09:44:06 -03:00
errors Bug 37741: Do not send cookie back from error pages 2024-11-15 20:31:16 +00:00
etc Bug 33563: Add comments for Elasticsearch security config 2024-07-18 19:57:49 +00:00
ill Bug 35106: CSRF fix 2024-04-29 18:53:09 +02:00
installer Bug 37114: Update MARC21 default framework to Update 38 (June 2024) 2024-11-18 17:32:02 +00:00
koha-tmpl Bug 37257: Enable translation of Copy control in OPAC user summary 2024-11-18 17:59:09 +00:00
labels Bug 37206: Removing an item from a label batch should be a CSRF-protected POST operation 2024-11-18 17:41:08 +00:00
lib Bug 35681: Use ::Bootstrap version of FromANSI 2024-05-02 16:47:39 +02:00
members Bug 37892: (QA follow-up) Fix condition in memberentry 2024-11-14 14:51:03 +00:00
misc Bug 36901: Add logging for uncaught exceptions in background job classes 2024-11-18 17:18:00 +00:00
offline_circ Bug 34478: Changes for offline_circ 2024-03-01 10:58:34 +01:00
opac Bug 37057: Restore filtering of unused authorities 2024-11-18 17:20:45 +00:00
patron_lists Bug 34478: Changes for patron_lists/add-modify 2024-03-01 10:57:41 +01:00
patroncards Bug 37614: Printing patron cards from patron lists should be a GET 2024-09-11 16:37:03 +00:00
plugins Bug 30897: Add option to disable automated restart 2024-04-11 16:53:42 +02:00
pos Bug 33478: Apply formatting to RECEIPT 2024-04-26 20:15:44 +02:00
preservation Bug 34030: Add a "print slips" action links to print in batch 2023-10-23 11:33:55 -03:00
recalls Bug 33478: Apply formatting to RECALL_REQUESTER_DET 2024-04-26 20:15:45 +02:00
reports Bug 37108: Cash register statistics wizard is wrongly sorting payment by manager_id branchcode 2024-11-18 18:05:28 +00:00
reserve Bug 37587: (QA follow-up) Tidy reserve/placerequest.pl 2024-10-09 19:34:22 +00:00
reviews Bug 37074: Comment approval and un-approval should be CSRF-protected 2024-07-25 14:08:54 +00:00
rotating_collections Bug 34478: Manual fix - add op - rotating_collections/addItems 2024-03-01 10:57:33 +01:00
serials Bug 33339: Prevent Formula Injection (CSV Injection) in CSV files 2024-11-07 23:02:54 +00:00
services Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
skel
…
suggestion Bug 37246: Use the same dropdown for filtering and editing/adding budgets 2024-11-18 17:52:00 +00:00
svc Bug 37056: Mount a new intranet_svc api to avoid redirects 2024-11-18 17:42:23 +00:00
t Bug 35959: Add missing use statements in tests 2024-11-18 17:44:57 +00:00
tags Bug 34478: Add 'op' to tags/review 2024-03-01 10:58:25 +01:00
tools Bug 33339: Prevent Formula Injection (CSV Injection) in CSV files 2024-11-07 23:02:54 +00:00
virtualshelves Bug 37285: (QA follow-up) Perl Tidy 2024-08-29 15:06:09 +00:00
xt Bug 37490: Add a test to detect when yarn.lock is not updated 2024-11-15 20:43:22 +00:00
.editorconfig Bug 27375: Set YAML file settings in .editorconfig 2021-11-03 15:40:52 +01:00
.eslintrc.json Bug 36400: Centralize {js,ts,vue} formatting config in .prettierrc.js 2024-04-22 08:57:39 +02:00
.gitignore Bug 36546: (QA follow-up) Add bundle spec to .gitignore 2024-04-30 15:55:37 -03:00
.htaccess
…
.mailmap Bug 36943: (follow-up) 24.05.00 - Update .mailmap 2024-05-24 15:36:40 +02:00
.perlcriticrc
…
.perltidyrc Bug 30002: Adjust perltidy 2023-06-08 08:32:42 -03:00
.prettierrc.js Bug 36400: (follow-up) remove option editorconfig from .prettierrc.js 2024-04-22 08:57:40 +02:00
.proverc.dist Bug 19821: Install sample data, ES mappings and Version syspref 2021-10-25 11:27:40 +02:00
.stylelintrc.json Bug 31528: (follow-up) A few additional rules 2022-10-03 08:23:15 -03:00
INSTALL
…
Koha.pm Bug 36822: DBRev 24.05.05.001 2024-11-15 16:12:30 +00:00
LICENSE
…
MANIFEST.SKIP
…
Makefile.PL Bug 36546: Deploy swagger_bundle.json via make 2024-04-30 14:32:10 +02:00
README
…
README.md
…
README.robots
…
about.pl Bug 37509: Check Elasticsearch info for both 'about' and 'sysinfo' tabs 2024-09-06 16:52:55 +00:00
app.psgi Bug 36149: Add userenv middleware to app.psgi 2024-05-14 15:04:37 -03:00
build-resources.PL Bug 32609: Use the current yarn.lock to generate node_modules 2023-02-10 11:07:57 -03:00
changelanguage.pl
…
cpanfile Bug 25159: Add ability to specify a pre-modified version of action log data and store as diff 2024-05-02 16:47:42 +02:00
cypress.config.ts Bug 36012: Extend cypress's requestTimeout value 2024-03-22 15:07:36 +01:00
fix-perl-path.PL
…
gulpfile.js Bug 36730: (Bug 35428 follow-up) po files (sometimes) fail to update 2024-05-07 15:53:44 +02:00
help.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
kohaversion.pl
…
mainpage.pl Bug 30493: (QA follow-up) Fix for the only_my_library case as well 2024-07-18 19:31:50 +00:00
package.json Bug 38164: Revert "Bug 37303: Replace po2json with a JS version" 2024-10-23 22:51:09 +00:00
rewrite-config.PL
…
tsconfig.json Bug 32030: Move cypress to t - fix build_js/watch_js 2022-11-08 09:44:52 -03:00
webpack.config.js Bug 35919: Add record sources admin page 2024-04-26 17:06:04 +02:00
yarn.lock Bug 37303: Update yarn.lock after adding new dependency to packages.json 2024-08-29 16:49:30 +00:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo