Alex Buckley 3bbf638449 Bug 25750: fix fallback to ecost_tax_included/ecost_tax_excluded ... If 'Actual cost' has not been set then it has the value of 0.00 which Perl evaluates to true so this patchset resets it to 0, so the fallback to ecost_tax_included/ecost_tax_excluded happens. Test plan: 1. Add item to acquisition basket (make sure the vendor has: tax rate: 15%, 'List prices: Include tax', 'Invoice prices: Include tax') 2. Set 'Vendor price' = 10 and do not set 'Actual cost' 3. Save order 4. Observe basket.pl shows 'Total tax exc.' has a value of 0.00 and GST column has value of -8.70 5. Jump into the database: select tax_value_on_ordering from aqorders where ordernumber=<ordernumber>; [You can get the ordernumber from clicking on the 'Modify' line the item is listed in] 6. Observe a negative value: -8.70 7. Apply patch and restart plack 8. Add a second item to the basket 9. Set 'Vendor price' = 10 and don't set 'Actual cost' 10. Save order 11. Observe basket.pl shows 'Total tax exc' has value of 8.70 and GST has value of 1.30 12. Repeat step 5 and observe tax_value_on_ordering = 1.30 13. Run t/Prices.t unit test: sudo koha-shell <instancename> prove t/Prices.t Sponsored-by: Horowhenua District Council, NZ Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit 7b66b90fe7)		2020-09-03 15:40:42 +00:00
..
Acquisition	…
Biblio	Bug 25709: Rename systempreference to NotesToHide	2020-07-31 21:14:42 +00:00
Budgets	Bug 21817: Centralize the mock of userenv from tests	2019-01-02 20:18:29 +00:00
Circulation	Bug 24840: Replace DateTime->now with dt_from_string	2020-04-08 11:54:23 +01:00
External	Bug 22010: Check preferences for ebook integration	2019-04-30 11:42:51 +00:00
Koha	Bug 26127: local_referer should not compare with OPACBaseURL case insensitive	2020-09-03 15:23:13 +00:00
LangInstaller/templates	Bug 22007: Generated with add_missing_filters.pl	2019-01-02 20:43:53 +00:00
Members	Bug 21015: Remove unecessary 'use Koha::Schema' statements in t/	2018-11-08 02:18:48 +00:00
Number	Bug 18736: (QA follow-up) Change to signed, add large int test	2019-03-21 16:29:06 +00:00
SIP	…
Search	…
Serials	Bug 24903: Add tests for _handle_seqno	2020-04-14 08:29:11 +01:00
Test	…
db_dependent	Bug 25872: Unit tests	2020-09-03 15:33:11 +00:00
edi_testfiles	…
etc	…
lib	Bug 26162: Don't fall into an infinite loop	2020-08-31 20:05:42 +00:00
00-checkdatabase-version.t	…
00-deprecated.t	…
00-load.t	Bug 24823: Drop Catmandu dependency	2020-05-12 11:43:19 +01:00
00-merge-conflict-markers.t	…
00-testcritic.t	Bug 21395: Make perlcritic happy	2020-07-13 16:44:43 +00:00
00-valid-xml.t	Bug 24494: Make the regex more exact	2020-02-19 11:30:45 +00:00
Auth.t	Bug 22943: Remove unused line from Auth.t	2020-03-16 11:00:37 +00:00
AuthUtils.t	…
Auth_with_shibboleth.t	Bug 23042: Correct shib param escaping	2019-11-27 11:30:20 +00:00
AuthoritiesMarc_MARC21.t	…
AuthoritiesMarc_UNIMARC.t	…
Barcodes_EAN13.t	…
Barcodes_annual.t	…
Barcodes_hbyymmincr.t	…
Barcodes_incremental.t	…
Biblio.t	Bug 26133: Remove GetMarcHosts	2020-08-13 18:06:47 +00:00
Biblio2.t	Bug 11529: (follow-up) Fix QA issues	2019-08-05 15:03:19 +01:00
Boolean.t	…
Budgets.t	…
Calendar.t	Bug 25723: (QA follow-up) Handle holiday and exception on same day	2020-07-27 17:40:25 +00:00
Charset.t	…
Circulation_barcodedecode.t	Bug 21817: Centralize the mock of userenv from tests	2019-01-02 20:18:29 +00:00
ClassSortRoutine.t	…
ClassSortRoutine_Dewey.t	…
ClassSortRoutine_Generic.t	…
ClassSortRoutine_LCC.t	…
ClassSource.t	…
Context.t	Bug 25360: Use secure flag for CGISESSID cookie when using HTTPS	2020-08-31 20:05:05 +00:00
Contract.t	…
Creators.t	…
DateUtils.t	Bug 25617: (QA follow-up) Add responses to tests	2020-05-29 11:30:02 +02:00
Debug.t	…
EdiInvoice.t	…
EdiTransport.t	Bug 20254: Add tests for transport ingest	2019-08-20 15:04:26 +01:00
Edifact.t	Bug 21580: Add test for message buyer_ean method	2019-10-10 08:23:04 +01:00
Ediorder.t	Bug 23926: Limit GIR segment to 5 pieces of info	2020-03-10 15:18:22 +00:00
Ediordrsp.t	…
Form_MessagingPreferences.t	…
HtmlTags.t	…
Images.t	…
ImportBatch.t	…
Installer_PerlModules.t	Bug 19735: Move Perl deps definitions into a cpanfile	2020-02-12 16:33:02 +00:00
Installer_pm.t	Bug 19735: Move Perl deps definitions into a cpanfile	2020-02-12 16:33:02 +00:00
ItemCirculationAlertPreference.t	…
Koha.t	Bug 23768: Adjust the test for invalid ISBN	2019-11-07 13:02:59 +00:00
Koha_Email.t	…
Koha_MetadataRecord.t	…
Koha_SearchEngine_Elasticsearch_Browse.t	Bug 24545: Fix newly added files	2020-02-24 13:31:27 +00:00
Koha_Template_Plugin_Cache.t	…
Koha_Template_Plugin_Koha.t	Bug 20415: add Koha.ArePluginsEnabled Template Toolkit method	2020-03-26 11:41:54 +00:00
Koha_Util_FrameworkPlugin.t	…
Koha_Util_MARC.t	…
Labels.t	Bug 15836: Add the ability to defined custom methods to split call number in labels	2018-11-13 15:18:22 +00:00
Labels_split_Regex.t	Bug 15836: Add the ability to defined custom methods to split call number in labels	2018-11-13 15:18:22 +00:00
Labels_split_ccn.t	Bug 15836: Fix failing tests	2018-11-13 18:53:10 +00:00
Labels_split_ddcn.t	Bug 15836: Add the ability to defined custom methods to split call number in labels	2018-11-13 15:18:22 +00:00
Labels_split_lccn.t	Bug 15836: Add the ability to defined custom methods to split call number in labels	2018-11-13 15:18:22 +00:00
LangInstaller.t	Bug 21895: Fix translation for package install	2018-11-29 17:57:54 +00:00
Languages.t	Bug 21395: Make perlcritic happy	2020-07-13 16:44:43 +00:00
Letters.t	…
Logger.t	Bug 25172: Adjust tests	2020-04-22 13:44:06 +01:00
Makefile.t	Bug 21395: Ignore .perlcriticrc in t/Makefile.t	2020-07-13 17:13:00 +00:00
Matcher.t	Bug 23324: Add an ISBN normalization routine	2019-08-16 12:26:48 +01:00
Members_Messaging.t	…
OpenLibrarySearch.t	…
Output.t	Bug 24369: Add CORS support to output_with_http_headers()	2020-03-05 12:59:44 +00:00
Output_JSONStream.t	…
Patron.t	Bug 14570: Make it possible to add multiple guarantors to a record	2019-08-20 16:04:48 +01:00
Patroncards.t	…
Patroncards_Batch.t	…
Patroncards_Lib.t	…
Patroncards_Patroncard.t	…
Patroncards_Profile.t	…
Patroncards_Template.t	…
Prices.t	Bug 25750: fix fallback to ecost_tax_included/ecost_tax_excluded	2020-09-03 15:40:42 +00:00
RecordProcessor.t	Bug 25008: Tests for ->options	2020-04-14 08:31:22 +01:00
Ris.t	…
SMS.t	…
Scheduler.t	…
Scrubber.t	…
Search.t	…
Search_PazPar2.t	…
SimpleMARC.t	Bug 17510: update MMT-related unit tests	2020-02-21 16:01:28 +00:00
SocialData.t	…
Stats.t	…
SuggestionEngine.t	Bug 21395: Make perlcritic happy	2020-07-13 16:44:43 +00:00
SuggestionEngine_AuthorityFile.t	…
TmplToken.t	…
Token.t	Bug 17845: (RM follow-up) Restore a removed test	2020-03-10 18:49:37 +00:00
XSLT.t	…
dummy.t	Bug 21395: Make perlcritic happy	2020-07-13 16:44:43 +00:00
template_filters.t	Bug 22466: Add tests	2019-03-07 18:17:32 +00:00
timezones.t	Bug 18674: TZ error handling	2018-04-11 16:45:08 -03:00