gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Koha-clms/members
History
Blou c2df905bfe
Bug 17140: fix rounding errors when paying fines 
Whenever a fine (accountlines in DB) has a precision longer than two floating points, it becomes very hard for a user to clear it.
Ex: 1.035 will be displayed as 1.04 or 1.03 depending on the screen.  But entering any of those value in Pay Fine will not clear it.
The user has no way to know the exact value to enter.

This fix makes sure that the intent of the user is met, by matching the EXACT needed sum when the difference is less than 0.01.

TEST
1) Create a 1.035 fine
  - Go to a Patron screen
  - Fines tab on the left
  - Create manual invoice
2) go to Pay fines, click Pay amount on bottom left.
3) It will show 1.03 as Total, and as Collect from patron.  Click confirm.
4) An error message will appear.
5) Apply patch, do again.

Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
 		2019-10-11 10:52:35 +01:00
..
accountline-details.pl Bug 20666: Correct executable permissions 2018-05-03 13:26:48 -03:00
apikeys.pl Bug 21993: Display a user-friendly message when the CSRF token is wrong 2019-01-25 20:38:32 +00:00
boraccount.pl Bug 23507: Add ability to show change given on auto-popup fee receipt from FinePaymentAutoPopup 2019-10-08 14:47:39 +01:00
default_messageprefs.pl Bug 18403: Update permissions - borrowers => 1|* becomes borrowers => 'edit_borrowers' 2018-02-12 15:41:37 -03:00
deletemem.pl Bug 14570: Make it possible to add multiple guarantors to a record 2019-08-20 16:04:48 +01:00
discharge.pl Bug 23723: using exit inside eval to stop sending output to browser doesn't work under plack 2019-10-07 12:21:30 +01:00
discharges.pl Bug 18403: Patron discharges 2018-02-12 15:41:41 -03:00
files.pl Bug 12159: Fix getting extended patron attributes for circ-menu 2019-03-28 13:05:22 +00:00
guarantor_search.pl Bug 18403: Update permissions - borrowers => 1|* becomes borrowers => 'edit_borrowers' 2018-02-12 15:41:37 -03:00
holdshistory.pl Bug 20226: Centralize update child code (CATCODE_MULTI) 2018-08-14 11:58:26 +00:00
housebound.pl Bug 12159: Fix getting extended patron attributes for circ-menu 2019-03-28 13:05:22 +00:00
ill-requests.pl Bug 18589: (follow-up) Remove redundant-ness 2019-03-22 20:21:47 +00:00
mancredit.pl Bug 22600: Add 'interface' to accountlines 2019-04-10 19:43:11 +00:00
maninvoice.pl Bug 12159: Fix getting extended patron attributes for circ-menu 2019-03-28 13:05:22 +00:00
member-flags.pl Bug 23321: Add cash register permission 2019-09-23 11:39:21 +01:00
member-password.pl Bug 12159: Fix getting extended patron attributes for circ-menu 2019-03-28 13:05:22 +00:00
member.pl Bug 20998: Simplify the conditional statement 2018-06-29 19:05:57 +00:00
memberentry.pl Bug 14570: Remove wrong parameter in add_guarantor call 2019-08-20 16:06:06 +01:00
members-home.pl Bug 23697: (QA follow-up) Rename PatronAutocompletion to PatronAutoComplete 2019-10-08 14:51:12 +01:00
members-update-do.pl Bug 20287: Move ModMember to Koha::Patron 2018-07-18 15:49:50 +00:00
members-update.pl Bug 18403: Update permissions - borrowers => 1|* becomes borrowers => 'edit_borrowers' 2018-02-12 15:41:37 -03:00
merge-patrons.pl Bug 9302: Add error message if keeper patron is invalid 2018-04-20 13:34:41 -03:00
mod_debarment.pl Bug 18403: Fix few errors found with hit_pages.t 2018-02-12 15:41:43 -03:00
moremember.pl Bug 14570: Make it possible to add multiple guarantors to a record 2019-08-20 16:04:48 +01:00
notices.pl Bug 12159: Fix getting extended patron attributes for circ-menu 2019-03-28 13:05:22 +00:00
patronimage.pl Bug 17423 - patronimage.pl permission is too restrictive 2016-10-17 23:44:25 +00:00
pay.pl Bug 17140: fix rounding errors when paying fines 2019-10-11 10:52:35 +01:00
paycollect.pl Bug 17140: fix rounding errors when paying fines 2019-10-11 10:52:35 +01:00
print_overdues.pl Bug 17553: Move GetOverduesForPatron to Koha::Patron->get_overdues 2018-04-03 11:43:06 -03:00
printfeercpt.pl Bug 23507: Add ability to show change given on auto-popup fee receipt from FinePaymentAutoPopup 2019-10-08 14:47:39 +01:00
printinvoice.pl Bug 22809: Move "INVOICE" from template to a slip 2019-05-10 14:39:39 +00:00
printslip.pl Bug 18403: Add sub output_and_exit_if_error - unknown_patron & cannot_see_patron_infos 2018-02-12 15:41:38 -03:00
purchase-suggestions.pl Bug 12159: Fix getting extended patron attributes for circ-menu 2019-03-28 13:05:22 +00:00
readingrec.pl Bug 12159: Fix getting extended patron attributes for circ-menu 2019-03-28 13:05:22 +00:00
routing-lists.pl Bug 12159: Fix getting extended patron attributes for circ-menu 2019-03-28 13:05:22 +00:00
setstatus.pl Bug 18403: Fix few errors found with hit_pages.t 2018-02-12 15:41:43 -03:00
statistics.pl Bug 21027: Fix checkout statistics if 1+ of the fields is not defined 2019-07-15 12:25:15 +01:00
summary-print.pl Bug 21013: Missing itemtype for checkut makes patron summary print explode 2019-04-10 20:09:50 +00:00
update-child.pl Bug 14570: Make it possible to add multiple guarantors to a record 2019-08-20 16:04:48 +01:00