Go to file
Nick Clemens c2be412ade Bug 25273: Make match-heading rely on authority type configuration
The match-heading field is a special field used only by the linker, not accessible
to staff or patrons via the interface. This field is used to store the constructed
'search form' used for matching bib headings to authority fields.

In bug 24269 I attempted to use the mappings defined in the inferface and also inject the search term.
This did not work as too many subfields were indexed on their own and leading to false matches.
In this bug we remove the mappings for this field, and create it ourselves during
the indexing process. The C4::Headings module is still used to generate the correct form,
however, the mappings are set based on the authority types in the system. This gives the user
the ability to add new typoes, but prevents mapping changes from breaking linker functionality

To test:
 1 - Start form a sample database with ElasticSearch working
 2 - Download via Z39.50 2 authorities, one of which is a narrower heading of the other, e.g.:
    Waterworks
    Waterworks - Costs
 3 - Place a heading for the broader term in a record. e.g. Waterworks
       In 650$a, without the cataloguing authority plugin. We don't want
       the link created now.
       You need syspref BiblioAddsAuthorities => allow
 4 - Make sure linker is set to default
 5 - Attempt to link the records
       misc/link_bibs_to_authorities.pl
 6 - Linking fails
 7 - Apply patch
 8 - refresh index settings (if using a custom file, remove 'match-heading')
       You can reset mappings in the UI or run this:
       misc/search_tools/rebuild_elasticsearch.pl -v -d -r
 9 - Reindex ES
10 - Try to link again
11 - It succeeds!
12 - Run the tests
     prove t/db_dependent/Koha/SearchEngine/Elasticsearch.t

Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Bug 25273: (follow-up)

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit ce161fda9b)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 5597b666e4)

Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
2020-10-20 13:54:22 +13:00
C4 Bug 25273: Make match-heading rely on authority type configuration 2020-10-20 13:54:22 +13:00
Koha Bug 25273: Make match-heading rely on authority type configuration 2020-10-20 13:54:22 +13:00
OpenILS
…
acqui Bug 25750: fix fallback to ecost_tax_included/ecost_tax_excluded 2020-09-09 16:41:25 +12:00
admin Bug 25273: Make match-heading rely on authority type configuration 2020-10-20 13:54:22 +13:00
api/v1 Bug 26271: Add null to the list of accepted account_line data types 2020-09-15 23:42:39 +12:00
authorities Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
basket Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
catalogue Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
cataloguing Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
circ Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
clubs Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
course_reserves Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
debian Bug 25792: Rename 'ttf-dejavu' package to 'fonts-dejavu' for Debian 11 2020-09-09 22:18:40 +12:00
docs
…
errors
…
etc Bug 26253: (bug 22857 follow-up) Remove duplicated mana_config in etc/koha-conf.xml 2020-09-15 23:57:42 +12:00
ill
…
installer Increment version for 19.11.10 release 2020-09-22 10:54:45 +12:00
koha-tmpl Bug 20783: Add missing url filters 2020-10-12 23:24:16 +00:00
labels Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
members Bug 26076: (QA Follow up) Prevent error by using a fresh resultset 2020-09-09 21:21:57 +12:00
misc Update release notes for 19.11.10 release 2020-09-22 11:11:06 +12:00
offline_circ Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
opac Bug 26388: Do not show 'Renew all' or 'Renew selected' if no renewable items 2020-09-15 23:53:54 +12:00
patron_lists Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
patroncards Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
plugins Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
reports Bug 17801: Use issuedate for limits in Most Circulated Items 2020-09-15 23:48:55 +12:00
reserve Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
reviews Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
rotating_collections Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
serials Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
services
…
skel
…
suggestion
…
svc Bug 26331: Make svc/letters/preview executable 2020-09-15 23:38:28 +12:00
t Bug 25273: Make match-heading rely on authority type configuration 2020-10-20 13:54:22 +13:00
tags Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
tmp/modified_authorities
…
tools Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
virtualshelves Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
xt
…
.editorconfig
…
.eslintrc.json
…
.gitignore
…
.htaccess
…
.mailmap
…
.scss-lint.yml
…
INSTALL
…
Koha.pm Increment version for 19.11.10 release 2020-09-22 10:54:45 +12:00
LICENSE
…
MANIFEST.SKIP
…
Makefile.PL Bug 25792: Rename 'ttf-dejavu' package to 'fonts-dejavu' for Debian 11 2020-09-09 22:18:40 +12:00
README
…
README.md
…
README.robots
…
about.pl Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
changelanguage.pl
…
fix-perl-path.PL
…
gulpfile.js Bug 26228: Update gulpfile to work with Node.js v12 2020-09-09 16:04:42 +12:00
help.pl
…
koha_perl_deps.pl
…
kohaversion.pl
…
mainpage.pl Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
package.json Bug 26228: Update gulpfile to work with Node.js v12 2020-09-09 16:04:42 +12:00
rewrite-config.PL Bug 25792: Rename 'ttf-dejavu' package to 'fonts-dejavu' for Debian 11 2020-09-09 22:18:40 +12:00
yarn.lock Bug 26228: Update gulpfile to work with Node.js v12 2020-09-09 16:04:42 +12:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo