Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests and perlcritic pass. Tests done: holds policy vs. circulation rules seemed to make the difference for me, I am not totally sure why that is, but see no reason to fail this patch as results are ok. System preferences - CircControlBranch = the library the item is from - ReservesControlBranch = patron's home library Circulation rules - Library A - Holds policy: Books can not be put on hold. - Library B - Holds policy: Books can be put on hold. (no special setting needed) Catalog data - A record with an item for library B, itemtype Books. Test without patch: 1) Patron A (home library A) places a hold in OPAC on an item from library B. Should be: hold is NOT allowed. Before patch: hold IS allowed. After patch: hold is NOT allowed. OK 2) ReserveControlbranch = item's home library Patron A (home library A) places a hold in OPAC on an item from library B. Should be: hold is allowed. Before patch: hold is allowed. After patch: hold is allowed. OK 3) ReservesControlBranch = patron's home library Circulation rules: Remove hold policy for library B. Library A: no holds allowed for books using 'Holds allowed (count)' = 0 Library B: 5 holds allowed for books using 'Holds allowed (count)' = 5 Patron A (home library A) places a hold in OPAC on an item from library B. Should be: hold is NOT allowed Before patch: hold is NOT allowed After patch: hold is NOT allowed OK 4) ReserveControlbranch = item's home library Should be: hold is allowed Before patch: hold is allowed After patch: hold is allowed OK Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> |
||
|---|---|---|
| C4 | ||
| Koha | ||
| acqui | ||
| admin | ||
| authorities | ||
| basket | ||
| catalogue | ||
| cataloguing | ||
| circ | ||
| debian | ||
| docs | ||
| errors | ||
| etc | ||
| install_misc | ||
| installer | ||
| koha-tmpl | ||
| labels | ||
| members | ||
| misc | ||
| offline_circ | ||
| opac | ||
| patroncards | ||
| reports | ||
| reserve | ||
| reviews | ||
| rotating_collections | ||
| selenium | ||
| serials | ||
| services | ||
| skel | ||
| sms | ||
| suggestion | ||
| svc | ||
| t | ||
| tags | ||
| test | ||
| tmp/modified_authorities | ||
| tools | ||
| virtualshelves | ||
| xt | ||
| .htaccess | ||
| .mailmap | ||
| INSTALL | ||
| INSTALL.debian | ||
| INSTALL.fedora7 | ||
| INSTALL.opensuse | ||
| INSTALL.ubuntu | ||
| INSTALL.ubuntu.12.04 | ||
| INSTALL.ubuntu.lucid | ||
| LICENSE | ||
| MANIFEST.SKIP | ||
| Makefile.PL | ||
| README | ||
| README.robots | ||
| about.pl | ||
| changelanguage.pl | ||
| edithelp.pl | ||
| fix-perl-path.PL | ||
| help.pl | ||
| install-CPAN.pl | ||
| koha_perl_deps.pl | ||
| kohaversion.pl | ||
| mainpage.pl | ||
| rewrite-config.PL | ||
README
Koha is a free software integrated library system. Koha is distributed under the GNU GPL version 2 or later. Please read the file LICENSE for more details. To install or upgrade Koha, please see the INSTALL file appropriate to your platform. Report bugs at http://bugs.koha-community.org/ Visit the Koha Project website at http://www.koha-community.org/