Go to file
Aleisha Amohia be375ed01c
Bug 34722: Prevent other items from displaying to fill item-level recalls
This patch prevents other items attached to a record from being displayed as 'recalled' by item-level recalls.

To test:
1. Ensure UseRecalls system preference is enabled and circulation rules relevant to recalls are configured. Set 'on shelf recalls allowed' circulation rule 'if any unavailable' for ease of testing.
2. Search for a record that has multiple items, or create one with multiple items. Check out two of the items (Item A and Item B) to a patron, Patron A.
3. Log into the OPAC as another patron, Patron B. Search for the record and place a recall. Choose to recall a specific item and select Item A.
4. Go back to the staff interface and view the catalogue detail page for the record. Notice that every item has a 'recalled by...' message, even though Item A was specifically recalled.
5. Log into the OPAC as another patron, Patron C. Search for the record and place a recall. Choose to recall a specific item, notice every item has a 'recalled by...' message. Select Item B and Confirm.
6. In your terminal, the 'Other items are not returned for item-level recalls' test should fail when running
prove t/db_dependent/Koha/Item.t

7. Apply the patch and restart services

8. Confirm tests at t/db_dependent/Koha/Item.t now pass
9. Refresh the staff interface, confirm only Items A and B have the recalled message and the recall patron information for each item is accurate
10. Log into the OPAC as another patron, Patron D. Search for the record and place a recall. Choose to recall a specific item. Confirm only Items A and B have the recalled message.

Sponsored-by: Toi Ohomai Institute of Technology
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Perltidied new code.
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2023-10-04 16:40:17 -04:00
C4 Bug 9525: (QA follow-up) Tidy 2023-10-04 16:40:12 -04:00
Koha Bug 34722: Prevent other items from displaying to fill item-level recalls 2023-10-04 16:40:17 -04:00
acqui Bug 34645: (follow-up) save sort1 and sort2 in order 2023-10-04 09:15:36 -04:00
admin Bug 34300: Add holds column to order table 2023-10-04 16:40:14 -04:00
api Bug 33690: Convert to x-koha-override 2023-10-04 11:07:56 -04:00
authorities Bug 33406: (QA follow-up) Adjust tests and tidy 2023-09-15 15:50:43 -03:00
basket Bug 34731: Don't call SendQueuedMessages if message_id is bad 2023-09-12 09:44:59 -03:00
bin
…
catalogue Bug 34441: Fixed Typo "Paramater" 2023-09-01 11:23:21 -03:00
cataloguing Bug 34689: Ignore itemnumber when creating item hash 2023-10-04 09:15:37 -04:00
circ Bug 9525: (QA follow-up) Tidy 2023-10-04 16:40:12 -04:00
clubs Bug 25079: Show club enrollment question answers in staff client 2023-06-23 11:00:54 -03:00
course_reserves Bug 20256: Use new methods 2023-02-02 11:59:26 -03:00
debian Bug 34653: Make koha-foreach return the correct status code 2023-09-25 10:56:40 -03:00
docs Bug 33899: Add the 23.11 release team 2023-06-09 08:28:57 -03:00
erm Bug 32922: Remove space in shebang 2023-02-20 09:44:06 -03:00
errors
…
etc Bug 30843: Add mfa_range configuration option for TOTP 2023-09-25 10:53:51 -03:00
ill Bug 33716: (QA follow-up) Fix submission when cardnumber is invalid 2023-09-19 16:34:37 -03:00
installer Bug 9525: DBRev 23.06.00.028 2023-10-04 16:40:14 -04:00
koha-tmpl Bug 34923: Allow direct input of hold dates on opac-reserve.tt 2023-10-04 16:40:16 -04:00
labels Bug 31633: (follow-up) Group template params 2022-10-03 14:09:59 -03:00
lib/CGI/Session/Serialize
…
members Bug 34870: Perform UTF8 encoding before redirection 2023-10-04 11:08:27 -04:00
misc Bug 33522: (follow-up) Do not rely on fallback 2023-10-04 11:07:51 -04:00
offline_circ Bug 32496: Reduce unnecessary unblessings of objects in Circulation.pm 2023-09-22 10:52:39 -03:00
opac Bug 33074: Take ReservesControlBranch into account in opac-reserve.pl 2023-10-03 08:51:12 -04:00
patron_lists
…
patroncards
…
plugins Bug 30367: (follow-up) Same adjustment for gitlab 2023-05-05 10:18:57 -03:00
pos Bug 34731: Don't call SendQueuedMessages if message_id is bad 2023-09-12 09:44:59 -03:00
recalls Bug 34013: Recalls awaiting pickup doesn't show count on each tab 2023-06-23 10:01:04 -03:00
reports Bug 34859: Remove unnecessary params from reports-home.pl 2023-10-04 16:40:16 -04:00
reserve Bug 32496: Reduce unnecessary unblessings of objects in Circulation.pm 2023-09-22 10:52:39 -03:00
reviews
…
rotating_collections
…
serials Bug 34199: Add full title information to subscription detail page 2023-09-22 11:35:46 -03:00
services
…
skel
…
suggestion Bug 34601: Fix edit/delete links on suggestion.tt 2023-08-29 14:37:10 -03:00
svc Bug 34369: Require CSRF token for updating system preferences 2023-09-25 18:18:40 -03:00
t Bug 34722: Prevent other items from displaying to fill item-level recalls 2023-10-04 16:40:17 -04:00
tags
…
tools Bug 34820: (QA follow-up) add filter, update CSV output 2023-10-04 09:44:04 -04:00
virtualshelves Bug 34731: Don't call SendQueuedMessages if message_id is bad 2023-09-12 09:44:59 -03:00
xt Bug 34911: Test files from HEAD instead of 'master' 2023-10-04 09:15:35 -04:00
.editorconfig
…
.eslintrc.json
…
.gitignore Bug 33710: Ignore how-to related files 2023-05-12 17:50:01 -03:00
.htaccess
…
.mailmap Update .mailmap 2023-06-12 11:52:05 -03:00
.perlcriticrc
…
.perltidyrc Bug 30002: Adjust perltidy 2023-06-08 08:32:42 -03:00
.proverc.dist
…
.stylelintrc.json
…
INSTALL
…
Koha.pm Bug 9525: DBRev 23.06.00.028 2023-10-04 16:40:14 -04:00
LICENSE
…
MANIFEST.SKIP
…
Makefile.PL Bug 34319: Remove cypress.json from Makefile.PL 2023-09-06 09:57:01 -03:00
README
…
README.md
…
README.robots
…
about.pl Bug 27634: Add a warning to the about page if PatronSelfRegistrationDefaultCategory not set 2023-09-19 16:34:19 -03:00
app.psgi
…
build-resources.PL Bug 32609: Use the current yarn.lock to generate node_modules 2023-02-10 11:07:57 -03:00
changelanguage.pl
…
cpanfile Bug 34414: Remove DBD::Mock 2023-09-15 11:57:08 -03:00
cypress.config.ts Bug 34319: Upgrade cypress 9.7.0 to 12.17.2 2023-09-05 11:52:25 -03:00
fix-perl-path.PL
…
gulpfile.js Bug 32978: Replace node-sass with dart-sass 2023-02-22 10:03:39 -03:00
help.pl
…
koha_perl_deps.pl
…
kohaversion.pl
…
mainpage.pl Bug 33133: Add fast cataloging to 'Cataloging' page 2023-03-27 12:50:07 +02:00
package.json Bug 34319: Upgrade cypress 9.7.0 to 12.17.2 2023-09-05 11:52:25 -03:00
rewrite-config.PL
…
tsconfig.json Bug 32030: Move cypress to t - fix build_js/watch_js 2022-11-08 09:44:52 -03:00
webpack.config.js Bug 32806: Move main-erm.ts to modules/erm.ts 2023-02-27 11:12:01 -03:00
yarn.lock Bug 34319: Update yarn.lock 2023-09-05 11:52:25 -03:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo