Koha-clms/members
Jonathan Druart f0c60dfe6f Bug 22868: Move suggestions_manage subperm out of acquisition perm
Bug 11911 replaced the permission of suggestions.pl (create a purchase
suggestion) from catalogue => 1 to acquisition => 'suggestions_manage'.
However we have a lot of acquisition scripts that have lax permissions
(acquisition => '*' which means any sub permissions of acquisition is
enough).

That causes problem when a circulation staff can create purchase
suggestions but not access acquisition information.

One solution is to move the suggestions_manage subpermission out of the
acquisition permission and create a new suggestion permission.

Test plan:
0. Setup
* Create a patron with several permission (and full acquisition
permission)
* Create another patron with several permission, and suggestions_manage
permission
* Create another patron without the suggestions_manage permission
1. Apply the patch and execute the update database entry
2. Note that the third patron you create still does not have
suggestions_manage
3. Confirm that you can create a purchase suggestion if you have
suggestions_manage, but cannot access acquisition pages if you do not
have any subpermissions of the acquisition permission

Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
(cherry picked from commit 462db68024)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2020-02-14 20:19:59 +00:00
..
accountline-details.pl Bug 20666: Correct executable permissions 2018-05-03 13:26:48 -03:00
apikeys.pl Bug 21993: Display a user-friendly message when the CSRF token is wrong 2019-01-25 20:38:32 +00:00
boraccount.pl Bug 12159: Fix getting extended patron attributes for circ-menu 2019-03-28 13:05:22 +00:00
default_messageprefs.pl Bug 18403: Update permissions - borrowers => 1|* becomes borrowers => 'edit_borrowers' 2018-02-12 15:41:37 -03:00
deletemem.pl Bug 23822: Fix deletion of patrons with credit 2019-11-18 09:29:37 +01:00
discharge.pl Bug 23723: using exit inside eval to stop sending output to browser doesn't work under plack 2019-11-08 15:23:58 +01:00
discharges.pl Bug 18403: Patron discharges 2018-02-12 15:41:41 -03:00
files.pl Bug 12159: Fix getting extended patron attributes for circ-menu 2019-03-28 13:05:22 +00:00
guarantor_search.pl Bug 18403: Update permissions - borrowers => 1|* becomes borrowers => 'edit_borrowers' 2018-02-12 15:41:37 -03:00
holdshistory.pl Bug 21939: Fix permissions for holds history tab 2019-12-12 22:48:26 +00:00
housebound.pl Bug 12159: Fix getting extended patron attributes for circ-menu 2019-03-28 13:05:22 +00:00
ill-requests.pl Bug 18589: (follow-up) Remove redundant-ness 2019-03-22 20:21:47 +00:00
mancredit.pl Bug 22600: Add 'interface' to accountlines 2019-04-10 19:43:11 +00:00
maninvoice.pl Bug 12159: Fix getting extended patron attributes for circ-menu 2019-03-28 13:05:22 +00:00
member-flags.pl Bug 12159: Fix getting extended patron attributes for circ-menu 2019-03-28 13:05:22 +00:00
member-password.pl Bug 12159: Fix getting extended patron attributes for circ-menu 2019-03-28 13:05:22 +00:00
member.pl Bug 20998: Simplify the conditional statement 2018-06-29 19:05:57 +00:00
memberentry.pl Bug 23199: Koha::Patron->store must check 'uppercasesurname' syspref 2019-07-25 15:50:02 +02:00
members-home.pl Bug 18403: Update permissions - borrowers => 1|* becomes borrowers => 'edit_borrowers' 2018-02-12 15:41:37 -03:00
members-update-do.pl Bug 20287: Move ModMember to Koha::Patron 2018-07-18 15:49:50 +00:00
members-update.pl Bug 18403: Update permissions - borrowers => 1|* becomes borrowers => 'edit_borrowers' 2018-02-12 15:41:37 -03:00
merge-patrons.pl Bug 9302: Add error message if keeper patron is invalid 2018-04-20 13:34:41 -03:00
mod_debarment.pl Bug 18403: Fix few errors found with hit_pages.t 2018-02-12 15:41:43 -03:00
moremember.pl Bug 21312: Show lockout on Patrons form 2019-05-10 18:01:36 +00:00
notices.pl Bug 12159: Fix getting extended patron attributes for circ-menu 2019-03-28 13:05:22 +00:00
patronimage.pl Bug 17423 - patronimage.pl permission is too restrictive 2016-10-17 23:44:25 +00:00
pay.pl Bug 17140: Make rounding syspref controlled 2019-11-08 16:32:02 +01:00
paycollect.pl Bug 17140: Make rounding syspref controlled 2019-11-08 16:32:02 +01:00
print_overdues.pl Bug 17553: Move GetOverduesForPatron to Koha::Patron->get_overdues 2018-04-03 11:43:06 -03:00
printfeercpt.pl Bug 22761: Add ability to use print version of ACCOUNT_CREDIT slip 2019-05-10 14:11:32 +00:00
printinvoice.pl Bug 22809: Move "INVOICE" from template to a slip 2019-05-10 14:39:39 +00:00
printslip.pl Bug 18403: Add sub output_and_exit_if_error - unknown_patron & cannot_see_patron_infos 2018-02-12 15:41:38 -03:00
purchase-suggestions.pl Bug 22868: Move suggestions_manage subperm out of acquisition perm 2020-02-14 20:19:59 +00:00
readingrec.pl Bug 12159: Fix getting extended patron attributes for circ-menu 2019-03-28 13:05:22 +00:00
routing-lists.pl Bug 12159: Fix getting extended patron attributes for circ-menu 2019-03-28 13:05:22 +00:00
setstatus.pl Bug 18403: Fix few errors found with hit_pages.t 2018-02-12 15:41:43 -03:00
statistics.pl Bug 21027: Fix checkout statistics if 1+ of the fields is not defined 2019-08-06 15:18:35 +02:00
summary-print.pl Bug 21013: Missing itemtype for checkut makes patron summary print explode 2019-04-10 20:09:50 +00:00
update-child.pl Bug 20226: Centralize update child code (CATCODE_MULTI) 2018-08-14 11:58:26 +00:00