gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Koha-clms/t/db_dependent
History
Tomas Cohen Arazi 4b2944a00c Bug 18068: ES - Fix location and (home|holding)branch facets 
This patch makes the 'Locations' facet work as expected (i.e. having the
same behaviour it has for Zebra: picking the 952$c in MARC21 and 995e
for UNIMARC).

It also adds the code to handle holding and home library settings for
facets and makes the facets show the library name instead of the branch
code.

The mappings are updated so the labels match what facets.inc expect to
work properly.

To test:
- On master, do a search that returns biblios with items having
homebranch set.
=> FAIL: Under the 'Locations' label on the facets you will notice
branchcodes are shown.
- Apply the patch
- Restart memcached and plack (just in case, it was tricky)
- Reset your mappings:
  http://localhost:8081/cgi-bin/koha/admin/searchengine/elasticsearch/mappings.pl?op=reset&i_know_what_i_am_doing=1
- Restart memcached and plack (again, not sure if needed)
- Make sure this mappings are set:
  homebranch => HomeLibrary
  holdingbranch => HoldingLibrary
  (Note: it might not be set due to the place the yaml file is being picked)
- Reindex your records:
  $ sudo koha-shell kohadev
 k$ cd kohaclone
 k$ perl misc/search_tools/rebuild_elastic_search.pl -d -v
- Repeat the initial search
=> SUCCESS: 'Location' contains the right stuff, 'Home libraries' and
'Holding libraries' too.
- Run
 k$ prove t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t
=> SUCCESS: Tests pass!
- Sign off :-D

Note: play with the 'DisplayLibraryFacets' syspref options.
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Mason James <mtj@kohaaloha.com>
 		2017-02-23 10:26:47 +13:00
..
Acquisition Revert "Bug 17564: Fix t/db_dependent/Acquisition/OrderUsers.t" 2016-12-31 14:43:38 +13:00
Auth Bug 15756: Some tests for haspermission in C4::Auth 2016-02-23 20:54:42 +00:00
Authorities Bug 17909: QA followup: remove unused var and move global var 2017-01-25 14:59:59 +13:00
Biblio Bug 15572: Add tests for TransformHtmlToMarc 2016-01-25 07:09:50 -07:00
Circulation Bug 8361: Do not allow checkouts if no rules are defined 2017-02-22 21:57:36 +13:00
Creators Bug 18044: Add a test 2017-02-16 07:23:50 +13:00
Exporter Bug 17644 - t/db_dependent/Exporter/Record.t fails 2016-12-12 14:54:12 +13:00
Holds Bug 17574: Remove itemtype-related warnings from LocalHoldsPriority.t 2016-12-12 14:54:09 +13:00
Items Bug 16607: Remove CPL/MPL from two unit tests 2016-06-24 07:28:45 +02:00
Koha Bug 14637: Followup - Fix number of tests due to rebase 2017-01-25 12:45:32 +13:00
LDAP
…
Labels Bug 14468: (QA followup) remove useless diags 2015-10-27 10:38:15 -03:00
Letters Bug 13215: Fix GetLetterTemplates should return default templates if branchcode is not defined 2014-11-27 11:42:26 -03:00
Members Bug 18009 - IssueSlip.t test fails if launched between 00:00 and 00:59 2017-01-29 00:52:07 +13:00
OAI Bug 16172: fix OAI Server tests broken by bug 15946 2016-03-31 16:51:38 +00:00
Patron Bug 17603: Remove itemtype-related Borrower_Discharge.t warnings 2016-12-12 14:54:09 +13:00
Record Bug 13642 - Add Unit test for C4::Record::marc2dcxml 2016-01-27 06:23:08 +00:00
Reports Bug 12787 [QA Followup] - Retain change to Reports_Guided.t 2016-04-22 00:54:36 +00:00
Reserves Bug 13592: Add an option to charge for any hold placed 2015-12-31 15:59:05 +00:00
SIP Bug 15006: Centralize timeout logic and allow zero client timeout 2016-08-01 11:52:51 +02:00
Search Bug 17323: Column search_history.time cannot be null 2016-12-31 15:19:46 +13:00
Serials Bug 12178: Update serial status to "claimed" when exporting to CSV 2016-08-01 11:49:39 +02:00
Template/Plugin Bug 12787: Reorganise t/db_dependent files 2016-04-22 00:54:35 +00:00
Utils Bug 17375: Search by dateofbirth - Add tests 2016-11-02 17:57:56 +00:00
XSLT_Handler Bug 13262 - Add parameters to XSLT Handler transform method 2015-02-05 15:24:29 -03:00
api/v1 Bug 16271: Allow more filters on /api/v1/holds 2016-08-01 11:11:13 +02:00
data
…
selenium Bug 13691: Add changes for 3.22 2016-08-01 11:41:11 +02:00
www Bug 10171: (QA followup) Make search tests use the right form 2016-05-04 14:14:50 +00:00
00-strict.t
…
Accounts.t Bug 16607: Remove CPL/MPL from two unit tests 2016-06-24 07:28:45 +02:00
Acquisition.t Bug 16934: Add test for ModOrder 2016-08-01 13:31:23 +02:00
AdditionalField.t Bug 10855: Remove additional field values when subscription is removed 2015-10-02 15:10:31 -03:00
Amazon.t Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
AudioAlerts.t Bug 11431: (QA followup) remove diags 2015-11-06 15:08:37 -03:00
Auth.t Bug 16492: Test that no_set_userenv will not set userenv if not exist yet 2016-06-15 08:59:45 +02:00
Auth_with_cas.t Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
Auth_with_ldap.t Bug 17615 - Fix unit tests 2017-01-25 14:53:46 +13:00
AuthorisedValues.t Bug 10363: Use Koha::AuthorisedValue[s] in the admin page 2015-10-19 12:46:27 -03:00
AuthoritiesMarc.t Bug 10985: [UNIMARC] Fix authority summary 2015-04-22 11:54:36 -03:00
BackgroundJob.t Bug 17426: Do not set AutoCommit in tests 2016-10-22 15:10:09 +02:00
Barcodes.t Bug 15878 - Updated unit tests for hbyymmincr barcodes 2016-05-23 17:42:10 +00:00
Barcodes_ValueBuilder.t Bug 15081: (QA followup) Fix issue with Barcodes_ValueBuilder.t 2015-11-04 12:32:57 -03:00
Biblio.t Bug 16431: Use Koha::Cache to cache marc subfield structure 2016-08-01 10:34:57 +02:00
Bookseller.t Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
Branch.t Bug 15629: Fix tests - Koha::Library does not have ->categories but ->get_categories 2016-02-24 03:55:07 +00:00
Breeding.t Bug 12898: (regression test) test terms inside double quotes 2014-09-14 02:02:51 -03:00
Budgets.t Bug 15009 [QA Followup] - Update number of tests run 2016-04-29 13:01:07 +00:00
Category.t Bug 15081: (followup) Make test files using TestBuilder handle their transactions 2015-11-04 12:32:57 -03:00
Charset.t Bug 8218 : Add a maintenance script to sanitize biblio records 2014-11-11 15:38:36 -03:00
Circulation.t Revert "Bug 14598: [QA Follow-up] Small changes" 2016-12-31 14:35:57 +13:00
ClassSource.t Bug 16860: Remove the comment about the warning 2016-08-01 10:50:08 +02:00
ColumnsSettings.t Bug 16177: Fix tests for ColumnsSsettings.t 2016-04-01 19:08:23 +00:00
Context.t Bug 16813: Allow empty string for OPACBaseURL 2016-08-01 13:31:21 +02:00
Contract.t Bug 14693: Contract.t should generate dates based on current date 2015-08-21 10:43:38 -03:00
CourseReserves.t Bug 15530 - Add Unit Test 2016-01-27 00:58:14 +00:00
Csv.t
…
DecreaseLoanHighHolds.t Bug 17573: Remove itemtype-related warnings from DecreaseLoanHighHolds.t 2016-12-12 14:54:09 +13:00
Filter_MARC_ViewPolicy.t Bug 15870: Follow up to address comment #20 2016-03-24 20:15:40 +00:00
Fines.t Bug 13590: Add ability to charge fines at start of charge period 2015-10-22 14:51:24 -03:00
FrameworkPlugin.t Bug 14199: Unify marc orgcode plugins, not overwriting existing values 2016-02-26 14:04:28 +00:00
Heading_MARC21.t
…
Hold.t Bug 16609: Catch warning from Koha::Hold in Hold.t 2016-06-15 09:04:06 +02:00
Holds.t Bug 16717: Improve variable naming 2016-06-24 07:29:30 +02:00
HoldsQueue.t Bug 14514 - LocalHoldsPriority and the HoldsQueue conflict with each other 2016-10-22 14:32:21 +02:00
Holidays.t Bug 16376: (regression tests) 2017-01-03 14:22:37 +13:00
ILSDI_Services.t Bug 16155: (QA followup) fix small bug in t/db_dependent/ILSDI_Services.t 2016-05-04 13:47:58 +00:00
ImportBatch.t Bug 9259: Use is instead of is_deeply 2016-08-01 10:59:55 +02:00
Installer.t Bug 17234: Need to separate KEY and FOREIGN KEY checks 2017-01-25 13:19:12 +13:00
Items.t Bug 17512: Improve handling dates in C4::Items 2017-02-23 09:36:21 +13:00
KitchenSinkPlugin.kpz Bug 17368: Update KitchenSinkPlugin.kpz 2016-10-22 15:12:40 +02:00
Koha.t Bug 16157: Move the selected flag from GetAuthorisedValues to the templates 2016-04-07 00:16:09 +00:00
Koha_Authority.t Bug 15578: Insert authority records before processing tests 2016-01-23 18:28:49 +00:00
Koha_Database.t Bug 13645: Cache the DBIx connection 2015-02-20 14:37:08 -03:00
Koha_Elasticsearch. Bug 17372: Standardize Elasticsearch paths 2016-10-22 13:56:11 +02:00
Koha_Elasticsearch_Indexer.t Bug 17372: Standardize Elasticsearch paths 2016-10-22 13:56:11 +02:00
Koha_Misc_Files.t
…
Koha_SearchEngine_Elasticsearch_Search.t Bug 18068: ES - Fix location and (home|holding)branch facets 2017-02-23 10:26:47 +13:00
Koha_borrower_modifications.t Revert "Bug 17494: Prevent duplicate tokens from getting stored" 2016-12-31 14:44:57 +13:00
Languages.t Bug 16866: Catch warning t/db_dependent/Languages.t 2016-08-01 11:33:45 +02:00
Letters.t Bug 17441: [QA Follow-up] Return value of SendAlerts 2016-10-22 14:55:21 +02:00
Linker_FirstMatch.t Bug 16868: Silence error t/db_dependent/Linker_FirstMatch.t 2016-08-05 09:00:34 +02:00
Log.t Bug 15939: Action logs - Do not default dates to today 2016-03-02 00:53:14 +00:00
MarcModificationTemplates.t Bug 15669: Add a test for GetModificationTemplates 2016-03-03 22:11:44 +00:00
Members.t Bug 16819: Unit tests for C4::Members::DelMember 2016-08-01 11:32:24 +02:00
MungeMarcPrice.t Bug 15084: Replace C4::Budgets::GetCurrencies with Koha::Acquisition::Currencies->search 2016-03-03 20:39:01 +00:00
NewsChannels.t Bug 16550: Clean the tests 2016-05-23 17:37:48 +00:00
Overdues.t Bug 13624 - Remove columns branchcode, categorytype from table overduerules_transport_types 2015-12-31 12:47:16 +00:00
Passwordrecovery.t Bug 18025: Fix test 2017-02-23 10:26:47 +13:00
Patron.t Bug 14577 [QA Followup] 2016-04-29 11:54:23 +00:00
PatronLists.t Bug 16452: Remove the warnings raised by PatronLists.t 2016-05-05 20:44:47 +00:00
Patrons.t Bug 17742: Use TestBuilder to create the library and patron category 2017-01-25 12:47:57 +13:00
Plugins.t Bug 16502: Replace a few other ok-calls by is-calls 2016-06-24 07:25:41 +02:00
QueryParser.t Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
Ratings.t Bug 14878: Tests - Create the branchcodes when needed 2015-11-06 15:51:51 -03:00
Record.t Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
RecordProcessor_EmbedSeeFromHeadings.t Bug 15380: Move Koha::Authority to Koha::MetadataRecord::Authority 2015-12-31 18:50:41 +00:00
Reports.t
…
Reserves.t Bug 14968 - Provides unit test 2016-08-01 10:33:02 +02:00
Review.t Bug 15548: Move new patron related code to Patron* 2016-03-03 14:38:26 -07:00
RotatingCollections.t Bug 15629: Koha::Libraries - Remove ModBranch 2016-02-24 03:55:06 +00:00
Search.t Revert "Bug 17917: [QA Follow-up] Reprove Search.t" 2017-01-27 17:07:56 +13:00
Serials.t Bug 15030: Add tests 2017-02-22 22:11:50 +13:00
Serials_2.t Bug 14878: Tests - Create the branchcodes when needed 2015-11-06 15:51:51 -03:00
Service.t
…
ShelfBrowser.t Bug 14878: Tests - Create the branchcodes when needed 2015-11-06 15:51:51 -03:00
Sitemapper.t Bug 17920: t/db_dependent/Sitemapper.t fails because of permissions 2017-01-25 15:05:56 +13:00
Stats.t Bug 11230 - Refactor C4::Stats::UpdateStats and add UT 2014-07-27 11:29:28 -03:00
SuggestionEngine_ExplodedTerms.t Bug 16869: Silence and catch warnings in t/db_dependent/SuggestionEngine_ExplodedTerms.t 2016-08-01 10:43:57 +02:00
Suggestions.t Bug 16325: Add a test for SearchSuggestions when searching for STATUS='' 2016-05-05 20:46:01 +00:00
Tags.t Bug 12916 - Missing Test to demonstrate warnings. 2014-10-30 00:31:26 -03:00
Templates.t Bug 5338: (QA followup) update the tests for the new reports 2015-05-19 13:54:09 -03:00
TestBuilder.t Bug 17726: [QA Follow-up] Add test descriptions 2017-02-22 21:58:09 +13:00
Upload.t Bug 16501: Remove some unneeded warns in Upload.t 2016-05-16 17:46:25 +00:00
UsageStats.t Bug 16408: Fix UsageStats.t 2016-05-03 15:47:02 +00:00
Virtualshelves.t Bug 14544: [QA Follow-up] Added some test descriptions 2015-11-05 10:00:31 -03:00
XISBN.t Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
XSLT_Handler.t Bug 13262: (QA followup) fix duplicate variable definition 2015-02-05 15:25:50 -03:00
check_sysprefs.t Revert "Bug 17917: [AMENDED] Fix path issue in t/db_dependent/check_sysprefs.t" 2017-01-27 17:07:44 +13:00
db_structure.t Bug 16173: db_structure.t shouldn't have a fixed number of tests 2016-04-01 19:14:53 +00:00
default_search_class.pl Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
rollingloans.t Bug 13315 - Add feedback for last item checked out to circulation.pl 2015-04-13 14:52:26 -03:00
sysprefs.t Bug 11998: Use Koha::Cache to cache sysprefs 2016-03-15 07:08:28 +00:00
zebra_config.pl Bug 15082: t/db_dependent/Search.t shouldn't mock the DB connection 2015-10-29 14:10:23 -03:00