Go to file
Tomas Cohen Arazi bac05d3f37 Bug 29771: Scalar context for split
This patch tackles a very specific scenario. Calling split(...,
CGI::param) makes it be called in list context. The split docs say:

split /PATTERN/,EXPR,LIMIT

this means the first CGI param will be used as EXPR and the second one
as LIMIT, which is wrong anyway. So the fix is to just force scalar
context.

To test:
1. Not sure, just make sure nothing breaks when using the scripts in the
   browser.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit e5dc760b92)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
2022-04-25 19:50:15 +00:00
C4 Bug 30118: (QA follow-up) Fix Perl Critic issues 2022-04-25 18:43:03 +00:00
Koha Bug 30541 - Resolve return claim works but "hangs" if MarkLostItemsAsReturned is set for return claims 2022-04-25 18:26:16 +00:00
acqui Bug 29771: Remove trivial cases 2022-04-25 19:44:44 +00:00
admin Bug 29020: Add link on the mainpage for users without admin access 2022-04-15 18:04:06 +00:00
api Bug 28271: Adjust API spec 2022-02-17 20:30:57 +00:00
authorities Bug 28160: Values from 150$a aren't prefilled in z39.50 search form from an existing authority record 2021-05-10 15:52:53 +02:00
basket Bug 27268: (QA follow-up) Add Koha::Biblios to basket scripts 2021-03-09 17:20:47 +01:00
bin Bug 20582: Turn Koha into a Mojolicious application 2020-10-06 12:00:04 +02:00
catalogue Bug 29785: Rename Koha::Object->message with ->object_messages 2022-02-21 16:35:20 +00:00
cataloguing Bug 29511: Sort hash keys 2022-02-21 15:22:39 +00:00
circ Bug 29771: Scalar context for split 2022-04-25 19:50:15 +00:00
clubs Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
course_reserves Bug 25898: Fix new occurrences 2020-10-15 13:56:41 +02:00
debian Bug 30084: Remove explicit dependency of liblocale-codes-perl 2022-03-20 14:48:51 +00:00
docs Bug 28904: Fix typo and display 2021-11-05 11:59:36 -04:00
errors Bug 26048: Use ErrorDocument middleware for Plack HTTP errors 2021-01-27 10:30:43 +01:00
etc Bug 18540: (QA follow-up) Only mention index_sort_title if defined 2022-02-11 18:50:53 +00:00
ill Bug 22818: Add generation and sending of notices 2020-11-11 08:35:10 +01:00
installer Increment version for 21.05.13 release 2022-03-24 18:44:58 +00:00
koha-tmpl Bug 30583: Fix hold system for translated templates 2022-04-25 19:34:37 +00:00
labels Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
lib/CGI/Session/Serialize Bug 28519: Put CGI::Session::Serialize::yamlxs in lib directory 2021-06-18 11:23:42 -04:00
members Bug 29758: Get rid of warning in members/boraccount.pl 2022-02-11 18:53:57 +00:00
misc Bug 29704: (RM follow-up) Fix typo sned send 2022-04-22 13:15:44 +00:00
offline_circ Bug 29255: Built-in offline circulation broken with SQL error 2021-11-19 10:51:05 -05:00
opac Merge 21.05.12 security branch into 21.05.x 2022-03-15 13:13:25 +00:00
patron_lists Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
patroncards Bug 28576: Update the maximum size of an image. 2022-03-04 14:48:23 +00:00
plugins Bug 29931: [21.05.x] Check cookie status before continuing 2022-03-09 15:09:19 +00:00
pos Bug 28481: (RM follow-up) formatting 2021-12-17 21:22:24 +00:00
reports Bug 28977: Fix cat_issues_top.pl report with strict SQL modes 2022-02-21 16:30:35 +00:00
reserve Bug 29043: Don't fetch items if when are not on the 'Place a hold on' form 2022-02-21 15:28:43 +00:00
reviews Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
rotating_collections Bug 26618: (QA follow-up) Fix unit test for TranferCollection change 2021-03-03 15:36:13 +01:00
serials Bug 23243: Adjust previous patch 2021-04-21 15:25:07 +02:00
services Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
skel
…
suggestion Bug 28946: (bug 23271 follow-up) Missing occurrence in add_user_search.pl 2021-10-01 13:26:38 -04:00
svc Bug 29771: Remove trivial cases 2022-04-25 19:44:44 +00:00
t Bug 26328: Add test 2022-04-15 18:13:42 +00:00
tags Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
tmp/modified_authorities
…
tools Bug 29771: Scalar context for split 2022-04-25 19:50:15 +00:00
virtualshelves Bug 29542: Prevent access to private list to non authorized users 2022-01-28 14:17:15 +00:00
xt Bug 28370: Rewrite tests 2021-05-25 09:28:18 +02:00
.editorconfig Bug 24774: Set JSON indentation of 2 spaces in .editorconfig 2020-03-19 09:24:52 +00:00
.eslintrc.json Bug 23834: Add default ESLint configuration 2019-11-03 08:02:39 +00:00
.gitignore
…
.htaccess
…
.mailmap Bug 28386: Disambiguate Tomas and Blou 2021-05-26 12:30:59 +02:00
.perlcriticrc Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
.scss-lint.yml
…
INSTALL Bug 26617: Update INSTALL file to include koha-testing-docker and Gitlab links 2020-10-15 12:56:30 +02:00
Koha.pm Increment version for 21.05.13 release 2022-03-24 18:44:58 +00:00
LICENSE
…
MANIFEST.SKIP
…
Makefile.PL Bug 28519: Put CGI::Session::Serialize::yamlxs in lib directory 2021-06-18 11:23:42 -04:00
README
…
README.md Bug 27092: Remove note about "synced repo" from README.md 2020-11-25 16:31:58 +01:00
README.robots
…
about.pl Bug 28870: Move email address validation to a specific class method 2021-11-15 07:21:49 -05:00
app.psgi Bug 20582: Fix PSGI file when behind a reverse proxy 2020-10-06 12:00:04 +02:00
changelanguage.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
cpanfile Bug 30084: Remove dependency of liblocale-codes-perl (follow-up) 2022-03-20 14:49:03 +00:00
fix-perl-path.PL Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
gulpfile.js Bug 27072: Don't process staff interface CSS with rtlcss 2020-11-24 21:27:59 +01:00
help.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
koha_perl_deps.pl Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
kohaversion.pl Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
mainpage.pl Bug 29020: Add link on the mainpage for users without admin access 2022-04-15 18:04:06 +00:00
package.json Bug 27939: Update yarn.lock file 2021-03-16 12:04:06 +01:00
rewrite-config.PL Bug 28519: Put CGI::Session::Serialize::yamlxs in lib directory 2021-06-18 11:23:42 -04:00
yarn.lock Bug 27939: Update yarn.lock file 2021-03-16 12:04:06 +01:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo