Go to file
Baptiste Wojtkowski b7ed38413a
Bug 8425: Increment the barcode on each call of set_barcode()
Duplicate barcodes are generated when placing an Order in Acquisitions when AcqCreateItem = "placing an order" and Autobarcode is turned on.

The problem is that you can accidentally attach 3 items to an order, but only 1 will be saved to the database. When you go to receive your order, you can only receive 1 item as the other two were never made, since the barcode wasn't unique.

In 3.8.0, a software error comes up which prevent any item creation, I believe, but master (3.9.x) doesn't throw any warnings or errors.

Yes.. This tries and solve a bug from 3.8.0 /o/

Test plan:
1 - set syspref "autoBarcode" to generated in the form <branchcode> yymm001
2 - set the barcode field to "barcode.pl" in marc structure
3 - create a new basket
4 - add one item to this basket
5 - click on the barcode field -> it should have a barcode
6 - click on add item and click on the new barcode fiels, it should have
 the same value
 APPLY PATCH:
7 - click on the barcode field -> it should have a barcode
8 - click on add item and click on the new barcode fields, it should have
  an higher barcode.

Note : The barcode is incremented each time the barcode with an empty
value is clicked on. Therefore, if the
librarian removes the value from barcode and click again, they could get
another barcode. I do not know if it is an issue.
Note: This patch is not splitted in two parts anymore

Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov>
Signed-off-by: Magnus Enger <magnus@libriotech.no>
Followed the test plan, works as advertised.
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-01-24 12:02:15 +01:00
C4 Bug 8425: Increment the barcode on each call of set_barcode() 2025-01-24 12:02:15 +01:00
Koha Bug 38913: (bug 38416 follow-up) Elasticsearch indexing explodes with oversized records 2025-01-24 12:02:13 +01:00
acqui Bug 38155: (QA follow-up) Fix TT filters and scalar context 2024-12-23 10:35:31 +01:00
admin Bug 32890: Add DataTables to curbside pickups 2025-01-16 17:40:51 +01:00
api Bug 38461: Do not rely on biblio_id=1 2025-01-20 17:41:15 +01:00
authorities Bug 36603: (QA follow-up) Resolve two conditional declarations 2024-11-08 16:42:53 +01:00
basket Bug 31224: Update instances of metadata->record 2024-11-07 16:29:23 +01:00
bin
…
bookings Bug 35574: Bookings tab from biblio details should only require manage_bookings permission 2023-12-18 15:21:04 +01:00
catalogue Bug 38832: (QA follow-up) Remove unused $page variables 2025-01-16 17:40:48 +01:00
cataloguing Bug 8425: Increment the barcode on each call of set_barcode() 2025-01-24 12:02:15 +01:00
circ Bug 37761: Fix redirection on the tabs and buttons 2024-12-27 17:33:46 +01:00
clubs Bug 34478: Manual fix - add op clubs/templates-add-modify 2024-03-01 10:57:55 +01:00
course_reserves Bug 28762: Use Koha::Course in course-details controller 2024-07-23 16:04:05 +01:00
debian Bug 36229: Move koha-run-backups to the top of the cron 2025-01-10 19:19:31 +01:00
docs 24.11.00: Update history.txt 2024-11-25 20:38:55 +01:00
erm Bug 32922: Remove space in shebang 2023-02-20 09:44:06 -03:00
errors Bug 37741: Do not send cookie back from error pages 2024-08-30 12:45:45 +02:00
etc Bug 22415: Add new log config for EDI 2025-01-10 19:19:13 +01:00
ill Bug 35570: Prevent use of ILL module if deprecated FreeForm backend is installed 2024-10-31 08:05:21 +01:00
installer Bug 35152: DBRev 24.12.00.005 2025-01-16 17:40:51 +01:00
koha-tmpl Bug 38813: Make the 'curbside pickups' tab display selected if so 2025-01-21 15:56:42 +01:00
labels Bug 30745: (QA follow-up) tidy 2024-11-18 17:44:31 +01:00
lib Bug 35681: Use ::Bootstrap version of FromANSI 2024-05-02 16:47:39 +02:00
members Bug 28633: Add preferred name field to patrons 2024-11-11 14:12:09 +01:00
misc Bug 38894: Use HomeOrHoldingBranch with longoverdue cronjob 2025-01-24 12:02:14 +01:00
offline_circ Bug 34478: Changes for offline_circ 2024-03-01 10:58:34 +01:00
opac Bug 38813: Make the 'curbside pickups' tab display selected if so 2025-01-21 15:56:42 +01:00
patron_lists Bug 34478: Changes for patron_lists/add-modify 2024-03-01 10:57:41 +01:00
patroncards Bug 37614: Printing patron cards from patron lists should be a GET 2024-08-16 17:33:45 +02:00
plugins Bug 30897: Add option to disable automated restart 2024-04-11 16:53:42 +02:00
pos Bug 33478: Apply formatting to RECEIPT 2024-04-26 20:15:44 +02:00
preservation Bug 38089: (follow-up) More fixes for errors in original submission 2024-10-11 11:13:47 +02:00
recalls Bug 38089: (follow-up) More fixes for errors in original submission 2024-10-11 11:13:47 +02:00
reports Bug 36585: (QA follow-up) Fix tab spaces 2025-01-16 17:40:45 +01:00
reserve Bug 37427: Fix club search to display all clubs when search field is empty, consistent with patron search behavior 2024-12-23 12:20:39 +01:00
reviews Bug 2486: Show user comments in staff interface 2024-08-26 17:39:42 +02:00
rotating_collections Bug 34478: Manual fix - add op - rotating_collections/addItems 2024-03-01 10:57:33 +01:00
serials Bug 29818: Cannot save subscription frequency without display order 2024-11-18 17:44:35 +01:00
services
…
skel
…
suggestion Bug 33484: Fix for suggestions 2024-10-28 17:10:26 +01:00
svc Bug 31224: Update instances of metadata->record 2024-11-07 16:29:23 +01:00
t Bug 38913: (QA follow-up) test UTF-8 exceptions in large MARC records 2025-01-24 12:02:14 +01:00
tags Bug 37826: Remove the use of the script_name variable where it is unnecessary 2024-12-27 17:33:51 +01:00
tools Bug 18657: Add the possibility to add every items to the report 2025-01-16 17:40:44 +01:00
virtualshelves Bug 31224: Update instances of metadata->record 2024-11-07 16:29:23 +01:00
xt Bug 37728: Adjust test to catch more missing 'op' in POSTed forms 2024-10-18 14:25:56 +02:00
.editorconfig
…
.gitignore Bug 35402: Update the OPAC and staff interface to Bootstrap 5 2024-08-23 15:58:41 +02:00
.htaccess
…
.mailmap 24.11.00: Update .mailmap 2024-11-25 13:16:42 +01:00
.perlcriticrc
…
.perltidyrc Bug 30002: Adjust perltidy 2023-06-08 08:32:42 -03:00
.prettierrc.js Bug 38546: Set tabWidth and useTabs in prettierrc 2025-01-07 15:47:52 +01:00
.proverc.dist
…
.stylelintrc.json
…
INSTALL
…
Koha.pm Bug 35152: DBRev 24.12.00.005 2025-01-16 17:40:51 +01:00
LICENSE
…
MANIFEST.SKIP
…
Makefile.PL Bug 38167: (QA follow-up) Remove old, add new eslint config to Makefile.PL 2025-01-16 17:40:53 +01:00
README
…
README.md
…
README.robots
…
about.pl Bug 36039: (QA follow-up): Improve audit messages 2024-12-27 15:19:05 +01:00
app.psgi Bug 36149: Add userenv middleware to app.psgi 2024-05-14 15:04:37 -03:00
build-resources.PL Bug 32609: Use the current yarn.lock to generate node_modules 2023-02-10 11:07:57 -03:00
changelanguage.pl
…
cpanfile Bug 33018: debian package tidy-up (2) 2024-12-20 18:33:23 +01:00
cypress.config.ts Bug 38770: Remove @vue/cli-service and babel 2025-01-16 15:56:15 +01:00
eslint.config.mjs Bug 38524: Enable ESLint for .ts and .vue files 2025-01-16 15:56:17 +01:00
fix-perl-path.PL
…
gulpfile.js Bug 36640: (follow-up) CSS fixes for DataTables controls 2024-11-14 14:19:34 +01:00
help.pl
…
kohaversion.pl
…
mainpage.pl Bug 36064: (QA follow-up) Simplify and tidy 2024-10-25 11:09:51 +02:00
package.json Bug 38524: Enable ESLint for .ts and .vue files 2025-01-16 15:56:17 +01:00
rewrite-config.PL
…
rspack.config.js Bug 37824: (QA follow-up) Fix improper handling of jQuery and DataTables libraries by marking them as externals 2024-09-16 18:41:17 +02:00
tsconfig.json
…
webpack.config.js Bug 35919: Add record sources admin page 2024-04-26 17:06:04 +02:00
yarn.lock Bug 38524: Update yarn.lock 2025-01-16 15:56:17 +01:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo