Koha-clms/circ
Emmi Takkinen b7c0e28bb6
Bug 36762: Fix setting transfer for hold via branchtransfers.pl
When one tries to transfer an item that could fill a pending hold
to a library that is not the holds pickup library, Koha gives only
a option to transfer item to pickup library. When this option
is chosen, Koha tells that item is being transfered to selected
library not to pickup library but fails to create the transfer.
This patch fixes this by setting op variable as "cud-transfer"
and tobranchcd as holds pickup library so that transfer is actually
made and target library is displaued correctly.

To test:
1. Log into Library A.
2. Find or create a biblio with 1 holdable item at Library A.
3. Place a hold for pickup at Library B.
4. Navigate to Circulation > Transfers.
5. Attempt to send your item to Library C.
6. Koha gives you three options. Pick the first one:
"Transfer to Library B."
7. Koha tells you it has transferred the item to Library C.
8. Go to detail.pl for your title, confirm the holdings table
says "there is an item level hold" on your item.
9. Click to the Holds tab for your title, confirm the hold claims
to be in transit.
10. Query the branchtransfers table
SELECT * FROM branchtransfers WHERE itemnumber = [your item]
=> Note that no new transfer was made.
11. Query reserves SELECT * FROM reserves WHERE biblionumber = [your biblio]
=> Confirm your hold has found=T, itemnumber=[your item], and item_level_hold=0
12. Revert trasfer from biblios holds page.
13. Apply this patch.
14. Attempt the transfer again.
=> Koha should now tell that transfer was made to Libary B.
15. Check branchtransfers table again.
=> New transfer should have been made to Library B.

Sponsored-by: Koha-Suomi Oy
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2026-08-13 08:53:18 -06:00
..
add_message.pl Bug 39781: Allow limiting of custom message notices by library 2026-03-24 15:38:08 +01:00
article-request-slip.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
article-requests.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
bookcount.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
branchoverdues.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
branchtransfers.pl Bug 36762: Fix setting transfer for hold via branchtransfers.pl 2026-08-13 08:53:18 -06:00
checkout-notes.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
circulation-home.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
circulation.pl Bug 41940: Remove uninitialized value warnings in circulation.pl 2026-05-20 09:04:58 -06:00
curbside_pickups.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
del_message.pl Bug 41904: "Use of uninitialized value..." warning in del_message.pl 2026-03-05 08:33:55 -07:00
hold-transfer-slip.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
on-site_checkouts.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
overdue.pl Bug 41343: Further improvements 2026-05-01 11:04:37 -06:00
pendingbookings.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
pendingreserves.pl Bug 40529: Behavior change: Main patch 2025-11-03 14:13:22 -07:00
renew.pl Bug 23415: Add debt override support to circulation checkout page 2026-03-22 23:27:26 +01:00
request-article.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
reserveratios.pl Bug 21941: Fix GROUP BY in circ/reserveratios.pl 2026-04-09 08:27:25 -06:00
returns.pl Bug 41957: Show hold group information on 'Hold found' modal 2026-04-10 09:48:02 -06:00
set-library.pl Bug 41229: Fix desk and register session persistence on library change 2025-12-01 08:34:05 -07:00
transfer-slip.pl Bug 35267: Apply preferences to preview and mailing 2026-04-17 09:18:06 -06:00
transfers_to_send.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00
transferstoreceive.pl Bug 41206: Add collection code to transfers to receive 2026-02-06 15:17:10 -07:00
view_holdsqueue.pl Bug 40335: Fix mistake in template params 2025-10-14 14:51:57 -06:00
waitingreserves.pl Bug 40163: Fix several http addresses in the code docs 2025-09-23 16:21:29 -06:00