gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Koha-clms/opac
History
Nick Clemens b3ecb4644e
Bug 24754: Set userenv for ilsdi requests 
Currently ILSDI scripts do not have a userenv set. This affects both
action_logs and statistics.

For action_logs we either get no user or, if there is an active session, we use that one. This can have unintended consequences and we should explicitly set the env so that system user (0) is recorded

For statistics we need to specify a branch to record for actions like renewals. With bug 24759 we add an items method for this. We should take advantage of this method and use the 'opac' interface as the ilsdi scripts live there.

To test:
1 - Enable ILSDI in systempreferences
2 - Checkout an item to a patron
3 - Enable Renewal logs
4 - Ensure you will be able to renew the item several times
5 - Open an incognito/private browser
6 - Renew item via ilsdi:
    http://localhost:8080/cgi-bin/koha/ilsdi.pl?service=RenewLoan&patron_id=5&item_id=1128
7 - Check action logs, interface may be random, user should be 0, if not make sure the user in step 9 is a different one
8 - In private browser open a new tab
9 - Sign in to staff client
10 - Return to other tab
11 - Refresh page to repeat renewal
12 - Check action_logs
13 - The second renewal indicates it was renewed via intranet by logged in staff member
14 - Apply patch
15 - restart_all
16 - Ensure staff client still signed in
17 - Repeate renewal again
18 - Check logs, renewal now indicates opac again (as it should), user is 0 even if logged in on other tab

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
 		2020-03-25 09:32:37 +00:00
..
clubs Bug 22542: Force back button to display personal data 2019-05-02 13:43:48 +00:00
errors Bug 19991: use Modern::Perl in OPAC perl scripts 2018-08-30 13:40:32 +00:00
external/overdrive
…
rss
…
sci Bug 22739: Test SelfCheckInTimeout <> 0, not just defined 2019-04-25 10:05:00 +00:00
sco Bug 22943: (QA follow-up) Add new cases 2020-03-16 11:00:30 +00:00
svc Bug 24384: Add Access-Control-Allow-Origin support to OPAC reports svc 2020-03-19 09:23:13 +00:00
ilsdi.pl Bug 24754: Set userenv for ilsdi requests 2020-03-25 09:32:37 +00:00
maintenance.pl
…
oai.pl
…
opac-ISBDdetail.pl Bug 18936: (follow-up) Fix tests, replace old get_onshelfholds_policy method 2020-02-04 09:56:25 +00:00
opac-MARCdetail.pl Bug 5103: Refactor the code to avoid repetition 2020-03-16 10:56:45 +00:00
opac-account-pay-paypal-return.pl Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
opac-account-pay-return.pl Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
opac-account-pay.pl Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
opac-account.pl Bug 20691: Implement fines view 2019-09-11 08:53:51 +01:00
opac-addbybiblionumber.pl Bug 11529: Add templates for biblio title display. Unify display. 2019-08-05 15:03:19 +01:00
opac-alert-subscribe.pl Bug 22542: Force back button to display personal data 2019-05-02 13:43:48 +00:00
opac-article-request-cancel.pl Bug 22068: (QA follow-up) Return meaningful error codes 2019-04-10 19:58:31 +00:00
opac-authorities-home.pl Bug 24103: (follow-up) Dump query on opac authorities search 2020-02-19 15:58:51 +00:00
opac-authoritiesdetail.pl Bug 21871: (QA follow-up) C4::Biblio qw(GetMarcUrls) 2019-01-30 12:12:21 +00:00
opac-basket.pl Bug 23392: Don't display private notes in MARC21 2019-10-24 10:58:02 +01:00
opac-blocked.pl
…
opac-browse.pl Bug 24545: Fix newly added files 2020-02-24 13:31:27 +00:00
opac-browser.pl Bug 19991: use Modern::Perl in OPAC perl scripts 2018-08-30 13:40:32 +00:00
opac-changelanguage.pl Bug 21299: (QA follow-up) Rename module and subroutine 2018-11-07 21:52:17 +00:00
opac-course-details.pl
…
opac-course-reserves.pl
…
opac-detail.pl Bug 24854: Remove IDreamBooks integration 2020-03-24 08:07:23 +00:00
opac-discharge.pl Bug 23723: using exit inside eval to stop sending output to browser doesn't work under plack 2019-10-07 12:21:30 +01:00
opac-downloadcart.pl Bug 14385: Squash of a lot of patches rebased 2018-11-02 10:33:12 +00:00
opac-downloadshelf.pl Bug 14385: Squash of a lot of patches rebased 2018-11-02 10:33:12 +00:00
opac-export.pl Bug 22075: Fix encoding problem with RIS export in OPAC 2019-04-11 11:47:17 +00:00
opac-ics.pl Bug 19991: use Modern::Perl in OPAC perl scripts 2018-08-30 13:40:32 +00:00
opac-idref.pl
…
opac-illrequests.pl Bug 22542: Force back button to display personal data 2019-05-02 13:43:48 +00:00
opac-image.pl Bug 19991: use Modern::Perl in OPAC perl scripts 2018-08-30 13:40:32 +00:00
opac-imageviewer.pl Bug 19991: use Modern::Perl in OPAC perl scripts 2018-08-30 13:40:32 +00:00
opac-issue-note.pl Bug 22821: Rename method with ->inbound_email_address 2020-03-18 15:44:27 +00:00
opac-main.pl Bug 22880: (follow-up) Loose ends: Better DB update, global inclusion, etc. 2020-02-24 13:24:25 +00:00
opac-memberentry.pl Bug 20443: Remove C4::Members::AttributeTypes 2020-03-23 13:44:41 +00:00
opac-messaging.pl Bug 18933: Allow OPAC messaging SMS number to be set to empty 2020-02-19 11:16:35 +00:00
opac-modrequest-suspend.pl Bug 19991: use Modern::Perl in OPAC perl scripts 2018-08-30 13:40:32 +00:00
opac-modrequest.pl Bug 19991: use Modern::Perl in OPAC perl scripts 2018-08-30 13:40:32 +00:00
opac-mymessages.pl Bug 19991: use Modern::Perl in OPAC perl scripts 2018-08-30 13:40:32 +00:00
opac-news-rss.pl
…
opac-overdrive-search.pl Bug 19991: use Modern::Perl in OPAC perl scripts 2018-08-30 13:40:32 +00:00
opac-passwd.pl Bug 10796: Use $category->effective_change_password in the OPAC 2019-04-12 02:32:07 +00:00
opac-password-recovery.pl Bug 21533: Do not allow password recovery for administrative locked patrons 2019-05-10 12:19:13 +00:00
opac-patron-consent.pl Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
opac-patron-image.pl Bug 19991: use Modern::Perl in OPAC perl scripts 2018-08-30 13:40:32 +00:00
opac-privacy.pl Bug 20691: Add ability to turn feature on and off 2019-09-11 08:53:46 +01:00
opac-ratings-ajax.pl Bug 19991: use Modern::Perl in OPAC perl scripts 2018-08-30 13:40:32 +00:00
opac-ratings.pl Bug 19991: use Modern::Perl in OPAC perl scripts 2018-08-30 13:40:32 +00:00
opac-readingrecord.pl Bug 24827: Standardise on 'UTF-8' as the encoding name 2020-03-16 14:45:39 +00:00
opac-recordedbooks-search.pl Bug 17602: Fix few minor QA issues 2018-10-01 13:56:56 +00:00
opac-registration-verify.pl Bug 23253: Fix OpacNavRight for self reg by email 2019-08-15 09:19:28 +01:00
opac-renew.pl Bug 24759: Move OpacRenewalBranch code to Koha::Item 2020-03-24 10:47:49 +00:00
opac-request-article.pl Bug 22542: Force back button to display personal data 2019-05-02 13:43:48 +00:00
opac-reserve.pl Bug 19718: Show message if patron has existing holds on a title 2020-02-17 11:27:27 +00:00
opac-restrictedpage.pl Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
opac-retrieve-file.pl
…
opac-review.pl Bug 21986: Do not escape quotation marks when cataloguing 2018-12-14 13:33:28 +00:00
opac-routing-lists.pl Bug 21137: Replace BORROWER_INFO with logged_in_user 2018-08-14 12:43:12 +00:00
opac-search-history.pl Bug 23084: Replace grep {^$var$} with grep {$_ eq $var} 2020-02-17 10:44:45 +00:00
opac-search.pl Bug 24854: Remove IDreamBooks integration 2020-03-24 08:07:23 +00:00
opac-sendbasket.pl Bug 22542: Force back button to display personal data 2019-05-02 13:43:48 +00:00
opac-sendshelf.pl Bug 11529: Add templates for biblio title display. Unify display. 2019-08-05 15:03:19 +01:00
opac-serial-issues.pl Bug 23126: Display multi-line entries in subscrpitions correctly 2019-06-25 17:18:00 +01:00
opac-shareshelf.pl Bug 22542: Force back button to display personal data 2019-05-02 13:43:48 +00:00
opac-shelves.pl Bug 23482: Fix BakerTaylor cover images on lists 2020-02-21 15:44:01 +00:00
opac-showmarc.pl Bug 20083: (follow-up) use same logic in opac-showmarc 2018-04-04 15:45:34 -03:00
opac-showreviews.pl Bug 22445: Custom cover images - opac reviews 2019-10-22 15:02:49 +01:00
opac-suggestions.pl Bug 24345: Fix OPACViewOthersSuggestions 2020-01-23 09:09:00 +00:00
opac-tags.pl Bug 18936: (QA follow-up) Remove 2 new occurrences of Koha::IssuingRules 2020-02-04 09:56:30 +00:00
opac-tags_subject.pl Bug 19991: use Modern::Perl in OPAC perl scripts 2018-08-30 13:40:32 +00:00
opac-topissues.pl Bug 19991: use Modern::Perl in OPAC perl scripts 2018-08-30 13:40:32 +00:00
opac-user.pl Bug 24476: Allow direct editing of autorenew_checkouts by patron 2020-03-24 11:23:58 +00:00
tracklinks.pl Bug 23836: exit after output_error 2019-11-27 11:30:19 +00:00
unapi Bug 24052: Rename XSLT_Handler 2020-03-24 10:42:23 +00:00