Koha-clms/Koha
Jonathan Druart b0dc5fc0f3 Bug 15498: Let the user choose the CSV profile to export circ history
The way the export options are displayed at the bottom of the checkouts table
was not consistent.
Prior to this patch set, they are display if ExportRemoveFields or
ExportWithCsvProfile is set.
It does not make any sense, the user could want to export the checkouts in
iso2709 format without having to define a csv profile and fill the pref.

Moreover the behavior of this pref did not match its description: it's used as
a default CSV profile when exporting records from the export tools or the
command line.

This patch set adds a new pref ExportCircHistory and remove
ExportWithCsvProfile. The new pref is set if ExportWithCsvProfile or
ExportRemoveFields were set.
A new dropdown list with the CSV profile list will be displayed in the
export area, at the bottom of the checkouts table.

Note that now --csv_profile_id is mandatory for the export command line
(misc/export_records.pl) if the export format is csv.

Test plan:
0/ Do not execute the DB entry
1/ Clear both ExportWithCsvProfile and ExportRemoveFields prefs
2/ Execute the DB entry
3/ ExportCircHistory should not be set and the export options should not
be displayed at the bottom of the checkouts table.
4/ Remove the pref
  DELETE FROM systempreferences WHERE variable='ExportCircHistory';
and reinsert the previous one, with a value:
  INSERT INTO systempreferences (variable, value) VALUES
  ('ExportWithCsvProfile', 'something');
Execute the DB entry again
=> The now pref should be now set
5/ Export some checkouts using the CSV entry
6/ Note that the export tool and commandline script still work using the
csv format. You have to provide a --csv_profile_id option to make it
work.

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-03-31 11:13:47 +00:00
..
Account Bug 17586: Move ->get_balance to Koha::Account->balance 2016-12-16 14:50:18 +00:00
Acquisition Bug 13726: Make Koha::Acq::Bookseller using Koha::Object 2016-12-30 11:54:32 +00:00
ArticleRequest Bug 14610 - Add and update modules 2016-10-26 12:15:13 +00:00
Authority Bug 15446: (follow-up) Rename Koha::Object[s]->type with _type 2016-02-12 12:35:57 -07:00
Biblio Bug 17196: Move marcxml out of the biblioitems table 2017-01-13 13:49:26 +00:00
BiblioUtils Bug 17196: [QA Follow-up] Adjust some text on marcxml 2017-01-13 13:49:30 +00:00
Cache Bug 16088: Introduce Koha::Cache::Memory::Lite to cache the language 2016-06-04 07:43:22 +00:00
Config Bug 11998: Use Koha::Cache to cache sysprefs 2016-03-15 07:08:28 +00:00
Edifact BUG 17414 Add new GIR codes in Edifact 2016-10-11 14:14:12 +00:00
Exceptions Bug 17767: Make Koha::Patron::Modification handle extended attributes 2016-12-28 13:53:02 +00:00
Exporter Bug 15498: Let the user choose the CSV profile to export circ history 2017-03-31 11:13:47 +00:00
ExternalContent bug_16034 Koha::ExternalContent::OverDrive - a wrapper around WebService::ILS::Overdrive::Patron 2017-02-21 19:58:20 +00:00
Filter/MARC Bug 16365: Selectively introduce GetMarcStructure() "unsafe" variant for better performance 2016-09-09 10:43:22 +00:00
Indexer Revert Bug 11081 - Port Koha::Contrib::Tamil indexer into Koha code base 2016-03-01 16:56:35 +00:00
Item Bug 16686: Add Koha::Object based class for Koha::Item::Transfer[s] 2016-09-02 13:56:03 +00:00
List
…
MetadataRecord Bug 16708 - (QA followup) Fix pod copy/paste error 2016-06-24 11:59:40 +00:00
Middleware Bug 16520 (Follow up) Rebase fixes 2016-10-11 12:37:17 +00:00
Misc Bug 16011: $VERSION - Remove use vars qw(); 2016-03-24 17:20:39 +00:00
Notice Bug 17959 - Add the Koha::Notice::Message[s] packages (message_queue table) 2017-02-17 11:48:44 +00:00
Number Bug 16768 - Add official number format for Switzerland: 1'234'567.89 2016-06-24 14:00:03 +00:00
OAI/Server Bug 17196: Move marcxml out of the biblioitems table 2017-01-13 13:49:26 +00:00
Object/Limit Bug 17755: (QA followup) Return $self when appropriate 2017-03-24 18:32:46 +00:00
Old Bug 17796: Move Koha::OldIssue[s] to Koha::Checkout[s] 2016-12-20 15:13:29 +00:00
Patron Bug 13757: Attribute with value 0 should be stored 2017-03-24 18:45:20 +00:00
Plugins Bug 17935: Follow up for C4::Plugin... 2017-02-14 14:12:51 +00:00
QueryParser/Driver Bug 15258: Fix Perl scripts declaring unused variables 2015-12-30 17:24:45 -07:00
REST Bug 17992: REST api: Remove the use of ->unblessed from Cities controller 2017-03-03 16:57:40 +00:00
RecordProcessor Bug 16011: $VERSION - Remove the $VERSION init 2016-03-24 17:20:28 +00:00
SMS Bug 15548 [QA Followup] - More new uses of Koha::Borrower 2016-03-03 14:39:00 -07:00
Schema/Result Bug 13757: DBIC update 2017-03-24 18:44:55 +00:00
SearchEngine Bug 17169: Add a facet for ccode fields to ElasticSearch 2017-03-22 19:24:22 +00:00
Serial Bug 7677: QA followup 2016-09-12 09:13:57 +00:00
Sitemapper
…
Subscription Bug 15446: (follow-up) Rename Koha::Object[s]->type with _type 2016-02-12 12:35:57 -07:00
SuggestionEngine
…
Template/Plugin Bug 17847: Replace C4::Koha::GetAuthvalueDropbox with Koha::AuthorisedValues 2017-03-31 10:12:37 +00:00
Tmp Bug 17962: Add Koha::Tmp::Order[s] 2017-02-17 11:43:46 +00:00
Util Bug 17302: [Follow-up] Make Normalize.pm undef-resistent 2016-09-25 14:04:54 +00:00
Account.pm Bug 18266: Fix internal error when paying fine for lost item without.. item 2017-03-31 10:04:31 +00:00
AdditionalField.pm
…
ArticleRequest.pm Bug 17963: TT syntax for notices - Prove that AR_* are compatible 2017-03-31 10:20:35 +00:00
ArticleRequests.pm Bug 14610 - Add and update modules 2016-10-26 12:15:13 +00:00
AudioAlert.pm Bug 15446: Rename Koha::Object[s]->type with _type 2016-02-12 12:35:57 -07:00
AudioAlerts.pm Bug 15446: Rename Koha::Object[s]->type with _type 2016-02-12 12:35:57 -07:00
AuthUtils.pm Bug 16818: External auth redirect broken under Plack 2016-08-04 19:42:44 +00:00
AuthorisedValue.pm Bug 17935: Adjust some POD lines, fix a few typos 2017-02-14 14:12:50 +00:00
AuthorisedValueCategories.pm Bug 17216: Add Koha::AuthorisedValueCategory|ies classes 2016-10-11 07:30:30 +00:00
AuthorisedValueCategory.pm Bug 17216: Add Koha::AuthorisedValueCategory|ies classes 2016-10-11 07:30:30 +00:00
AuthorisedValues.pm Bug 17642: Do not explode if no authorised value exist 2016-11-18 15:52:01 +00:00
Authorities.pm Bug 15446: (follow-up) Rename Koha::Object[s]->type with _type 2016-02-12 12:35:57 -07:00
Authority.pm Bug 16708: Fix authority reindex for ElasticSearch 2016-06-24 11:59:40 +00:00
Biblio.pm Bug 18258: (QA followup) Use Koha::Subscriptions 2017-03-31 10:09:03 +00:00
BiblioFramework.pm Bug 15446: (follow-up) Rename Koha::Object[s]->type with _type 2016-02-12 12:35:57 -07:00
BiblioFrameworks.pm Bug 14889: Fix typo in Koha/BiblioFrameworks.pm 2016-03-03 20:32:47 +00:00
BiblioUtils.pm Bug 12748: (QA followup) fix several tiny QA tools warnings 2016-04-26 20:20:13 +00:00
Biblioitem.pm Bug 15446: Rename Koha::Object[s]->type with _type 2016-02-12 12:35:57 -07:00
Biblioitems.pm Bug 15446: Rename Koha::Object[s]->type with _type 2016-02-12 12:35:57 -07:00
Biblios.pm Bug 14610 - Add and update modules 2016-10-26 12:15:13 +00:00
Cache.pm Bug 17935: Adjust some POD lines, fix a few typos 2017-02-14 14:12:50 +00:00
Caches.pm Bug 17935: Adjust some POD lines, fix a few typos 2017-02-14 14:12:50 +00:00
Calendar.pm Bug 16376 - Koha::Calendar->is_holiday date truncation creates fatal errors for TZ America/Santiago 2016-12-09 15:25:01 +00:00
Checkout.pm Bug 17973: Add the Koha::Checkout->item method 2017-02-17 12:11:30 +00:00
Checkouts.pm Bug 14757 - Allow the use of Template Toolkit syntax for slips and notices 2016-07-08 13:47:42 +00:00
Cities.pm Bug 15446: Rename Koha::Object[s]->type with _type 2016-02-12 12:35:57 -07:00
City.pm Bug 15446: Rename Koha::Object[s]->type with _type 2016-02-12 12:35:57 -07:00
Config.pm Bug 11921: (followup) Don't die on non-existent koha-conf.xml 2016-09-09 13:56:13 +00:00
CsvProfile.pm Bug 15451: Add the 2 new modules Koha::CsvProfile[s] 2016-07-22 17:18:34 +00:00
CsvProfiles.pm Bug 15451: Add the 2 new modules Koha::CsvProfile[s] 2016-07-22 17:18:34 +00:00
Database.pm Bug 18215: Resolve warning on $tls in Database.pm 2017-03-06 14:10:33 +00:00
DateUtils.pm Bug 16848: Prevent invalid warning to be carped from output_pref 2016-08-10 13:43:34 +00:00
EDI.pm Bug 17605: [MASTER] Add currency to orders generated by quotes 2017-03-23 00:44:45 +00:00
Edifact.pm Bug 7736: Support Ordering via Edifact EDI messages 2016-04-01 20:03:17 +00:00
Email.pm
…
Exceptions.pm Bug 17755: Introduce Koha::Object::Limit::Library 2017-03-24 18:32:42 +00:00
ExternalContent.pm bug_16034 Koha::ExternalContent::OverDrive - a wrapper around WebService::ILS::Overdrive::Patron 2017-02-21 19:58:20 +00:00
FieldMapping.pm Bug 18269: Add Koha::FieldMapping[s] packages 2017-03-31 10:19:59 +00:00
FieldMappings.pm Bug 18269: Add Koha::FieldMapping[s] packages 2017-03-31 10:19:59 +00:00
FrameworkPlugin.pm
…
Hold.pm Bug 14642: Make sure the log will be written only if the hold has been deleted 2016-08-17 18:43:13 +00:00
Holds.pm Bug 17327: (QA followup) Remove Carp::Always which is not used 2016-09-24 20:55:17 +00:00
I18N.pm
…
IssuingRule.pm Bug 15446: (follow-up) Rename Koha::Object[s]->type with _type 2016-02-12 12:35:57 -07:00
IssuingRules.pm Bug 17783: Prevent crash when providing an undefined value 2016-12-23 12:01:57 +00:00
Item.pm Bug 17974 (QA Followup) 2017-02-17 12:11:54 +00:00
ItemType.pm Bug 17589 - Improper method type in Koha::ItemType(s) 2016-11-08 17:12:27 +00:00
ItemTypes.pm Bug 17589 - Improper method type in Koha::ItemType(s) 2016-11-08 17:12:27 +00:00
Items.pm Bug 15446: Rename Koha::Object[s]->type with _type 2016-02-12 12:35:57 -07:00
Libraries.pm Bug 15758: Koha::Libraries - Move onlymine to C4::Context::only_my_library 2016-09-08 14:36:04 +00:00
Library.pm Bug 15446 [QA Followup] - Update new classes 2016-02-12 12:35:57 -07:00
LibraryCategories.pm Bug 15446 [QA Followup] - Update new classes 2016-02-12 12:35:57 -07:00
LibraryCategory.pm Bug 15629: Koha::Libraries - Remove GetBranchesInCategory (1) 2016-02-24 03:55:05 +00:00
Linktracker.pm
…
Localization.pm Bug 15446: Rename Koha::Object[s]->type with _type 2016-02-12 12:35:57 -07:00
Localizations.pm Bug 15446: Rename Koha::Object[s]->type with _type 2016-02-12 12:35:57 -07:00
Logger.pm Bug 17088: [Follow-up] Adjust POD in Logger.pm 2016-10-10 12:24:00 +00:00
MarcSubfieldStructure.pm Bug 17249: Remove GetKohaAuthorisedValuesFromField - Add classes MarcSubfieldStructure[s] 2016-10-21 15:13:55 +00:00
MarcSubfieldStructures.pm Bug 17249: Remove GetKohaAuthorisedValuesFromField - Add classes MarcSubfieldStructure[s] 2016-10-21 15:13:55 +00:00
MetaSearcher.pm Bug 16769: Uniformise calls to Koha::Cache->set_in_cache 2016-10-10 17:03:54 +00:00
MetadataIterator.pm Bug 12478 - authorities can now be stored in ES 2016-04-26 20:20:03 +00:00
MetadataRecord.pm Bug 17201: (bug 16431 follow-up) Remove occurrence of marcfromkohafield 2016-09-02 14:00:11 +00:00
News.pm Bug 14757 - Allow the use of Template Toolkit syntax for slips and notices 2016-07-08 13:47:42 +00:00
NewsItem.pm Bug 14757 - Allow the use of Template Toolkit syntax for slips and notices 2016-07-08 13:47:42 +00:00
NorwegianPatronDB.pm Bug 16011: $VERSION - Remove comments 2016-03-24 17:20:29 +00:00
Object.pm Bug 17932: Add a TO_JSON method to Koha::Object(s) 2017-02-17 15:32:59 +00:00
Objects.pm Bug 17932: Add a TO_JSON method to Koha::Object(s) 2017-02-17 15:32:59 +00:00
Patron.pm Revert "Bug 12461 - Add patron clubs feature" 2017-02-26 20:41:27 -05:00
Patrons.pm Bug 18169: Make 'before' param non mandatory for Koha::Patrons->anonymise_issue_history 2017-03-03 18:16:54 +00:00
Plugins.pm Bug 17461: Warn about plugins that can't be loaded 2017-02-17 17:19:22 +00:00
Rating.pm Bug 17089: Mark out the boundaries of ratings 2016-09-09 09:31:30 +00:00
Ratings.pm Bug 17089: Koha::Ratings - Remove GetRating 2016-09-09 09:31:29 +00:00
RecordProcessor.pm Bug 15870: potential follow up to comment #8 2016-03-24 20:15:40 +00:00
RefundLostItemFeeRule.pm Bug 14048: (QA followup) Default to 1 if no default rule 2016-07-07 10:37:01 -06:00
RefundLostItemFeeRules.pm Bug 14048: (QA followup) Default to 1 if no default rule 2016-07-07 10:37:01 -06:00
Review.pm Bug 15839: Koha::Reviews - Remove approvereview & unapprovereview 2016-09-09 10:29:57 +00:00
Reviews.pm Bug 15839: Koha::Reviews - Add Koha::Review[s] classes 2016-09-09 10:29:31 +00:00
Schema.pm
…
SearchEngine.pm Bug 12478: make things using SimpleSearch use the new version 2016-04-26 20:20:07 +00:00
SearchField.pm Bug 12748: (QA followup) fix several tiny QA tools warnings 2016-04-26 20:20:13 +00:00
SearchFields.pm Bug 12748: (QA followup) fix several tiny QA tools warnings 2016-04-26 20:20:13 +00:00
SearchMarcMap.pm Bug 12748: (QA followup) fix several tiny QA tools warnings 2016-04-26 20:20:13 +00:00
SearchMarcMaps.pm Bug 12748: (QA followup) fix several tiny QA tools warnings 2016-04-26 20:20:13 +00:00
Serial.pm Bug 15446: Rename Koha::Object[s]->type with _type 2016-02-12 12:35:57 -07:00
Serials.pm Bug 15446: Rename Koha::Object[s]->type with _type 2016-02-12 12:35:57 -07:00
SimpleMARC.pm Bug 16011: $VERSION - Remove the $VERSION init 2016-03-24 17:20:28 +00:00
Sitemapper.pm
…
Subscription.pm Bug 15446: (follow-up) Rename Koha::Object[s]->type with _type 2016-02-12 12:35:57 -07:00
Subscriptions.pm Bug 15446: (follow-up) Rename Koha::Object[s]->type with _type 2016-02-12 12:35:57 -07:00
Suggestion.pm Bug 14757 - Allow the use of Template Toolkit syntax for slips and notices 2016-07-08 13:47:42 +00:00
SuggestionEngine.pm
…
Suggestions.pm Bug 14757 - Allow the use of Template Toolkit syntax for slips and notices 2016-07-08 13:47:42 +00:00
Token.pm Bug 18124: [Follow-up] Handle default parameters in a sub 2017-03-30 09:07:08 +00:00
UploadedFile.pm Bug 17501: [Follow-up] QA Requests 2017-01-20 14:20:07 +00:00
UploadedFiles.pm Bug 17501: [Follow-up] QA Requests 2017-01-20 14:20:07 +00:00
Uploader.pm Bug 17501: Rename Upload to Uploader 2017-01-20 14:20:06 +00:00
Virtualshelf.pm Bug 17094: Make Koha::Virtualshelf methods return Koha::Objects-based objects 2016-10-11 13:14:46 +00:00
Virtualshelfcontent.pm Bug 15446: Rename Koha::Object[s]->type with _type 2016-02-12 12:35:57 -07:00
Virtualshelfcontents.pm Bug 15446: Rename Koha::Object[s]->type with _type 2016-02-12 12:35:57 -07:00
Virtualshelfshare.pm Bug 15446: Rename Koha::Object[s]->type with _type 2016-02-12 12:35:57 -07:00
Virtualshelfshares.pm Bug 15446: Rename Koha::Object[s]->type with _type 2016-02-12 12:35:57 -07:00
Virtualshelves.pm Bug 16551: Display the name of lists to the search results at the OPAC 2016-09-25 15:43:07 +00:00
XSLT_Handler.pm
…