Koha-clms/t/db_dependent
Tomas Cohen Arazi 356047b920 Bug 19440: Identify overlimit problems in XISBN tests
This patch makes C4::XISBN::get_xisbns() return an errors hashref
including information of the failing fetches from xisbn services.

It tackles the situation of XISBN, which in some cases returns 'overlimit'
errors.

The patch makes the relevant functions check if the response->{stat} string
is 'ok' and returns the string in $errors otherwise.

This only happens when in list context. This allows to fix the randomly failing
tests while keeping the current behaviour.

All this code should be rewritten. It does the job bug doesn't have problems handling
or reoprting. This is just a band aid.

To test:
- Make sure
 k$ prove t/db_dependent/XISBN.t
=> SUCCESS :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Mason James <mtj@kohaaloha.com>
2017-10-24 17:35:22 +13:00
..
Acquisition Bug 19024 Fix some infelicities of phrasing in test messages 2017-10-24 16:42:12 +13:00
Auth Bug 15756: Some tests for haspermission in C4::Auth 2016-02-23 20:54:42 +00:00
Authorities Bug 17913: [16.05.x] Authority merge fix 2017-02-24 09:42:24 +13:00
Biblio Bug 19441: Fix t/db_dependent/Biblio/TransformKohaToMarc.t 2017-10-13 13:22:14 +13:00
Circulation Bug 19071: Fix Circulation/issue.t 2017-10-24 16:42:06 +13:00
Creators Bug 18044: Add a test 2017-02-16 07:23:50 +13:00
Exporter Bug 17644 - t/db_dependent/Exporter/Record.t fails 2016-12-12 14:54:12 +13:00
Holds Bug 17574: Remove itemtype-related warnings from LocalHoldsPriority.t 2016-12-12 14:54:09 +13:00
Items Bug 19441: Fix AutomaticItemModificationByAge.t 2017-10-13 13:22:14 +13:00
Koha Revert "Bug 17249: Remove GetKohaAuthorisedValuesFromField - Add classes MarcSubfieldStructure[s]" 2017-09-20 15:59:43 +12:00
LDAP DB-dependent tests moved 2008-01-08 14:07:38 -06:00
Labels Bug 14468: (QA followup) remove useless diags 2015-10-27 10:38:15 -03:00
Letters Bug 13215: Fix GetLetterTemplates should return default templates if branchcode is not defined 2014-11-27 11:42:26 -03:00
Members Bug 19071: Fix Members/IssueSlip.t 2017-10-24 16:42:07 +13:00
OAI Bug 18794: Fix test ListMetadataFormats in OAI/Server.t 2017-10-24 16:42:10 +13:00
Patron Bug 17603: Remove itemtype-related Borrower_Discharge.t warnings 2016-12-12 14:54:09 +13:00
Record Revert "Bug 17249: Remove GetKohaAuthorisedValuesFromField - add tests" 2017-09-20 15:59:35 +12:00
Reports Bug 12787 [QA Followup] - Retain change to Reports_Guided.t 2016-04-22 00:54:36 +00:00
Reserves Bug 13592: Add an option to charge for any hold placed 2015-12-31 15:59:05 +00:00
SIP Bug 18996: (followup) Fix tests count [16.11.x] 2017-10-24 17:35:21 +13:00
Search Bug 18976: [16.11] Add missing use statement 2017-08-23 22:22:38 +12:00
Serials Bug 18697: Final polishing 2017-07-31 01:02:07 +12:00
Template/Plugin Bug 19441: Fix AuthorisedValues.t 2017-10-13 13:22:14 +13:00
Utils Bug 18094: Add tests to highlight the problem 2017-05-04 02:52:33 +12:00
XSLT_Handler Bug 13262 - Add parameters to XSLT Handler transform method 2015-02-05 15:24:29 -03:00
api/v1 Bug 16271: Allow more filters on /api/v1/holds 2016-08-01 11:11:13 +02:00
data Bug 12419: (QA followup) regression tests 2014-06-30 15:57:23 -03:00
selenium Bug 18982: Remove data in the correct order 2017-08-23 21:28:42 +12:00
www Bug 18807: t/db_dependent/www/batch.t fails 2017-07-31 01:02:06 +12:00
00-strict.t Bug 18233 - t/db_dependent/00-strict.t has non-existant resetversion.pl 2017-05-24 14:26:22 +12:00
Accounts.t Bug 16607: Remove CPL/MPL from two unit tests 2016-06-24 07:28:45 +02:00
Acquisition.t Bug 16934: Add test for ModOrder 2016-08-01 13:31:23 +02:00
AdditionalField.t Bug 10855: Remove additional field values when subscription is removed 2015-10-02 15:10:31 -03:00
Amazon.t Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
AudioAlerts.t Bug 11431: (QA followup) remove diags 2015-11-06 15:08:37 -03:00
Auth.t Bug 18976: Fix t/db_dependent/Auth.t cleanup 2017-08-23 22:22:38 +12:00
Auth_with_cas.t Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
Auth_with_ldap.t Bug 17615 - Fix unit tests 2017-01-25 14:53:46 +13:00
AuthorisedValues.t Revert "Bug 17249: Remove GetKohaAuthorisedValuesFromField - Add search_by_marc_field" 2017-09-20 15:59:27 +12:00
AuthoritiesMarc.t Bug 10985: [UNIMARC] Fix authority summary 2015-04-22 11:54:36 -03:00
BackgroundJob.t Bug 17426: Do not set AutoCommit in tests 2016-10-22 15:10:09 +02:00
Barcodes.t Bug 15878 - Updated unit tests for hbyymmincr barcodes 2016-05-23 17:42:10 +00:00
Barcodes_ValueBuilder.t Bug 15081: (QA followup) Fix issue with Barcodes_ValueBuilder.t 2015-11-04 12:32:57 -03:00
Biblio.t Bug 18554: Adjust a few typos including responsability 2017-07-31 01:02:09 +12:00
Bookseller.t Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
Branch.t Bug 15629: Fix tests - Koha::Library does not have ->categories but ->get_categories 2016-02-24 03:55:07 +00:00
Breeding.t Bug 12898: (regression test) test terms inside double quotes 2014-09-14 02:02:51 -03:00
Budgets.t Bug 18941 - Unit tests 2017-10-24 16:42:07 +13:00
Category.t Bug 15081: (followup) Make test files using TestBuilder handle their transactions 2015-11-04 12:32:57 -03:00
Charset.t Bug 8218 : Add a maintenance script to sanitize biblio records 2014-11-11 15:38:36 -03:00
Circulation.t Bug 18759: (follow-up) Try to fix random failure from Circulation.t 2017-07-30 07:16:35 +12:00
ClassSource.t Bug 16860: Remove the comment about the warning 2016-08-01 10:50:08 +02:00
ColumnsSettings.t Bug 16177: Fix tests for ColumnsSsettings.t 2016-04-01 19:08:23 +00:00
Context.t Bug 16813: Allow empty string for OPACBaseURL 2016-08-01 13:31:21 +02:00
Contract.t Bug 14693: Contract.t should generate dates based on current date 2015-08-21 10:43:38 -03:00
CourseReserves.t Bug 15530 - Add Unit Test 2016-01-27 00:58:14 +00:00
DecreaseLoanHighHolds.t Bug 17573: Remove itemtype-related warnings from DecreaseLoanHighHolds.t 2016-12-12 14:54:09 +13:00
Filter_MARC_ViewPolicy.t Bug 15870: Follow up to address comment #20 2016-03-24 20:15:40 +00:00
Fines.t Bug 13590: Add ability to charge fines at start of charge period 2015-10-22 14:51:24 -03:00
FrameworkPlugin.t Bug 14199: Unify marc orgcode plugins, not overwriting existing values 2016-02-26 14:04:28 +00:00
Heading_MARC21.t Merge remote-tracking branch 'origin/new/bug_7284' 2012-04-04 18:18:26 +02:00
Hold.t Bug 16609: Catch warning from Koha::Hold in Hold.t 2016-06-15 09:04:06 +02:00
Holds.t Bug 16717: Improve variable naming 2016-06-24 07:29:30 +02:00
HoldsQueue.t Bug 18605: Remove TRUNCATE from C4/HoldsQueue.pm 2017-08-23 22:14:11 +12:00
Holidays.t Bug 16376: (regression tests) 2017-01-03 14:22:37 +13:00
ILSDI_Services.t Bug 16155: (QA followup) fix small bug in t/db_dependent/ILSDI_Services.t 2016-05-04 13:47:58 +00:00
ImportBatch.t Bug 18611: [QA Follow-up] Add unit test for GetItemNumbersFromImportBatch 2017-07-30 06:43:18 +12:00
Installer.t Bug 17234: Need to separate KEY and FOREIGN KEY checks 2017-01-25 13:19:12 +13:00
Items.t Bug 17512: Improve handling dates in C4::Items 2017-02-23 09:36:21 +13:00
KitchenSinkPlugin.kpz Bug 17368: Update KitchenSinkPlugin.kpz 2016-10-22 15:12:40 +02:00
Koha.t Bug 16157: Move the selected flag from GetAuthorisedValues to the templates 2016-04-07 00:16:09 +00:00
Koha_Authority.t Bug 15578: Insert authority records before processing tests 2016-01-23 18:28:49 +00:00
Koha_Database.t Bug 13645: Cache the DBIx connection 2015-02-20 14:37:08 -03:00
Koha_Misc_Files.t Bug 3050: QA follow-up 2014-05-25 21:15:03 +00:00
Koha_borrower_modifications.t Revert "Bug 17494: Prevent duplicate tokens from getting stored" 2016-12-31 14:44:57 +13:00
Languages.t Bug 16866: Catch warning t/db_dependent/Languages.t 2016-08-01 11:33:45 +02:00
Letters.t Revert "Bug 18613: Add unit tests for getletter" 2017-07-31 04:04:35 +12:00
Linker_FirstMatch.t Bug 16868: Silence error t/db_dependent/Linker_FirstMatch.t 2016-08-05 09:00:34 +02:00
Log.t Bug 18991: Fix cleanup in t/db_dependent/Log.t 2017-08-23 22:14:54 +12:00
MarcModificationTemplates.t Bug 15669: Add a test for GetModificationTemplates 2016-03-03 22:11:44 +00:00
Members.t Bug 19126: Fix Members.t with IndependentBranches set 2017-10-24 16:42:08 +13:00
MungeMarcPrice.t Bug 15084: Replace C4::Budgets::GetCurrencies with Koha::Acquisition::Currencies->search 2016-03-03 20:39:01 +00:00
NewsChannels.t Bug 16550: Clean the tests 2016-05-23 17:37:48 +00:00
Overdues.t Bug 13624 - Remove columns branchcode, categorytype from table overduerules_transport_types 2015-12-31 12:47:16 +00:00
Passwordrecovery.t Bug 18025: Fix test 2017-02-23 10:26:47 +13:00
Patron.t Bug 14577 [QA Followup] 2016-04-29 11:54:23 +00:00
PatronLists.t Bug 16452: Remove the warnings raised by PatronLists.t 2016-05-05 20:44:47 +00:00
Patrons.t Bug 17742: Use TestBuilder to create the library and patron category 2017-01-25 12:47:57 +13:00
Plugins.t Bug 16502: Replace a few other ok-calls by is-calls 2016-06-24 07:25:41 +02:00
QueryParser.t Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
Ratings.t Bug 14878: Tests - Create the branchcodes when needed 2015-11-06 15:51:51 -03:00
Record.t Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
RecordProcessor_EmbedSeeFromHeadings.t Bug 15380: Move Koha::Authority to Koha::MetadataRecord::Authority 2015-12-31 18:50:41 +00:00
Reports.t Bug 5327: Shifting a db dependent test to the right place 2012-02-01 18:15:19 +01:00
Reserves.t Bug 19047: Fix AddBiblio call in Reserves.t 2017-10-24 16:42:06 +13:00
Review.t Bug 15548: Move new patron related code to Patron* 2016-03-03 14:38:26 -07:00
RotatingCollections.t Bug 15629: Koha::Libraries - Remove ModBranch 2016-02-24 03:55:06 +00:00
Search.t Revert "Bug 17917: [QA Follow-up] Reprove Search.t" 2017-01-27 17:07:56 +13:00
Serials.t Bug 18460: Fix undefined itemtype warning in Serials.t 2017-04-30 23:19:59 +12:00
Serials_2.t Bug 14878: Tests - Create the branchcodes when needed 2015-11-06 15:51:51 -03:00
Service.t Bug 5477 [SIGN-OFF] Fix test cases that require database access 2011-01-29 17:02:31 +13:00
ShelfBrowser.t Bug 19047: Fix AddBiblio call in ShelfBrowser.t 2017-10-24 16:42:06 +13:00
Sitemapper.t Bug 17920: t/db_dependent/Sitemapper.t fails because of permissions 2017-01-25 15:05:56 +13:00
Stats.t Bug 11230 - Refactor C4::Stats::UpdateStats and add UT 2014-07-27 11:29:28 -03:00
SuggestionEngine_ExplodedTerms.t Bug 9857: Fix failing tests 2017-10-24 16:42:12 +13:00
Suggestions.t Bug 16325: Add a test for SearchSuggestions when searching for STATUS='' 2016-05-05 20:46:01 +00:00
Tags.t Bug 12916 - Missing Test to demonstrate warnings. 2014-10-30 00:31:26 -03:00
Templates.t Bug 18010: Unit test for gettemplate 2017-04-04 03:45:18 +12:00
TestBuilder.t Bug 17726: [QA Follow-up] Add test descriptions 2017-02-22 21:58:09 +13:00
Upload.t Bug 16501: Remove some unneeded warns in Upload.t 2016-05-16 17:46:25 +00:00
UsageStats.t Bug 18066: Hea V2 [squashed] 2017-05-24 13:44:59 +12:00
Virtualshelves.t Bug 19343: [16.11.X] Add tests 2017-10-24 17:35:20 +13:00
XISBN.t Bug 19440: Identify overlimit problems in XISBN tests 2017-10-24 17:35:22 +13:00
XSLT_Handler.t Bug 13262: (QA followup) fix duplicate variable definition 2015-02-05 15:25:50 -03:00
check_sysprefs.t Revert "Bug 17917: [AMENDED] Fix path issue in t/db_dependent/check_sysprefs.t" 2017-01-27 17:07:44 +13:00
db_structure.t Bug 16173: db_structure.t shouldn't have a fixed number of tests 2016-04-01 19:14:53 +00:00
default_search_class.pl Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
rollingloans.t Bug 13315 - Add feedback for last item checked out to circulation.pl 2015-04-13 14:52:26 -03:00
sysprefs.t Bug 11998: Use Koha::Cache to cache sysprefs 2016-03-15 07:08:28 +00:00
zebra_config.pl Bug 15082: t/db_dependent/Search.t shouldn't mock the DB connection 2015-10-29 14:10:23 -03:00