Koha-clms/opac
Tomas Cohen Arazi 5b775aee69 Bug 28478: Make opac-*detail.pl scripts use Koha::Biblio->opac_suppressed()
This patch makes the following scripts use the new method for checking
suppression:

* opac/opac-ISBDdetail.pl
* opac/opac-MARCdetail.pl
* opac/opac-detail.pl

In the `opac-detail.pl` case, it is a simple change by removing MARC
data traversal in favor of the new method. The code checking
suppression gets moved up so we don't process or make any other
calculations if the record is suppressed.

The other two scripts where completely missing the check and thus
leaking suppressed records.

To test:
1. Pick two records, one marked as suppressed, and the other not
   suppressed.
2. Try acessing them in the OPAC detail page.
=> SUCCESS: Suppressed records are suppressed, and not suppressed ones
are not.
3. Try the same records on the ISBD and MARC view
=> FAIL: They are not suppressed!
4. Apply this patch
5. Repeat 2
=> SUCCESS: Suppression is still respected
6. Repeat 3
=> SUCCESS: Suppression is respected on the ISBD and MARC views
7. Sign off :-D

Signed-off-by: Magnus Enger <magnus@libriotech.no>
Works as advertised. Remember to activate OPAC suppression with
OpacSuppression.
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz>
2025-02-24 21:20:19 +00:00
..
clubs
…
errors Bug 37741: Do not send cookie back from error pages 2024-11-15 20:31:16 +00:00
external/overdrive
…
sci Bug 34478: Changes for opac/sci/sci-main 2024-03-01 10:57:38 +01:00
sco Bug 38041: Pass hide_main for all needsconfirm warnings in SCO 2024-11-22 21:16:28 +00:00
svc Bug 35942: OPAC user can enroll several times to the same club 2024-07-11 20:07:29 +00:00
ilsdi.pl Bug 30944: Undo change to ILS-DI documentation 2022-10-03 13:44:11 -03:00
maintenance.pl Bug 23798: Convert OpacMaintenanceNotice system preference to additional contents 2023-11-08 17:41:27 -03:00
oai.pl
…
opac-ISBDdetail.pl Bug 28478: Make opac-*detail.pl scripts use Koha::Biblio->opac_suppressed() 2025-02-24 21:20:19 +00:00
opac-MARCdetail.pl Bug 28478: Make opac-*detail.pl scripts use Koha::Biblio->opac_suppressed() 2025-02-24 21:20:19 +00:00
opac-account-pay-return.pl
…
opac-account-pay.pl Bug 36088: Remove useless code form opac-account-pay.pl 2024-03-07 15:02:43 +01:00
opac-account.pl
…
opac-addbybiblionumber.pl Bug 35126: Remove onload from opac-addbybiblionumber.pl 2024-12-05 21:59:30 +00:00
opac-alert-subscribe.pl Bug 34478: op =~ ^cud- in pl/pm 2024-03-01 10:56:11 +01:00
opac-alert-subscriptions.pl Bug 34478: Remove generate_csrf from pl 2024-03-01 10:55:56 +01:00
opac-article-request-cancel.pl
…
opac-authorities-home.pl Bug 37057: Restore filtering of unused authorities 2024-11-18 17:20:45 +00:00
opac-authoritiesdetail.pl Bug 29948: OPACAuthorIdentifiersAndInformation 2024-05-13 14:00:10 +02:00
opac-basket.pl Bug 33102: Display fields from biblioitems in OPAC/staff interface cart 2023-05-05 17:45:19 -03:00
opac-blocked.pl Bug 35952: Remove unnecessary line for OpacSuppressionMessage 2024-03-07 15:02:50 +01:00
opac-browse.pl
…
opac-browser.pl Bug 34478: op =~ ^cud- in pl/pm 2024-03-01 10:56:11 +01:00
opac-changelanguage.pl
…
opac-course-details.pl Bug 32445: (follow-up) Fix availability display on opac-course-details 2023-01-05 09:09:48 -03:00
opac-course-reserves.pl
…
opac-curbside-pickups.pl Bug 34478: op =~ ^cud- in pl/pm 2024-03-01 10:56:11 +01:00
opac-detail.pl Bug 28478: Make opac-*detail.pl scripts use Koha::Biblio->opac_suppressed() 2025-02-24 21:20:19 +00:00
opac-discharge.pl Bug 34478: op =~ ^cud- in pl/pm 2024-03-01 10:56:11 +01:00
opac-dismiss-message.pl Bug 36532: Protect opac-dismiss-message.pl from malicious usages 2024-05-14 15:04:34 -03:00
opac-downloadcart.pl Bug 29697: Use flag embed_items 2022-07-22 15:24:11 -03:00
opac-downloadshelf.pl Bug 33069: Fix error in MARC download for OPAC lists 2023-05-09 10:57:55 -03:00
opac-export.pl Bug 37679: Add DC subtypes to allow-list in opac-export.pl 2024-11-18 18:52:12 +00:00
opac-holdshistory.pl
…
opac-ics.pl Bug 30927: Improve formatting or iCal files for checkout due dates 2022-08-09 07:39:17 -03:00
opac-idref.pl
…
opac-illrequests.pl Bug 35581: Koha::Illrequest -> Koha::ILL::Request 2024-04-22 08:57:45 +02:00
opac-image.pl Bug 33047: Return 404 instead of 500 when biblio does not exist 2023-07-10 15:43:14 -03:00
opac-imageviewer.pl
…
opac-issue-note.pl Bug 34478: op =~ ^cud- in pl/pm - Manual cud-email => email 2024-03-01 10:57:14 +01:00
opac-library.pl Bug 31775: Show single library 2022-10-17 08:25:55 -03:00
opac-main.pl Bug 31383: Create a parent-child DB relation for additional content 2023-10-20 14:43:56 -03:00
opac-memberentry.pl Bug 37339: Set messaging preferences from default on self registration 2024-10-09 22:00:53 +00:00
opac-messaging.pl Bug 34478: Add 'op' to opac-messaging 2024-03-01 10:57:07 +01:00
opac-modrequest-suspend.pl Bug 34478: Manual fix - add ops - hold-table.inc opac-user.tt 2024-03-01 10:57:21 +01:00
opac-modrequest.pl Bug 34478: Manual fix - add ops - hold-table.inc opac-user.tt 2024-03-01 10:57:21 +01:00
opac-mymessages.pl
…
opac-news-rss.pl
…
opac-overdrive-search.pl
…
opac-page.pl Bug 36875: Do not pass unsanitized language to $page->translated_content 2024-06-06 10:49:20 +02:00
opac-passwd.pl Bug 34478: op =~ ^cud- in pl/pm 2024-03-01 10:56:11 +01:00
opac-password-recovery.pl Bug 37887: OPAC password recovery needs to use a cud- op while POSTing new password 2024-11-18 22:02:00 +00:00
opac-patron-consent.pl Bug 31503: Make opac-patron-consent more generic 2023-10-25 10:35:20 -03:00
opac-patron-image.pl
…
opac-privacy.pl Bug 34478: op =~ ^cud- in pl/pm 2024-03-01 10:56:11 +01:00
opac-ratings.pl Bug 34478: Add 'op' to opac-ratings 2024-03-01 10:57:09 +01:00
opac-readingrecord.pl Bug 33949: Replace GetAllIssues with Koha::Checkouts - opac 2023-10-18 15:41:26 -03:00
opac-recall.pl Bug 36142: recallsview template param for opac-recall.tt 2024-04-05 11:51:23 +02:00
opac-recalls.pl
…
opac-registration-verify.pl Bug 37339: Set messaging preferences from default on self registration 2024-10-09 22:00:53 +00:00
opac-renew.pl Bug 34478: op =~ ^cud- in pl/pm 2024-03-01 10:56:11 +01:00
opac-reportproblem.pl Bug 34478: Manual fix - problem_reports 2024-03-01 10:56:59 +01:00
opac-request-article.pl Bug 34478: Add 'op' to opac-request-article 2024-03-01 10:57:08 +01:00
opac-reserve.pl Bug 35977: (follow-up) Cleaner working approach 2024-05-02 13:19:12 +02:00
opac-reset-password.pl Bug 34478: op =~ ^cud- in pl/pm 2024-03-01 10:56:11 +01:00
opac-restrictedpage.pl
…
opac-retrieve-file.pl
…
opac-review.pl Bug 13342: Not logged user can place a review/comment 2024-09-30 15:29:21 +00:00
opac-routing-lists.pl
…
opac-search-history.pl Bug 34478: Manual fix - action to op / add cud- - opac-search-history 2024-03-01 10:57:13 +01:00
opac-search.pl Bug 36557: Convert Cart and Lists controls to buttons and rework logic 2024-11-18 17:15:32 +00:00
opac-sendbasket.pl Bug 36520: Sanitize input in opac-sendbasket.pl 2024-06-06 10:49:20 +02:00
opac-sendshelf.pl Bug 34478: Changes for opac-sendshelf 2024-03-01 10:57:25 +01:00
opac-serial-issues.pl
…
opac-shareshelf.pl Bug 34478: Changes for opac-shareshelf 2024-03-01 10:59:26 +01:00
opac-shelves.pl Bug 38362: Fix printing lists on opac/opac-shelves.pl 2024-12-17 01:31:45 +00:00
opac-showmarc.pl
…
opac-showreviews.pl Bug 29697: Replace GetMarcBiblio occurrences with $biblio->metadata->record 2022-07-22 15:24:11 -03:00
opac-suggestions.pl Bug 37152: Aquisitions basket and OPAC suggestion deletion should use the op cud-delete 2024-07-18 19:52:37 +00:00
opac-tags.pl Bug 36785: Typo unreconized and bilbio in tags code 2024-05-17 10:36:35 +02:00
opac-tags_subject.pl
…
opac-topissues.pl Bug 34478: op =~ ^cud- - Manual - cud-do_it => do_it 2024-03-01 10:58:32 +01:00
opac-user.pl Bug 34478: Remove check_csrf from pl files 2024-03-01 10:56:01 +01:00
tracklinks.pl Bug 30262: Trim whitespace off tracklinks.pl URLs 2022-08-31 08:46:11 -03:00
unapi
…