gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
31,906 Commits 39 Branches 720 Tags 6 GiB
Perl 44.2%
JavaScript 41.1%
HTML 6%
XSLT 3.1%
Vue 1.9%
Other 3.2%
Go to file
Owen Leonard af2c813745
Bug 16575: Irregular behaviour using window.print() followed by window.location.href 
This patch updates the OPAC and staff client carts to use CSS to
control print output, removing a print parameter which was passed to the
script.

Currently, when you click "Print" on the OPAC basket, it navigates to
a new page and initiates window.print() followed by a
window.location.href change again. Unfortunately, due to differences in
IE, Chrome, and FF, it will either show the print options, navigate away
without showing them, or refuse to navigate away after printing. By
changing to using print CSS, we don't navigate away from the basket in
the first place, so we prevent this irregular behavior.

TEST PLAN

1) Apply the patch
2) Create an OPAC basket by clicking "Add to cart" on multiple items
3) Using Chrome, IE, and Firefox (of any version), click the "Print"
   button
4) You should see the relevant print menu without the OPAC basket
   re-loading in any way.
5) After printing is complete, you should still be on the OPAC basket
   pop-up
6) Perform the same tests in the staff client

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit a9836864dc)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
 		2018-08-02 14:43:04 +01:00
C4 Bug 18822: Check if we have MARC::Record and convert if not when using ES 2018-07-15 20:28:31 +01:00
Koha Bug 20942: (QA follow-up) Use $lines->total_outstanding 2018-08-02 14:43:03 +01:00
OpenILS Bug 9239 QA follow-up: remove stray debug code 2013-03-16 21:32:34 -04:00
acqui Bug 20861: Correct EDI permissions on EDI messsages 2018-06-05 12:26:00 +01:00
admin Bug 14446: Workaround to resolve uninitialized value in goto warning 2018-07-15 20:11:26 +01:00
api/v1 Bug 20942: Split debit and credit lines 2018-08-02 14:43:03 +01:00
authorities Bug 15360: Incorrect or mislabeled behavior on Authorities "New from Z39.50" Button 2018-07-02 18:06:37 +01:00
basket Bug 16575: Irregular behaviour using window.print() followed by window.location.href 2018-08-02 14:43:04 +01:00
catalogue Bug 20934: Fix display of old checkouts in the checkout history page 2018-07-18 13:34:59 +01:00
cataloguing Bug 21009: Fix max length of inputs on editing/adding items 2018-07-15 19:44:34 +01:00
circ Bug 20851: Add module to circ/article-request-slip.pl 2018-06-11 10:33:12 +01:00
clubs Bug 18632: Remove 'CGI::param called in list context' warnings 2017-05-28 22:25:22 -04:00
course_reserves Bug 19230: Preventing warn when deleting course 2018-01-30 14:18:21 -03:00
debian Bug 20079: Display stack trace for development installations 2018-08-02 14:43:03 +01:00
docs Bug 20906: Prevent test failures due to stricter perl 2018-06-25 18:13:55 +01:00
errors Bug 19998: use Modern::Perl in error perl scripts 2018-02-05 09:45:48 -03:00
etc Revert "Bug 20073: Move Elasticsearch configs to yaml files and improve the default settings." 2018-05-21 11:02:16 -03:00
ill Bug 20556: Marking ILL request as complete.. 2018-04-20 11:42:00 -03:00
installer Increment version for 18.05.02 release 2018-07-23 21:34:02 +01:00
koha-tmpl Bug 16575: Irregular behaviour using window.print() followed by window.location.href 2018-08-02 14:43:04 +01:00
labels Bug 12020: Allow translating label-edit-batch hardcoded strings 2018-03-26 17:31:15 -03:00
members Bug 21008: Use Koha::Patron->is_child 2018-07-15 21:40:50 +01:00
misc Update release notes for 18.05.02 release 2018-07-23 21:34:02 +01:00
offline_circ Bug 19752: offline_circ/service.pl - Return HTTP status 401 when authentication failed and add option nocookie 2018-05-03 13:26:48 -03:00
opac Bug 20953: Prevent several discharge requests on OPAC 2018-07-15 20:01:34 +01:00
patron_lists Bug 19837: Add error feedback for duplicated or unfound cardnumbers 2018-02-18 16:48:46 -03:00
patroncards Bug 20010: use Modern::Perl in Patroncards perl scripts 2018-02-05 09:46:44 -03:00
plugins Bug 20011: use Modern::Perl in plugins perl scripts 2018-02-05 09:46:44 -03:00
reports Bug 16653: (QA follow-up) Avoid a warning and remove unused variables 2018-07-02 08:23:42 +01:00
reserve Bug 20724: Move the ReservesNeedReturns logic to AddReserve 2018-05-16 10:53:13 -03:00
reviews Bug 18789: Send Koha::Patron object to the templates 2018-02-16 13:03:58 -03:00
rotating_collections Bug 15758: Koha::Libraries - Remove GetBranches 2016-09-08 14:36:03 +00:00
serials Bug 20730: Move the authentication block before doing anything 2018-05-23 11:44:10 -03:00
services Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
skel Bug 11078: Add locking to rebuild_zebra 2014-02-28 22:21:41 +00:00
suggestion Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
svc Bug 20760: Fill authorised values in svc framework 2018-06-15 13:10:13 +01:00
t Bug 20942: Split debit and credit lines 2018-08-02 14:43:03 +01:00
tags Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
test Bug 9819 - 'stopwords'-related code removed 2015-12-30 15:49:35 +00:00
tmp/modified_authorities
…
tools Bug 20695: Fix multiple upload result in tools/upload script 2018-05-11 10:52:45 -03:00
virtualshelves Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
xt Bug 20906: Fix translatable-templates.t 2018-06-25 18:13:55 +01:00
.editorconfig Bug 12545: Add EditorConfig.org file to the source tree 2014-08-22 11:07:45 -03:00
.gitignore Bug 20267: Add basic .gitignore 2018-03-26 17:31:16 -03:00
.htaccess Fix file permissions: if it is not a script, it should not be executable. 2010-04-16 00:40:34 -04:00
.mailmap Update mailmap - Jonathan Druart 2017-06-21 12:42:19 -03:00
INSTALL Bug 17626: Remove existing install instructions and link to the wiki pages instead 2016-11-22 11:29:07 +00:00
Koha.pm Increment version for 18.05.02 release 2018-07-23 21:34:02 +01:00
LICENSE Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
MANIFEST.SKIP Bug 9546 : Updating make manifest tardist 2013-02-06 23:54:46 -05:00
Makefile.PL Bug 18342: Enable memcached by default for new installs 2018-05-03 12:47:07 -03:00
README Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
README.md Bug 15465: Fix typo in bugs.k-c.org 2017-05-26 11:45:31 -03:00
README.robots Bug 6411 add another example to README.robots 2011-07-05 14:48:05 +12:00
about.pl Bug 20428: Display warning if the entry is empty 2018-05-14 11:14:40 -03:00
changelanguage.pl Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
edithelp.pl Bug 18403: Update permissions - borrowers => 1|* becomes borrowers => 'edit_borrowers' 2018-02-12 15:41:37 -03:00
fix-perl-path.PL Bug 9978: (followup) Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:43 -03:00
help.pl Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
install-CPAN.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
koha_perl_deps.pl Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
kohaversion.pl Bug 13758: Move the Koha version from kohaversion.pl 2015-05-07 11:39:04 -03:00
mainpage.pl Bug 20489: Remove warnings from the interface 2018-04-20 12:24:00 -03:00
rewrite-config.PL Bug 18342: Enable memcached by default for new installs 2018-05-03 12:47:07 -03:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo