Go to file
Tomas Cohen Arazi aebe7f2e33 Bug 28772: Make Koha::ApiKey->store encrypt the secret
This patch refactors the Koha::ApiKey class so:
- It encrypts the generated secret
- Allows accessing the plain text secret only immediately after the key
  creation (this implies that it won't be accessible if the key is
  fetched from the DB).
- It implements an allow list for attributes, that are not read only.
  Changing any other of them will make ->store throw an exception.
- A method for validating plain text secrets against the encrypted one
  is added.
- A method for accessing the plain text secret is added. Returns undef
  if the object is not 'fresh'.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/ApiKey.t
=> SUCCESS: Tests pass! Expected behavior is confirmed
3. Sign off :-D

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz>
2021-09-16 02:17:36 +00:00
C4 Bug 28644: [19.11.x] Fix calling borrowernumber on undefined value 2021-09-08 01:00:53 +00:00
Koha Bug 28772: Make Koha::ApiKey->store encrypt the secret 2021-09-16 02:17:36 +00:00
OpenILS Bug 9239 QA follow-up: remove stray debug code 2013-03-16 21:32:34 -04:00
acqui Bug 26997: Remove 0000-00-00 from aqorders.datecancellationprinted 2021-03-18 21:02:44 +01:00
admin Bug 27416: Make "Modify tag" and "Add tag" translatable 2021-02-02 00:37:15 +01:00
api Bug 23653: [19.11] use local copy of swagger v2 schema 2021-07-08 01:33:52 +00:00
authorities Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
basket Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
catalogue Merge branch 'new/security-release-19.11.09' into 19.11.x 2020-08-19 07:11:07 +12:00
cataloguing Bug 26605: Correctly URI-encode query string in call number browse plugin 2020-11-17 18:15:44 +13:00
circ Bug 27676: Correct finesMode ne off condition 2021-02-21 16:18:24 +01:00
clubs Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
course_reserves Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
debian Bug 28364: Make log4perl.conf belong to the instance user 2021-06-16 07:37:00 +00:00
docs Bug 28476: Update info in docs/teams.yaml file 2021-07-12 01:24:17 +00:00
errors Bug 23329: Move error page to its own subroutine 2019-11-27 11:30:19 +00:00
etc Revert "Bug 27299: Remove tokenization for phrase register/index with ICU" 2021-02-04 18:35:03 +01:00
ill Bug 21460: (follow-up) Fix bugs found in QA 2019-04-25 10:46:56 +00:00
installer Increment version for 19.11.21 release 2021-08-25 00:47:42 +00:00
koha-tmpl Bug 28759: limit accessibility for "Manage API keys" 2021-09-16 02:09:45 +00:00
labels Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
members Bug 28759: limit accessibility for "Manage API keys" 2021-09-16 02:09:45 +00:00
misc Update release notes for 19.11.21 release 2021-08-25 01:02:06 +00:00
offline_circ Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
opac Bug 28941: Deal with OPACSuggestionUnwantedFields 2021-09-16 02:04:19 +00:00
patron_lists Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
patroncards Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
plugins Bug 25549: Add error reporting to plugins-home 2020-11-17 17:12:45 +13:00
reports Bug 28524: Escape 'rank' in cat_issues_top.pl 2021-07-22 07:47:35 +00:00
reserve Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
reviews Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
rotating_collections Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
serials Bug 26604: "Generate next" button gives error on serials-collection.pl 2020-11-17 16:45:07 +13:00
services Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
skel Bug 11078: Add locking to rebuild_zebra 2014-02-28 22:21:41 +00:00
suggestion Bug 22868: Move suggestions_manage subperm out of acquisition perm 2020-02-10 23:08:59 +00:00
svc Bug 26457: [19.11.x] Throw exception if update of issues table fails 2021-03-24 00:39:44 +01:00
t Bug 28772: Make Koha::ApiKey->store encrypt the secret 2021-09-16 02:17:36 +00:00
tags Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
tmp/modified_authorities
…
tools Bug 26298: Don't set too_many_items_to_process if equal to limit 2021-02-11 02:48:46 +01:00
virtualshelves Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
xt Bug 21576: Keep compatibility with QA script 2018-10-26 17:09:52 +00:00
.editorconfig Bug 12545: Add EditorConfig.org file to the source tree 2014-08-22 11:07:45 -03:00
.eslintrc.json Bug 23834: Add default ESLint configuration 2019-11-03 08:02:39 +00:00
.gitignore Bug 20427: Convert OPAC LESS to SCSS 2018-08-09 15:17:07 +00:00
.htaccess
…
.mailmap Bug 28386: Disambiguate Tomas and Blou 2021-06-30 05:23:21 +00:00
.scss-lint.yml Bug 21237: Clean up staff client SCSS 2018-08-24 16:23:25 +00:00
INSTALL Bug 17626: Remove existing install instructions and link to the wiki pages instead 2016-11-22 11:29:07 +00:00
Koha.pm Increment version for 19.11.21 release 2021-08-25 00:47:42 +00:00
LICENSE Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
MANIFEST.SKIP Bug 9546 : Updating make manifest tardist 2013-02-06 23:54:46 -05:00
Makefile.PL Bug 25792: Rename 'ttf-dejavu' package to 'fonts-dejavu' for Debian 11 2020-09-09 22:18:40 +12:00
README Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
README.md Bug 27092: Remove note about "synced repo" from README.md 2020-12-16 22:36:52 +01:00
README.robots
…
about.pl Bug 28386: Sort authors by lastname || firstname 2021-06-30 05:24:20 +00:00
changelanguage.pl Bug 21299: (QA follow-up) Rename module and subroutine 2018-11-07 21:52:17 +00:00
fix-perl-path.PL Bug 9978: (followup) Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:43 -03:00
gulpfile.js Bug 26228: Update gulpfile to work with Node.js v12 2020-09-09 16:04:42 +12:00
help.pl Bug 19817: Use the language from the interface if valid 2018-09-06 17:32:28 +00:00
koha_perl_deps.pl Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
kohaversion.pl Bug 13758: Move the Koha version from kohaversion.pl 2015-05-07 11:39:04 -03:00
mainpage.pl Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
package.json Bug 26228: Update gulpfile to work with Node.js v12 2020-09-09 16:04:42 +12:00
rewrite-config.PL Bug 25792: Rename 'ttf-dejavu' package to 'fonts-dejavu' for Debian 11 2020-09-09 22:18:40 +12:00
yarn.lock Bug 26228: Update gulpfile to work with Node.js v12 2020-09-09 16:04:42 +12:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo